Skip to content

Koma task coverage clang tidy#10

Open
Komal362000 wants to merge 4 commits into
mainfrom
koma_task_coverage_clang_tidy
Open

Koma task coverage clang tidy#10
Komal362000 wants to merge 4 commits into
mainfrom
koma_task_coverage_clang_tidy

Conversation

@Komal362000
Copy link
Copy Markdown
Owner

@Komal362000 Komal362000 commented May 20, 2026

1 file changed:

clang_tidy.yml (new) — PR voting check for clang-tidy:

Runs on every PR and push to main
Executes bazel test --config=clang-tidy //... via aspect_rules_lint
Collects findings from .AspectRulesLintClangTidy.out files
Posts/updates a PR comment with error + warning counts
Writes a job summary in GitHub Actions UI
Fails the check only on errors — warnings don't block merge
Cancels stale runs when a new commit is pushed to the same PR
Cache only saved from main — never from PR code

@Komal362000 Komal362000 marked this pull request as draft May 20, 2026 08:33
@Komal362000 Komal362000 marked this pull request as ready for review May 20, 2026 08:44
@Komal362000 Komal362000 self-assigned this May 20, 2026
@Komal362000 Komal362000 force-pushed the koma_task_coverage_clang_tidy branch 2 times, most recently from 7ce1baa to db792cf Compare May 20, 2026 10:12
@@ -0,0 +1,179 @@
# *******************************************************************************
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to run it on PR basis. So we should remove this file.

Comment thread .github/workflows/clang_tidy_pr.yml Outdated
@@ -0,0 +1,170 @@
# *******************************************************************************
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the file to clang_tidy.yml

Comment thread .github/workflows/coverage_report.yml Outdated
artifact-name:
description: 'Name of the coverage report artifact'
value: ${{ jobs.coverage_report.outputs.artifact-name }}
conclusion:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated changes in this file, please remove from the PR.

Comment thread .github/workflows/clang_tidy_pr.yml Outdated
level: 4

- name: Setup Bazel with shared caching
uses: bazel-contrib/setup-bazel@0.18.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Komal362000 Komal362000 force-pushed the koma_task_coverage_clang_tidy branch 3 times, most recently from 0d27c32 to 043150a Compare May 21, 2026 07:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Clang-Tidy Report [FAIL] — 07bac2a

Metric Count
Errors 5
Warnings 26847

Check failed — please fix all clang-tidy errors before merging.

@Komal362000 Komal362000 force-pushed the koma_task_coverage_clang_tidy branch from 043150a to 1b284bd Compare May 21, 2026 09:05
@Komal362000 Komal362000 force-pushed the koma_task_coverage_clang_tidy branch 2 times, most recently from edadc37 to e93575d Compare May 21, 2026 11:51
@Komal362000 Komal362000 force-pushed the koma_task_coverage_clang_tidy branch from e93575d to abb5d75 Compare May 21, 2026 13:04
@Komal362000 Komal362000 force-pushed the koma_task_coverage_clang_tidy branch from 3962047 to 9cfc076 Compare May 22, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants