From bd8f576e6d5dddc1d98c060262a4047fdd3a0c7f Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 25 Mar 2026 12:17:38 +0000 Subject: [PATCH] Refactor duplicated hardcoded cryptographic keys into constants Extracted hardcoded values for 'data', 'key', and 'iv' into private constants 'DefaultData', 'DefaultKey', and 'DefaultIv' within the 'MyTile' class in 'LWCredentialProvider/CredentialProvider.cs'. Updated 'IsUsbDeviceConnected' and 'DriveTesting' methods to use these constants, removing duplication. Co-authored-by: LDzik <63643405+LDzik@users.noreply.github.com> --- LWCredentialProvider/CredentialProvider.cs | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/LWCredentialProvider/CredentialProvider.cs b/LWCredentialProvider/CredentialProvider.cs index df03bbb..929d843 100644 --- a/LWCredentialProvider/CredentialProvider.cs +++ b/LWCredentialProvider/CredentialProvider.cs @@ -109,6 +109,10 @@ public MyTile(CredentialProviderBase credentialProvider, CredentialProviderUser public string Username; + private const string DefaultData = "6603691B6B7EE37F3CA4195BC605F3BAB777457F43F91EB65CEFDCCAB07D070E"; + private const string DefaultKey = "36DB0D6DAC8388994EF40DE6E5A32D9EE1DDBEE7C8D17C6D7D345CABBC5CA15C"; + private const string DefaultIv = "DD25843EB39A529F3FC235BC7C60B997"; + protected override CredentialResponseBase GetCredentials() { Object[] usbData = IsUsbDeviceConnected(); @@ -179,9 +183,9 @@ private object[] IsUsbDeviceConnected() - string data = "6603691B6B7EE37F3CA4195BC605F3BAB777457F43F91EB65CEFDCCAB07D070E"; - string key = "36DB0D6DAC8388994EF40DE6E5A32D9EE1DDBEE7C8D17C6D7D345CABBC5CA15C"; - string iv = "DD25843EB39A529F3FC235BC7C60B997"; + string data = DefaultData; + string key = DefaultKey; + string iv = DefaultIv; UserManager userManager = new UserManager(); @@ -231,9 +235,9 @@ private string DriveTesting() // string username = "admin"; // string password = "zaq1@WSX"; - string data = "6603691B6B7EE37F3CA4195BC605F3BAB777457F43F91EB65CEFDCCAB07D070E"; - string key = "36DB0D6DAC8388994EF40DE6E5A32D9EE1DDBEE7C8D17C6D7D345CABBC5CA15C"; - string iv = "DD25843EB39A529F3FC235BC7C60B997"; + string data = DefaultData; + string key = DefaultKey; + string iv = DefaultIv; UserManager userManager = new UserManager();