From 6e64489bd8d27cd9af939f63e7f279f1dff07f6d Mon Sep 17 00:00:00 2001 From: Jack Royer Date: Tue, 28 Jul 2026 15:06:49 +0200 Subject: [PATCH] Build CI against the committed lockfiles No cargo invocation in either workflow passed --locked, so CI was free to re-resolve and rewrite Cargo.lock instead of failing. A lockfile that no longer matched the manifests still went green, and the versions CI tested were not necessarily the ones recorded in the repository. Pass --locked to every cargo invocation that resolves dependencies, in both workflows. cargo fmt is left alone; it does not resolve anything. This covers crates/qfbvsmtrs/fuzz too, which sits outside the workspace and carries its own Cargo.lock. Both lockfiles are current: all five commands pass with --locked as of this commit. --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/extended.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 89a07ec..de6ca62 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,11 +39,11 @@ jobs: - name: Format run: cargo fmt --all -- --check - name: Test - run: cargo test --workspace + run: cargo test --locked --workspace - name: Clippy - run: cargo clippy --workspace --all-targets -- -D warnings + run: cargo clippy --locked --workspace --all-targets -- -D warnings - name: qfbvsmtrs fuzz crate check - run: cargo check --manifest-path crates/qfbvsmtrs/fuzz/Cargo.toml + run: cargo check --locked --manifest-path crates/qfbvsmtrs/fuzz/Cargo.toml - name: Python client smoke run: python python/tests/test_python_client.py - name: Python package install smoke @@ -55,7 +55,7 @@ jobs: - name: C++ client CMake smoke shell: bash run: | - cargo build -p smt-server + cargo build --locked -p smt-server cd cpp cmake -B build -DCMAKE_BUILD_TYPE=Debug cmake --build build --config Debug diff --git a/.github/workflows/extended.yml b/.github/workflows/extended.yml index 3efbe58..4497611 100644 --- a/.github/workflows/extended.yml +++ b/.github/workflows/extended.yml @@ -26,8 +26,8 @@ jobs: - name: Extended random circuit identities env: QFBVSMTRS_RANDOM_CIRCUIT_SAMPLES: "10000" - run: cargo test -p qfbvsmtrs --test random_circuits randomized_wide_circuit_identities_production_when_enabled + run: cargo test --locked -p qfbvsmtrs --test random_circuits randomized_wide_circuit_identities_production_when_enabled - name: Extended random differential tests against z3 env: QFBVSMTRS_DIFF_RANDOM: "1" - run: cargo test -p qfbvsmtrs --test differential_z3 differential_random_formulas_against_z3_production_when_enabled + run: cargo test --locked -p qfbvsmtrs --test differential_z3 differential_random_formulas_against_z3_production_when_enabled