Skip to content

F-474 · ArrayPool.Shared.Rent(4096) is only returned at the regular end of Replay; if an exception escapes the inner … #374

Description

@LarsLaskowski

Finding: F-474 · Severity: Low · Type: Bug · Criterion: B4
Location: F1ReplayClient/MainWindow.xaml.cs:357,477
Component: W7 · Tools (ReplayClient, PacketTester, SessionFolderRename)

ArrayPool.Shared.Rent(4096) is only returned at the regular end of Replay; if an exception escapes the inner try or the method returns early, the buffer is not returned (no try/finally).


Automatically generated from the repository review (docs/review/FINDINGS-OVERVIEW.md, as of 2026-06-19).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreview-reportIssues from code reviewrobustnessIncreased robustness

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions