Skip to content

Cleanup: Delete dead User model file (firebaseUid leftover from Firebase migration) #41

Description

@ChitkulLakshya

Improvement: Dead User model (firebaseUid) still exists as a file

File: server/models/User.js

Problem

The User MongoDB model with firebaseUid field is dead code — a leftover from the Firebase to Supabase migration (PR #12). Phase 6 (PR #31) removed all references to it from server/index.js, but the file itself still exists:

const userSchema = new mongoose.Schema({
  firebaseUid: { type: String, required: true, unique: true },
  departments: { type: [String], default: [] },
  createdAt: { type: Date, default: Date.now },
  updatedAt: { type: Date, default: Date.now }
});

Departments are now stored in Supabase's profiles table. No production code imports this model anymore.

Fix

Delete server/models/User.js. Verify no other files import it:

grep -r "models/User" server/

If any test files import it, remove those references too.

Severity

Low — Dead code. No runtime impact since it's never imported. But it's confusing for new developers who might think Firebase is still in use.

Phase

Original model from early project. References removed in Phase 6 (PR #31, open). File deletion pending.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions