Skip to content

Commit 4c25560

Browse files
authored
Merge pull request #2 from LegionIO/feature/add-rubocop-legion
add rubocop-legion plugin
2 parents 56bb18d + 860cb0e commit 4c25560

18 files changed

Lines changed: 39 additions & 84 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ jobs:
1010
ci:
1111
uses: LegionIO/.github/.github/workflows/ci.yml@main
1212

13-
lint:
14-
uses: LegionIO/.github/.github/workflows/lint-patterns.yml@main
13+
excluded-files:
14+
uses: LegionIO/.github/.github/workflows/excluded-files.yml@main
1515

1616
security:
1717
uses: LegionIO/.github/.github/workflows/security-scan.yml@main
@@ -27,7 +27,7 @@ jobs:
2727
uses: LegionIO/.github/.github/workflows/stale.yml@main
2828

2929
release:
30-
needs: [ci, lint]
30+
needs: [ci, excluded-files]
3131
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
3232
uses: LegionIO/.github/.github/workflows/release.yml@main
3333
secrets:

.rubocop.yml

Lines changed: 2 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,2 @@
1-
AllCops:
2-
TargetRubyVersion: 3.4
3-
NewCops: enable
4-
SuggestExtensions: false
5-
6-
Layout/LineLength:
7-
Max: 160
8-
9-
Layout/SpaceAroundEqualsInParameterDefault:
10-
EnforcedStyle: space
11-
12-
Layout/HashAlignment:
13-
EnforcedHashRocketStyle: table
14-
EnforcedColonStyle: table
15-
16-
Metrics/MethodLength:
17-
Max: 50
18-
19-
Metrics/ClassLength:
20-
Max: 1500
21-
22-
Metrics/ModuleLength:
23-
Max: 1500
24-
25-
Metrics/BlockLength:
26-
Max: 40
27-
Exclude:
28-
- 'spec/**/*'
29-
30-
Metrics/ParameterLists:
31-
Max: 8
32-
33-
Metrics/AbcSize:
34-
Max: 60
35-
36-
Metrics/CyclomaticComplexity:
37-
Max: 15
38-
39-
Metrics/PerceivedComplexity:
40-
Max: 17
41-
42-
Style/Documentation:
43-
Enabled: false
44-
45-
Style/SymbolArray:
46-
Enabled: true
47-
48-
Style/FrozenStringLiteralComment:
49-
Enabled: true
50-
EnforcedStyle: always
51-
52-
Naming/FileName:
53-
Enabled: false
1+
inherit_gem:
2+
rubocop-legion: config/lex.yml

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## [0.2.5] - 2026-03-30
4+
5+
### Changed
6+
- update to rubocop-legion 0.1.7, resolve all offenses
7+
38
## [0.2.4] - 2026-03-28
49

510
### Added

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@ group :test do
88
gem 'rspec'
99
gem 'rspec_junit_formatter'
1010
gem 'rubocop'
11+
gem 'rubocop-legion', '~> 0.1'
1112
gem 'simplecov'
1213
end

lib/legion/extensions/github.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
module Legion
2020
module Extensions
2121
module Github
22-
extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core
22+
extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core, false
2323
end
2424
end
2525
end

lib/legion/extensions/github/runners/branches.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ def create_branch(owner:, repo:, branch:, from_ref: 'main', **)
1818

1919
{ success: true, ref: create_response.body['ref'], sha: sha }
2020
rescue StandardError => e
21-
log.warn(e.message) if respond_to?(:log, true)
21+
log.warn(e.message)
2222
{ success: false, error: e.message }
2323
end
2424

25-
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
26-
Legion::Extensions::Helpers.const_defined?(:Lex)
25+
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
26+
Legion::Extensions::Helpers.const_defined?(:Lex, false)
2727
end
2828
end
2929
end

lib/legion/extensions/github/runners/comments.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ def delete_comment(owner:, repo:, comment_id:, **)
3535
{ result: response.status == 204 }
3636
end
3737

38-
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
39-
Legion::Extensions::Helpers.const_defined?(:Lex)
38+
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
39+
Legion::Extensions::Helpers.const_defined?(:Lex, false)
4040
end
4141
end
4242
end

lib/legion/extensions/github/runners/commits.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ def compare_commits(owner:, repo:, base:, head:, per_page: 30, page: 1, **)
2727
{ result: response.body }
2828
end
2929

30-
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
31-
Legion::Extensions::Helpers.const_defined?(:Lex)
30+
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
31+
Legion::Extensions::Helpers.const_defined?(:Lex, false)
3232
end
3333
end
3434
end

lib/legion/extensions/github/runners/contents.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ def commit_files(owner:, repo:, branch:, files:, message:, **)
3333

3434
{ success: true, commit_sha: new_commit.body['sha'], tree_sha: new_tree.body['sha'] }
3535
rescue StandardError => e
36-
log.warn(e.message) if respond_to?(:log, true)
36+
log.warn(e.message)
3737
{ success: false, error: e.message }
3838
end
3939

40-
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
41-
Legion::Extensions::Helpers.const_defined?(:Lex)
40+
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
41+
Legion::Extensions::Helpers.const_defined?(:Lex, false)
4242
end
4343
end
4444
end

lib/legion/extensions/github/runners/gists.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ def delete_gist(gist_id:, **)
3636
{ result: response.status == 204 }
3737
end
3838

39-
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
40-
Legion::Extensions::Helpers.const_defined?(:Lex)
39+
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
40+
Legion::Extensions::Helpers.const_defined?(:Lex, false)
4141
end
4242
end
4343
end

0 commit comments

Comments
 (0)