diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a83e3a5..8f7be28 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,8 +10,8 @@ jobs: ci: uses: LegionIO/.github/.github/workflows/ci.yml@main - lint: - uses: LegionIO/.github/.github/workflows/lint-patterns.yml@main + excluded-files: + uses: LegionIO/.github/.github/workflows/excluded-files.yml@main security: uses: LegionIO/.github/.github/workflows/security-scan.yml@main @@ -27,7 +27,7 @@ jobs: uses: LegionIO/.github/.github/workflows/stale.yml@main release: - needs: [ci, lint] + needs: [ci, excluded-files] if: github.event_name == 'push' && github.ref == 'refs/heads/main' uses: LegionIO/.github/.github/workflows/release.yml@main secrets: diff --git a/.rubocop.yml b/.rubocop.yml index 662daba..9dae8e3 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,53 +1,2 @@ -AllCops: - TargetRubyVersion: 3.4 - NewCops: enable - SuggestExtensions: false - -Layout/LineLength: - Max: 160 - -Layout/SpaceAroundEqualsInParameterDefault: - EnforcedStyle: space - -Layout/HashAlignment: - EnforcedHashRocketStyle: table - EnforcedColonStyle: table - -Metrics/MethodLength: - Max: 50 - -Metrics/ClassLength: - Max: 1500 - -Metrics/ModuleLength: - Max: 1500 - -Metrics/BlockLength: - Max: 40 - Exclude: - - 'spec/**/*' - -Metrics/ParameterLists: - Max: 8 - -Metrics/AbcSize: - Max: 60 - -Metrics/CyclomaticComplexity: - Max: 15 - -Metrics/PerceivedComplexity: - Max: 17 - -Style/Documentation: - Enabled: false - -Style/SymbolArray: - Enabled: true - -Style/FrozenStringLiteralComment: - Enabled: true - EnforcedStyle: always - -Naming/FileName: - Enabled: false +inherit_gem: + rubocop-legion: config/lex.yml diff --git a/CHANGELOG.md b/CHANGELOG.md index 7519e3c..bc8ca0d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## [0.2.5] - 2026-03-30 + +### Changed +- update to rubocop-legion 0.1.7, resolve all offenses + ## [0.2.4] - 2026-03-28 ### Added diff --git a/Gemfile b/Gemfile index ae05e53..7852da1 100644 --- a/Gemfile +++ b/Gemfile @@ -8,5 +8,6 @@ group :test do gem 'rspec' gem 'rspec_junit_formatter' gem 'rubocop' + gem 'rubocop-legion', '~> 0.1' gem 'simplecov' end diff --git a/lib/legion/extensions/github.rb b/lib/legion/extensions/github.rb index fb4dd20..b2abdea 100644 --- a/lib/legion/extensions/github.rb +++ b/lib/legion/extensions/github.rb @@ -19,7 +19,7 @@ module Legion module Extensions module Github - extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core + extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core, false end end end diff --git a/lib/legion/extensions/github/runners/branches.rb b/lib/legion/extensions/github/runners/branches.rb index 18e9bbd..7d788e1 100644 --- a/lib/legion/extensions/github/runners/branches.rb +++ b/lib/legion/extensions/github/runners/branches.rb @@ -18,12 +18,12 @@ def create_branch(owner:, repo:, branch:, from_ref: 'main', **) { success: true, ref: create_response.body['ref'], sha: sha } rescue StandardError => e - log.warn(e.message) if respond_to?(:log, true) + log.warn(e.message) { success: false, error: e.message } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/comments.rb b/lib/legion/extensions/github/runners/comments.rb index d9896a5..4e36c0e 100644 --- a/lib/legion/extensions/github/runners/comments.rb +++ b/lib/legion/extensions/github/runners/comments.rb @@ -35,8 +35,8 @@ def delete_comment(owner:, repo:, comment_id:, **) { result: response.status == 204 } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/commits.rb b/lib/legion/extensions/github/runners/commits.rb index 17c1fcb..e3c5a83 100644 --- a/lib/legion/extensions/github/runners/commits.rb +++ b/lib/legion/extensions/github/runners/commits.rb @@ -27,8 +27,8 @@ def compare_commits(owner:, repo:, base:, head:, per_page: 30, page: 1, **) { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/contents.rb b/lib/legion/extensions/github/runners/contents.rb index 46caaa2..e164fa3 100644 --- a/lib/legion/extensions/github/runners/contents.rb +++ b/lib/legion/extensions/github/runners/contents.rb @@ -33,12 +33,12 @@ def commit_files(owner:, repo:, branch:, files:, message:, **) { success: true, commit_sha: new_commit.body['sha'], tree_sha: new_tree.body['sha'] } rescue StandardError => e - log.warn(e.message) if respond_to?(:log, true) + log.warn(e.message) { success: false, error: e.message } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/gists.rb b/lib/legion/extensions/github/runners/gists.rb index 2ecd00d..2f0a2a1 100644 --- a/lib/legion/extensions/github/runners/gists.rb +++ b/lib/legion/extensions/github/runners/gists.rb @@ -36,8 +36,8 @@ def delete_gist(gist_id:, **) { result: response.status == 204 } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/issues.rb b/lib/legion/extensions/github/runners/issues.rb index b5e2697..412050d 100644 --- a/lib/legion/extensions/github/runners/issues.rb +++ b/lib/legion/extensions/github/runners/issues.rb @@ -43,8 +43,8 @@ def create_issue_comment(owner:, repo:, issue_number:, body:, **) { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/labels.rb b/lib/legion/extensions/github/runners/labels.rb index bd20025..12a05cb 100644 --- a/lib/legion/extensions/github/runners/labels.rb +++ b/lib/legion/extensions/github/runners/labels.rb @@ -47,8 +47,8 @@ def remove_label_from_issue(owner:, repo:, issue_number:, name:, **) { result: response.status == 204 } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/organizations.rb b/lib/legion/extensions/github/runners/organizations.rb index c01297e..612b552 100644 --- a/lib/legion/extensions/github/runners/organizations.rb +++ b/lib/legion/extensions/github/runners/organizations.rb @@ -30,8 +30,8 @@ def list_org_members(org:, per_page: 30, page: 1, **) { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/pull_requests.rb b/lib/legion/extensions/github/runners/pull_requests.rb index 1848610..db00cb6 100644 --- a/lib/legion/extensions/github/runners/pull_requests.rb +++ b/lib/legion/extensions/github/runners/pull_requests.rb @@ -62,8 +62,8 @@ def create_review(owner:, repo:, pull_number:, body:, comments: [], event: 'COMM { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/repositories.rb b/lib/legion/extensions/github/runners/repositories.rb index 55e4d53..c9cfcc0 100644 --- a/lib/legion/extensions/github/runners/repositories.rb +++ b/lib/legion/extensions/github/runners/repositories.rb @@ -46,8 +46,8 @@ def list_tags(owner:, repo:, per_page: 30, page: 1, **) { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/search.rb b/lib/legion/extensions/github/runners/search.rb index 5ed9cea..2f63dc2 100644 --- a/lib/legion/extensions/github/runners/search.rb +++ b/lib/legion/extensions/github/runners/search.rb @@ -33,8 +33,8 @@ def search_code(query:, sort: nil, order: 'desc', per_page: 30, page: 1, **) { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/runners/users.rb b/lib/legion/extensions/github/runners/users.rb index 1b1612b..7d02e65 100644 --- a/lib/legion/extensions/github/runners/users.rb +++ b/lib/legion/extensions/github/runners/users.rb @@ -29,8 +29,8 @@ def list_following(username:, per_page: 30, page: 1, **) { result: response.body } end - include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) && - Legion::Extensions::Helpers.const_defined?(:Lex) + include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) && + Legion::Extensions::Helpers.const_defined?(:Lex, false) end end end diff --git a/lib/legion/extensions/github/version.rb b/lib/legion/extensions/github/version.rb index 0ab7172..e3a7007 100644 --- a/lib/legion/extensions/github/version.rb +++ b/lib/legion/extensions/github/version.rb @@ -3,7 +3,7 @@ module Legion module Extensions module Github - VERSION = '0.2.4' + VERSION = '0.2.5' end end end