Skip to content

Design consistency sweep: migrate stragglers to WinampTheme primitives #110

@LeoHChen

Description

@LeoHChen

Some views still use raw colors, ad-hoc gradients, system fonts, or magic-number radii/spacing instead of + "WinampTheme" + primitives. Sweep + "HarmonIQ/Views/**" + and migrate.

Patterns to grep for

  • + "LinearGradient(" + declared inline (should be a + "WinampTheme" + gradient or + ".bevelPanel" + / + ".lcdPanel" + modifier).
  • + "Color(red: green: blue:)" + raw RGB literals (should be a named theme color).
  • + ".font(.system(" + where the readout is intended to look like an LCD (should use + "WinampTheme.lcdFont(size:)" + ).
  • Hard-coded + "cornerRadius:" + values that don't match the theme's bevel hierarchy.
  • Hard-coded spacing values that drift from the theme rhythm.

Process

  1. First pass: produce a checklist in this issue body of every offending site, with file path and line.
  2. Designer agent owns the migration PR(s).
  3. Final pass: same grep returns clean (or only intentional exceptions, documented inline).

Acceptance

  • Every box in the checklist is checked off by the merging PR(s).
  • No regressions in existing screens (visual diff via simulator screenshots before/after).
  • + "grep -rE" + for the patterns above returns either zero hits in + "HarmonIQ/Views/**" + or a small annotated allow-list.

Out of scope

  • Theme palette changes — those go in the Charcoal Phosphor polish issue (sibling E).
  • The SwiftUI player screen — covered by its own parity issue (sibling F).

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    designVisual design, theming, iconographyrefactorCode cleanup, dead code removal, internal restructuring

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions