chore(bootstrap): silence gocognit/gocyclo on InitServers wire-up#34
Closed
alexgarzao wants to merge 1 commit into
Closed
chore(bootstrap): silence gocognit/gocyclo on InitServers wire-up#34alexgarzao wants to merge 1 commit into
alexgarzao wants to merge 1 commit into
Conversation
InitServers is a linear bootstrap/wire-up routine. The high cognitive
and cyclomatic complexity scores (41 / 39, both > 25) come from the
sequential `if err != nil { return nil, err }` chain across config
load, logger, telemetry, TLS validation, MongoDB pool, executor
catalog, repositories, and HTTP/gRPC server startup.
Extracting helpers would add indirection without simplifying the
control flow: each step consumes outputs from the previous one, and
the readable shape *is* the linear sequence. A genuine refactor (e.g.
a builder/stages abstraction) is a separate, larger concern.
Silencing both linters at the function level with an inline
justification keeps `make lint` green so it can flag real regressions.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds documentation and linter suppression to the ChangesBootstrap Initialization Documentation
Comment |
Contributor
📊 Unit Test Coverage Report:
|
| Metric | Value |
|---|---|
| Overall Coverage | 45.2% |
| Threshold | 85% |
Coverage by Package
| Package | Coverage |
|---|---|
github.com/LerianStudio/flowker/api |
100.0% |
github.com/LerianStudio/flowker/internal/adapters/http/in/audit |
0.0% |
github.com/LerianStudio/flowker/internal/adapters/http/in/catalog |
60.9% |
github.com/LerianStudio/flowker/internal/adapters/http/in/dashboard |
91.5% |
github.com/LerianStudio/flowker/internal/adapters/http/in/execution |
81.0% |
github.com/LerianStudio/flowker/internal/adapters/http/in/executor_configuration |
70.8% |
github.com/LerianStudio/flowker/internal/adapters/http/in/health |
100.0% |
github.com/LerianStudio/flowker/internal/adapters/http/in/middleware/testutil |
0.0% |
github.com/LerianStudio/flowker/internal/adapters/http/in/middleware |
44.4% |
github.com/LerianStudio/flowker/internal/adapters/http/in/provider_configuration |
33.1% |
github.com/LerianStudio/flowker/internal/adapters/http/in/readyz |
81.3% |
github.com/LerianStudio/flowker/internal/adapters/http/in/webhook |
87.5% |
github.com/LerianStudio/flowker/internal/adapters/http/in/workflow |
69.7% |
github.com/LerianStudio/flowker/internal/adapters/http/in |
33.3% |
github.com/LerianStudio/flowker/internal/adapters/mongodb/dashboard |
43.0% |
github.com/LerianStudio/flowker/internal/adapters/mongodb/execution |
64.8% |
github.com/LerianStudio/flowker/internal/adapters/mongodb/executor_configuration |
36.6% |
github.com/LerianStudio/flowker/internal/adapters/mongodb/provider_configuration |
63.0% |
github.com/LerianStudio/flowker/internal/adapters/mongodb/workflow |
69.2% |
github.com/LerianStudio/flowker/internal/adapters/postgresql/audit |
42.2% |
github.com/LerianStudio/flowker/internal/bootstrap |
40.5% |
github.com/LerianStudio/flowker/internal/services/command |
37.2% |
github.com/LerianStudio/flowker/internal/services/query |
11.2% |
github.com/LerianStudio/flowker/internal/services |
3.2% |
github.com/LerianStudio/flowker/internal/testutil |
63.6% |
github.com/LerianStudio/flowker/pkg/circuitbreaker |
97.6% |
github.com/LerianStudio/flowker/pkg/clock |
0.0% |
github.com/LerianStudio/flowker/pkg/condition |
87.9% |
github.com/LerianStudio/flowker/pkg/contextutil |
0.0% |
github.com/LerianStudio/flowker/pkg/executor/base |
20.0% |
github.com/LerianStudio/flowker/pkg/executor |
39.5% |
github.com/LerianStudio/flowker/pkg/executors/http/auth |
58.2% |
github.com/LerianStudio/flowker/pkg/executors/http |
49.5% |
github.com/LerianStudio/flowker/pkg/executors/midaz |
83.2% |
github.com/LerianStudio/flowker/pkg/executors/s3 |
0.0% |
github.com/LerianStudio/flowker/pkg/executors/tracer |
72.2% |
github.com/LerianStudio/flowker/pkg/executors |
57.1% |
github.com/LerianStudio/flowker/pkg/model |
58.7% |
github.com/LerianStudio/flowker/pkg/net/http |
91.3% |
github.com/LerianStudio/flowker/pkg/pagination |
0.0% |
github.com/LerianStudio/flowker/pkg/safehttp |
90.3% |
github.com/LerianStudio/flowker/pkg/templates/tracer_midaz |
81.5% |
github.com/LerianStudio/flowker/pkg/templates |
0.0% |
github.com/LerianStudio/flowker/pkg/transformation |
67.2% |
github.com/LerianStudio/flowker/pkg/triggers/webhook |
0.0% |
github.com/LerianStudio/flowker/pkg/triggers |
0.0% |
github.com/LerianStudio/flowker/pkg/webhook |
100.0% |
github.com/LerianStudio/flowker/pkg |
90.3% |
Generated by Go PR Analysis workflow
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
🔒 Security Scan Results —
|
| Policy | Status |
|---|---|
| Default non-root user | ✅ Passed |
| No fixable critical/high CVEs | ✅ Passed |
| No high-profile vulnerabilities | ✅ Passed |
| No AGPL v3 licenses | ✅ Passed |
Pre-release Version Check
✅ No unstable version pins found.
alexgarzao
added a commit
that referenced
this pull request
May 21, 2026
InitServers is a linear bootstrap/wire-up routine. The complexity
scores (gocognit 41, gocyclo 39, both > 25) come from the sequential
`if err != nil { return nil, err }` chain across config load, logger,
telemetry, TLS validation, MongoDB pool, executor catalog,
repositories, and HTTP/gRPC server startup.
Extracting helpers would add indirection without simplifying the
control flow — each step consumes outputs from the previous one and
the readable shape *is* the linear sequence. A genuine refactor is a
separate, larger concern tracked outside this PR.
This is the same fix landing on develop via #34; when #34 merges
first, a subsequent rebase here will skip this commit because the
diff is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//nolint:gocognit,gocyclodirective toInitServersininternal/bootstrap/config.gosomake lintruns clean (was 1 issue, now 0).Why
InitServersis a linear bootstrap/wire-up routine. Its complexity scores (gocognit: 41,gocyclo: 39, both above the 25 threshold) come from the sequentialif err != nil { return nil, err }chain across:Extracting helpers would add indirection without simplifying control flow — each step consumes outputs from the previous one, and the readable shape is the linear sequence. A genuine refactor (a builder / staged-init abstraction) is a separate concern, larger than a lint suppression PR.
Alternative considered
Refactor
InitServersinto a staged initializer struct. Rejected for this PR: high blast radius (touches every dependency the function returns inside*Service), and the current shape is already easy to read top-to-bottom. The lint score is a signal to consider decomposition, not a mandate.Test plan
make lint— 0 issues (was 1:gocognitonInitServers)go test ./internal/bootstrap/...— 58 tests passgo test ./...— 240 tests pass across 52 packages (no regressions)go vet ./...— cleanNotes
gosec G704inpkg/executors/http/auth/token_fetcher.go) is already fixed indevelop(commits a465f62 / bb749e1) and will be inherited by feat(service): implement ConnectivityProber for Tracer with X-API-Key auth #25 on rebase/merge.