Refactor identity state fetching to simplify data assignment and improve error handling

Author: tacxou

src/components/identityForm/actions-on-deleted.vue

@@ -6,7 +6,7 @@
       q-btn.q-mx-xs(v-if="props.identity?._id" @click="sync" color="orange-8" :disabled="props.identity.state != IdentityState.TO_VALIDATE" icon="mdi-sync")
         q-tooltip.text-body2(slot="trigger" v-if="props.identity.state == IdentityState.TO_VALIDATE") Synchroniser l'identité
         q-tooltip.text-body2(slot="trigger" v-else) L'état de l'identité ne permet pas de la synchroniser
-      q-btn.q-mx-xs(v-if="props.identity?._id" @click="logs" color="grey-8" icon="mdi-file-document" :href="'/jobs?filters[:concernedTo.id]=' + props.identity?._id")
+      q-btn.q-mx-xs(v-if="props.identity?._id" color="grey-8" icon="mdi-file-document" :href="'/jobs?filters[:concernedTo.id]=' + props.identity?._id" target="_blank")
         q-tooltip.text-body2(slot="trigger") Voir les logs de l'identité
 </template>
 
@@ -20,10 +20,9 @@ import { useFetch } from 'nuxt/app'
 import { useIdentityStates } from '~/composables'
 import { useErrorHandling } from '#imports'
 
-
 type IdentityResponse = operations['IdentitiesController_search']['responses']['200']['content']['application/json']
 type Identity = components['schemas']['IdentitiesDto']
-const activation=ref(true)
+const activation = ref(true)
 const props = defineProps({
   identity: {
     type: Object as PropType<Identity>,
@@ -54,37 +53,35 @@ async function create() {
   // console.log('submit from actions')
   emits('create')
 }
-function setActivateColor(){
-  if (props.identity.lastBackendSync != ""){
-    return "green"
-  }else{
-    return "grey"
+function setActivateColor() {
+  if (props.identity.lastBackendSync != '') {
+    return 'green'
+  } else {
+    return 'grey'
   }
 }
-function showActivate(){
-  if (props.identity.lastBackendSync != ""){
+function showActivate() {
+  if (props.identity.lastBackendSync != '') {
     return true
-  }else{
+  } else {
     return false
   }
 }
-async function activate(){
-
-
-  let message=""
-  let bouton = ""
-  let initialStatus=0
-  if (props.identity.dataStatus === 0){
-    message="Voulez vous vraiment désactiver l'identité"
-    bouton="Désactiver"
-    initialStatus=1
-  }else{
-    message="Voulez vous vraiment activer l'identité"
-    bouton="Activer"
-    initialStatus=0
+async function activate() {
+  let message = ''
+  let bouton = ''
+  let initialStatus = 0
+  if (props.identity.dataStatus === 0) {
+    message = "Voulez vous vraiment désactiver l'identité"
+    bouton = 'Désactiver'
+    initialStatus = 1
+  } else {
+    message = "Voulez vous vraiment activer l'identité"
+    bouton = 'Activer'
+    initialStatus = 0
   }
   debugger
-  if (showActivate() === false){
+  if (showActivate() === false) {
     props.identity.dataStatus = initialStatus
     return
   }
@@ -103,34 +100,32 @@ async function activate(){
       color: 'negative',
       label: 'Annuler',
     },
-  }).onOk(async() => {
-    const requestOptions={method: 'POST',
-      body:JSON.stringify({id:props.identity._id,status:props.identity.dataStatus === 1 ?true:false})}
-    try{
-      const data=await $http.post('/management/identities/activation', requestOptions)
-      $q.notify({
-        message: 'Le statut a été mis à jour : ',
-        color: 'positive',
-        position: 'top-right',
-        icon: 'mdi-check-circle-outline',
-      })
-    }catch(error){
-      props.identity.dataStatus = initialStatus
-      $q.notify({
-        message: 'Impossible de modifier le statut : ' + error.response._data.message,
-        color: 'negative',
-        position: 'top-right',
-        icon: 'mdi-alert-circle-outline',
-      })
-    }
-
-  }).onCancel(() =>{
-    props.identity.dataStatus=initialStatus
   })
-
+    .onOk(async () => {
+      const requestOptions = { method: 'POST', body: JSON.stringify({ id: props.identity._id, status: props.identity.dataStatus === 1 ? true : false }) }
+      try {
+        const data = await $http.post('/management/identities/activation', requestOptions)
+        $q.notify({
+          message: 'Le statut a été mis à jour : ',
+          color: 'positive',
+          position: 'top-right',
+          icon: 'mdi-check-circle-outline',
+        })
+      } catch (error) {
+        props.identity.dataStatus = initialStatus
+        $q.notify({
+          message: 'Impossible de modifier le statut : ' + error.response._data.message,
+          color: 'negative',
+          position: 'top-right',
+          icon: 'mdi-alert-circle-outline',
+        })
+      }
+    })
+    .onCancel(() => {
+      props.identity.dataStatus = initialStatus
+    })
 }
 
-
 async function deleteIdentity() {
   $q.dialog({
     title: 'Confirmation',
@@ -165,17 +160,22 @@ async function sync() {
   emits('sync')
 }
 
-async function sendInit(){
+async function sendInit() {
   //envoi le mail
 
-  const { data: result, pending, error, refresh } = await useHttp(`/management/passwd/init`, {
+  const {
+    data: result,
+    pending,
+    error,
+    refresh,
+  } = await useHttp(`/management/passwd/init`, {
     method: 'POST',
-    body: { uid: props.identity.inetOrgPerson.uid  },
-  });
+    body: { uid: props.identity.inetOrgPerson.uid },
+  })
   if (error.value) {
     handleError({
       error: error.value,
-      message: 'Erreur lors de l\'envoi du mail'
+      message: "Erreur lors de l'envoi du mail",
     })
   } else {
     $q.notify({
@@ -187,10 +187,6 @@ async function sendInit(){
   }
 }
 
-function logs() {
-  router.push(`/jobs?filters[:concernedTo.id]=${(props.identity as any)._id}`)
-}
-
 function back() {
   router.push('/identities')
 }