Refactor lifecycle states configuration: enhance states.yml, update DTOs to include optional icons, and streamline lifecycle service state retrieval

Author: tacxou

defaults/lifecycle/states.yml

@@ -3,18 +3,22 @@ states:
   - key: A
     label: "En Attente"
     description: "supannRessourceEtat : {COMPTE} A SupannAnticipe"
+    icon: "mdi-account-clock"
 
-  # PROV -> supannResourceEtat : {COMTE} A SupannSursis et supannRessourceEtatDate: Date de passage en PROV
+  # PROV -> supannResourceEtat : {COMPTE} A SupannSursis et supannRessourceEtatDate: Date de passage en PROV
   - key: P
-    label: "PROV"
-    description: "supannResourceEtat : {COMTE} A SupannSursis et supannRessourceEtatDate: Date de passage en PROV"
+    label: "Provisoire"
+    description: "supannResourceEtat : {COMPTE} A SupannSursis et supannRessourceEtatDate: Date de passage en PROV"
+    icon: "mdi-account-alert"
 
   # A Détruire -> supannRessourceEtat : {COMPTE} I SupannSupprCompte
   - key: D
     label: "A Détruire"
     description: "supannRessourceEtat : {COMPTE} I SupannSupprCompte"
+    icon: "mdi-account-remove"
 
   # Verrouillé -> supannRessourceEtat : {COMPTE} S SupannVerrouille
   - key: V
     label: "Verrouillé"
     description: "supannRessourceEtat : {COMPTE} S SupannVerrouille"
+    icon: "mdi-account-lock"

src/management/identities/_enums/lifecycle.enum.ts

@@ -3,3 +3,24 @@ export enum IdentityLifecycleDefault {
   INACTIVE = "I",
   MANUAL = "M",
 }
+
+export const IdentityLifecycleDefaultList: Array<{ key: string; label: string; description: string, icon: string }> = [
+  {
+    key: IdentityLifecycleDefault.OFFICIAL,
+    label: 'Officiel',
+    description: 'supannRessourceEtat : {COMPTE} O SupannActif',
+    icon: 'mdi-account-check',
+  },
+  {
+    key: IdentityLifecycleDefault.INACTIVE,
+    label: 'Inactif',
+    description: 'supannRessourceEtat : {COMPTE} I SupannInactif',
+    icon: 'mdi-account-off',
+  },
+  {
+    key: IdentityLifecycleDefault.MANUAL,
+    label: 'Manuel',
+    description: 'supannRessourceEtat : {COMPTE} M SupannManuel',
+    icon: 'mdi-account-cog',
+  },
+];

src/management/lifecycle/_dto/config-states.dto.ts

@@ -1,5 +1,5 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsArray, IsNotEmpty, IsString, ValidateNested } from 'class-validator';
+import { IsArray, IsNotEmpty, IsOptional, IsString, ValidateNested } from 'class-validator';
 import { Type } from 'class-transformer';
 
 /**
@@ -37,6 +37,16 @@ export class LifecycleStateDTO {
     required: true,
   })
   public description: string;
+
+  @IsOptional()
+  @IsString()
+  @ApiProperty({
+    type: String,
+    description: 'Icône associée à l\'état (optionnel)',
+    example: 'mdi-account-clock',
+    required: false,
+  })
+  public icon?: string;
 }
 
 /**

src/management/lifecycle/lifecycle.service.ts

@@ -14,7 +14,7 @@ import { Identities } from '../identities/_schemas/identities.schema';
 import { IdentitiesCrudService } from '../identities/identities-crud.service';
 import { ConfigRulesObjectIdentitiesDTO, ConfigRulesObjectSchemaDTO } from './_dto/config-rules.dto';
 import { ConfigStatesDTO, LifecycleStateDTO } from './_dto/config-states.dto';
-import { IdentityLifecycleDefault } from '../identities/_enums/lifecycle.enum';
+import { IdentityLifecycleDefault, IdentityLifecycleDefaultList } from '../identities/_enums/lifecycle.enum';
 import { Lifecycle, LifecycleRefId } from './_schemas/lifecycle.schema';
 import { ConfigService } from '@nestjs/config';
 import dayjs from 'dayjs';
@@ -316,16 +316,14 @@ export class LifecycleService extends AbstractServiceSchema implements OnApplica
   public getAllAvailableStates(): Array<{ key: string; label: string; description: string }> {
     const allStates: Array<{ key: string; label: string; description: string }> = [];
 
-    // Ajouter les états par défaut de l'enum
-    Object.entries(IdentityLifecycleDefault).forEach(([enumKey, enumValue]) => {
+    IdentityLifecycleDefaultList.forEach(state => {
       allStates.push({
-        key: enumValue,
-        label: enumKey,
-        description: `Default lifecycle state: ${enumKey}`,
+        key: state.key,
+        label: state.label,
+        description: state.description,
       });
     });
 
-    // Ajouter les états custom
     this.customStates.forEach(customState => {
       allStates.push({
         key: customState.key,
@@ -334,7 +332,6 @@ export class LifecycleService extends AbstractServiceSchema implements OnApplica
       });
     });
 
-    this.logger.debug(`Retrieved <${allStates.length}> total available lifecycle states`);
     return allStates;
   }
 
@@ -361,8 +358,7 @@ export class LifecycleService extends AbstractServiceSchema implements OnApplica
    * @returns An array of custom lifecycle states with their details
    */
   public getCustomStates(): LifecycleStateDTO[] {
-    this.logger.debug(`Retrieved <${this.customStates.length}> custom lifecycle states`);
-    return [...this.customStates]; // Return a copy to prevent external modification
+    return [...this.customStates];
   }
 
   /**