From f7223e992e13f143f27c770305166681ad8f307b Mon Sep 17 00:00:00 2001
From: ananas <jorrit@lightprotocol.com>
Date: Sun, 2 Nov 2025 18:05:07 +0000
Subject: [PATCH] fix: release notes

---
 .github/workflows/release-rust.yml        | 22 +++++-
 scripts/release/generate-release-notes.sh | 89 +++++++++++++++++++++++
 2 files changed, 108 insertions(+), 3 deletions(-)
 create mode 100755 scripts/release/generate-release-notes.sh

diff --git a/.github/workflows/release-rust.yml b/.github/workflows/release-rust.yml
index 56862ac5ae..613ebcb513 100644
--- a/.github/workflows/release-rust.yml
+++ b/.github/workflows/release-rust.yml
@@ -80,10 +80,26 @@ jobs:
             TAG="${pkg}-v${VERSION}"
 
             echo "Creating GitHub release for $TAG.."
-            if gh release create "$TAG" --generate-notes --title "$TAG"; then
-              echo "✓ Created release for $TAG"
+
+            # Generate crate-specific release notes
+            if RELEASE_NOTES=$(./scripts/release/generate-release-notes.sh "$pkg" "$VERSION" 2>&1); then
+              echo "✓ Generated release notes for $pkg"
+
+              # Create release with custom notes
+              if echo "$RELEASE_NOTES" | gh release create "$TAG" --title "$TAG" --notes-file -; then
+                echo "✓ Created release for $TAG"
+              else
+                echo "Warning: Failed to create release for $TAG"
+              fi
             else
-              echo "Warning: Failed to create release for $TAG"
+              # If script fails (e.g., no previous tag), fall back to auto-generated notes
+              echo "Warning: Could not generate crate-specific notes: $RELEASE_NOTES"
+              echo "Falling back to auto-generated notes"
+              if gh release create "$TAG" --generate-notes --title "$TAG"; then
+                echo "✓ Created release for $TAG"
+              else
+                echo "Warning: Failed to create release for $TAG"
+              fi
             fi
           done
 
diff --git a/scripts/release/generate-release-notes.sh b/scripts/release/generate-release-notes.sh
new file mode 100755
index 0000000000..c91a17c49b
--- /dev/null
+++ b/scripts/release/generate-release-notes.sh
@@ -0,0 +1,89 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+# Generate crate-specific release notes for GitHub releases
+# Usage: ./scripts/release/generate-release-notes.sh <package-name> <version>
+# Arguments:
+#   package-name: Name of the package (e.g., "light-account-checks")
+#   version: Current version being released (e.g., "0.5.1")
+# Outputs: Release notes in markdown format to stdout
+
+PACKAGE_NAME="${1:-}"
+VERSION="${2:-}"
+
+if [ -z "$PACKAGE_NAME" ] || [ -z "$VERSION" ]; then
+  echo "Usage: $0 <package-name> <version>" >&2
+  exit 1
+fi
+
+TAG="${PACKAGE_NAME}-v${VERSION}"
+
+# Get package directory from cargo metadata
+MANIFEST_PATH=$(cargo metadata --format-version 1 --no-deps | jq -r ".packages[] | select(.name == \"$PACKAGE_NAME\") | .manifest_path")
+if [ -z "$MANIFEST_PATH" ] || [ "$MANIFEST_PATH" = "null" ]; then
+  echo "Error: Package '$PACKAGE_NAME' not found in workspace" >&2
+  exit 1
+fi
+
+PKG_DIR=$(dirname "$MANIFEST_PATH")
+PKG_DIR_RELATIVE="${PKG_DIR#$PWD/}"
+
+# Find the previous tag for this specific package
+PREVIOUS_TAG=$(git tag --list "${PACKAGE_NAME}-v*" \
+  | grep -v "^${TAG}$" \
+  | sort -V -r \
+  | head -1)
+
+if [ -z "$PREVIOUS_TAG" ]; then
+  echo "Error: No previous tag found for $PACKAGE_NAME" >&2
+  echo "This script requires at least one previous release tag." >&2
+  exit 1
+fi
+
+# Get commits that touched this package's directory
+COMMITS=$(git log --format="%H" "${PREVIOUS_TAG}..HEAD" -- "$PKG_DIR_RELATIVE")
+
+if [ -z "$COMMITS" ]; then
+  echo "No changes detected for this package."
+  exit 0
+fi
+
+# Build release notes with PRs that touched this package
+echo "## What's Changed"
+echo ""
+
+SEEN_PRS=()
+FOUND_PRS=false
+
+for commit in $COMMITS; do
+  # Get PR number from commit message (format: "title (#123)")
+  PR_NUM=$(git log --format=%s -n 1 "$commit" | grep -oE '\(#[0-9]+\)' | grep -oE '[0-9]+' | head -1)
+
+  if [ -n "$PR_NUM" ]; then
+    # Check if we've already seen this PR
+    if [[ ! " ${SEEN_PRS[@]:-} " =~ " ${PR_NUM} " ]]; then
+      SEEN_PRS+=("$PR_NUM")
+      FOUND_PRS=true
+
+      # Get PR details using gh CLI
+      if PR_TITLE=$(gh pr view "$PR_NUM" --json title --jq '.title' 2>/dev/null); then
+        PR_AUTHOR=$(gh pr view "$PR_NUM" --json author --jq '.author.login' 2>/dev/null || echo "unknown")
+        echo "* ${PR_TITLE} by @${PR_AUTHOR} in #${PR_NUM}"
+      else
+        # Fallback if gh CLI fails
+        COMMIT_TITLE=$(git log --format=%s -n 1 "$commit" | sed 's/ (#[0-9]*)//')
+        echo "* ${COMMIT_TITLE} in #${PR_NUM}"
+      fi
+    fi
+  fi
+done
+
+if [ "$FOUND_PRS" = false ]; then
+  echo "* Changes in commits between $PREVIOUS_TAG and $TAG"
+fi
+
+# Get repository URL and construct changelog link
+REPO_URL=$(git remote get-url origin | sed 's/git@github.com:/https:\/\/github.com\//' | sed 's/\.git$//')
+
+echo ""
+echo "**Full Changelog**: ${REPO_URL}/compare/${PREVIOUS_TAG}...${TAG}"