60 fps glitches out "FK in the coffee" scene

[Crowley9]

Here's a weird one. When playing at 60 fps in the middle of the "FK in the coffee" scene, the milk pitcher suddenly jumps into the place of the coffee cup, while the cup moves to hover above the table clipping into York's hand. The milk follows the animation as if it was the coffee cup, with York drinking from it. None of this happens at 30 fps. I've attached screenshots and the save game just before entering the dining hall.

FKcoffee.zip

[LittleBitUA]

Ha, that's a great one. Thanks for the save, that'll make it easy to reproduce.

It's the same root as the doubled combat sounds in #17: animations in this engine tick at 30 fps, and with the 60 FPS patch every animation frame is visited twice. Anything keyed to "when the animation reaches frame N, do X" fires twice. For a sound that's an echo; for "attach the prop in my hand" it's the next prop getting attached, so York ends up with the milk and the cup goes wherever the pitcher was supposed to be. Same bug, different symptom.

The fix is to dedupe those animation events in the game code so a frame can't trigger the same event twice. It's the top item on the 60 FPS list now. Until then, flipping 60 FPS off in the launcher for that scene keeps the coffee where it belongs.

[Crowley9]

A very similar thing happens in the scene where York examines Anna's room. The lid on the jar with cigarettes in it jumps from York's hand back onto the jar, and then a couple of seconds later it slides off into York's hand again. Attached a save from the nearest phone with Anna's key in inventory, ready to enter the room.

AnnaCigs.zip

[LittleBitUA]

Thanks for the second save, that's the same bug wearing a different hat: the jar lid is an "attach prop to hand / put it back" event, and when it fires twice in a row it toggles itself right back. The coffee scene, the lid, the doubled sounds in #17 - one dispatcher, one fix. Both saves will be my test cases for it, appreciated.