Summary
Quartermaster/Quartermaster.Tests/LevelUpApplicationServiceTests.cs is 1055 lines, past the 1000-line threshold that requires a tracking issue.
Detail
The file covers the whole of LevelUpApplicationService in one class: class-level application, skills, spells, hit points, ability increases, skill-point calculation, the consolidated multi-level helpers, saving throws, and CE-mode extras.
It crossed the threshold in #2676, which added four tests for ApplyOverflowAbilityIncreases.
Suggested split
Group by the concern under test, mirroring the service's own regions:
LevelUpApplicationServiceTests.Application.cs — ApplyClassLevel, ApplyFeats, ApplySkills, ApplySpells, ApplyHitPoints, ApplyAbilityIncreaseLevelUpApplicationServiceTests.Calculations.cs — CalculateHpIncrease, CalculateConRetroactiveHp, skill points, max ranksLevelUpApplicationServiceTests.Consolidated.cs — GetAbilityIncreaseLevels, CalculateConsolidatedHp, ApplyOverflowAbilityIncreasesLevelUpApplicationServiceTests.SavingThrows.cs — UpdateSavingThrows
Partial classes keep the shared fixture and CreatureBuilder usage intact, matching the convention already used across the Quartermaster source.
Acceptance
- No file over 1000 lines.
- Test count unchanged, all passing.
Summary
Quartermaster/Quartermaster.Tests/LevelUpApplicationServiceTests.csis 1055 lines, past the 1000-line threshold that requires a tracking issue.Detail
The file covers the whole of
LevelUpApplicationServicein one class: class-level application, skills, spells, hit points, ability increases, skill-point calculation, the consolidated multi-level helpers, saving throws, and CE-mode extras.It crossed the threshold in #2676, which added four tests for
ApplyOverflowAbilityIncreases.Suggested split
Group by the concern under test, mirroring the service's own regions:
LevelUpApplicationServiceTests.Application.cs— ApplyClassLevel, ApplyFeats, ApplySkills, ApplySpells, ApplyHitPoints, ApplyAbilityIncreaseLevelUpApplicationServiceTests.Calculations.cs— CalculateHpIncrease, CalculateConRetroactiveHp, skill points, max ranksLevelUpApplicationServiceTests.Consolidated.cs— GetAbilityIncreaseLevels, CalculateConsolidatedHp, ApplyOverflowAbilityIncreasesLevelUpApplicationServiceTests.SavingThrows.cs— UpdateSavingThrowsPartial classes keep the shared fixture and
CreatureBuilderusage intact, matching the convention already used across the Quartermaster source.Acceptance