Skip to content

Commit 1e643af

Browse files
committed
chore: repoint instruction-file references at .claude/CLAUDE.md
The review workflow read the now-removed root CLAUDE.md and cited its Code Review Priorities section; both reads were guarded with '|| true', so the review step would have run with empty standards rather than failing. lint_source.py pointed contributors at the removed .claude/rules/common-pitfalls.md; its docstring already carries the full explanation, so the pointer now names the compiler-bugs reproducer only. Written with assistance from Claude Code.
1 parent 23e75f0 commit 1e643af

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/claude-code-review.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ jobs:
206206
207207
Hard scope rules:
208208
- Do NOT inspect checked-out repository code except:
209-
- ./CLAUDE.md
209+
- ./.claude/CLAUDE.md
210210
- ./.claude/rules/*.md (max 10 files)
211211
- ${{ steps.review_input.outputs.review_diff_path }}
212212
- ${{ steps.review_input.outputs.changed_files_path }}
@@ -225,7 +225,7 @@ jobs:
225225
226226
Allowed workflow:
227227
1) ls -1 .claude/rules 2>/dev/null || true
228-
2) cat CLAUDE.md 2>/dev/null || true
228+
2) cat .claude/CLAUDE.md 2>/dev/null || true
229229
3) find .claude/rules -maxdepth 1 -name "*.md" -print | head -n 10 | xargs -I{} cat "{}" 2>/dev/null || true
230230
4) cat "${{ steps.review_input.outputs.changed_files_path }}"
231231
5) cat "${{ steps.review_input.outputs.review_diff_path }}"
@@ -238,7 +238,7 @@ jobs:
238238
- Do NOT restate the full PR summary.
239239
- If there are no high-confidence findings, leave .claude-review/output.md empty and STOP.
240240
241-
Review standard (in priority order per CLAUDE.md "Code Review Priorities"):
241+
Review standard (in priority order):
242242
1. Correctness (logic bugs, numerical issues, array bounds)
243243
2. Precision discipline (stp vs wp mixing)
244244
3. Memory management (@:ALLOCATE/@:DEALLOCATE pairing, GPU pointer setup)

toolchain/mfc/lint_source.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ def check_device_routine_element_args(repo_root: Path) -> list[str]:
630630
the element as garbage and never writes it back. Either alone is fine, every `routine` level
631631
is affected, and the loop counts when it sits in anything the routine calls. Copy the element
632632
to a scalar before the call and receive results into a scalar. See
633-
.claude/rules/common-pitfalls.md and sbryngelson/compiler-bugs cce/acc-routine-element-by-reference.
633+
sbryngelson/compiler-bugs cce/acc-routine-element-by-reference.
634634
"""
635635
src_dir = repo_root / SRC_DIR
636636
files = {src: src.read_text(encoding="utf-8").splitlines() for src in _fortran_fpp_files(src_dir)}
@@ -683,7 +683,7 @@ def check_device_routine_element_args(repo_root: Path) -> list[str]:
683683
for arg in _split_top_level(stmt[m.end() : j - 1]):
684684
e = _ELEMENT_ARG.match(arg)
685685
if e and ":" not in arg and not _VALUE_CALL_NAMES.match(e.group(1)):
686-
errors.append(f" {rel}:{line_no} `{arg}` into `{name}` (a device routine with a seq loop): pass a scalar, see common-pitfalls.md")
686+
errors.append(f" {rel}:{line_no} `{arg}` into `{name}` (a device routine with a seq loop): pass a scalar, see sbryngelson/compiler-bugs cce/acc-routine-element-by-reference")
687687
return errors
688688

689689

0 commit comments

Comments
 (0)