Merge branch 'master' into feat/ramped-inflow

Author: sbryngelson

.claude/CLAUDE.md

@@ -0,0 +1,15 @@
+* New branches cannot be made on MFlowCode/MFC, they are made on forks
+* PRs:
+    * made using AI tools like Claude Code and Codex should say so.
+    * are made from those MFC forks
+    * that change CFD results need verification that the PR is correct
+    * follow template
+    * that break a feature but promise a followup PR to fix it are rejected
+* Commands:
+    * MFC should almost always build and run using the ./mfc.sh command
+    * Running mfc.sh commands can create a lock file in build/ that is sticky, be careful
+* Programming and Design:
+    * New code should follow the DRY principle and also make side-effect code DRY as well
+    * Comments should be as short as possible without sacrificing value
+    * GPU macros should follow the source's existing GPU macro principles and patterns
+    * Functions/subroutines/modules shorter is better while being correct, fast, and separating concerns

.claude/rules/common-pitfalls.md

@@ -57,8 +57,10 @@ fi
 # microarchitecture dies with SIGILL, which would be reported as a bad node and
 # get a perfectly healthy one excluded.
 newest_syscheck() {
-    find "$@" -name syscheck -type f -printf '%T@ %p\n' 2>/dev/null \
-        | sort -rn | head -1 | cut -d' ' -f2-
+    # ls -t rather than find -printf: -printf is GNU-only, and on a BSD find it
+    # fails into 2>/dev/null, so discovery silently returns nothing and every
+    # probe is skipped as "no syscheck binary".
+    find "$@" -name syscheck -type f -exec ls -t {} + 2>/dev/null | head -1
 }
 
 syscheck_bin=$(newest_syscheck build/install -path "*${device}*")
@@ -132,7 +134,9 @@ run_probe() {
     fi
 }
 
-run_probe "${launcher[@]}"
+# ${arr[@]+"${arr[@]}"} rather than "${arr[@]}": under set -u, bash 3.2 (which is
+# what macOS ships) treats an empty array expansion as an unbound variable.
+run_probe ${launcher[@]+"${launcher[@]}"}
 
 # If this launcher does not take the flags we added, drop them and probe again
 # rather than reporting a verdict about the node. Otherwise a launcher that

.github/scripts/preflight.sh

@@ -206,7 +206,7 @@ jobs:
 
             Hard scope rules:
             - Do NOT inspect checked-out repository code except:
-              - ./CLAUDE.md
+              - ./.claude/CLAUDE.md
               - ./.claude/rules/*.md (max 10 files)
               - ${{ steps.review_input.outputs.review_diff_path }}
               - ${{ steps.review_input.outputs.changed_files_path }}
@@ -225,7 +225,7 @@ jobs:
 
             Allowed workflow:
             1) ls -1 .claude/rules 2>/dev/null || true
-            2) cat CLAUDE.md 2>/dev/null || true
+            2) cat .claude/CLAUDE.md 2>/dev/null || true
             3) find .claude/rules -maxdepth 1 -name "*.md" -print | head -n 10 | xargs -I{} cat "{}" 2>/dev/null || true
             4) cat "${{ steps.review_input.outputs.changed_files_path }}"
             5) cat "${{ steps.review_input.outputs.review_diff_path }}"
@@ -238,7 +238,7 @@ jobs:
             - Do NOT restate the full PR summary.
             - If there are no high-confidence findings, leave .claude-review/output.md empty and STOP.
 
-            Review standard (in priority order per CLAUDE.md "Code Review Priorities"):
+            Review standard (in priority order):
             1. Correctness (logic bugs, numerical issues, array bounds)
             2. Precision discipline (stp vs wp mixing)
             3. Memory management (@:ALLOCATE/@:DEALLOCATE pairing, GPU pointer setup)

.github/workflows/claude-code-review.yml

@@ -1,10 +1,12 @@
 name: Update Homebrew Formula on Release
 
-# Triggers when a new version tag is pushed
+# Triggers when a release is published. Not `push: tags`, which GitHub skips
+# when the tagged commit message carries [skip ci] -- that silently dropped the
+# v5.6.0 and v5.7.0 formula updates, while docker.yml fired for both because a
+# release event is not a push event.
 on:
-  push:
-    tags:
-      - 'v*'
+  release:
+    types: [published]
   pull_request:
     branches: [master]
     paths:
@@ -28,6 +30,9 @@ permissions:
 jobs:
   update-homebrew-tap:
     name: Update homebrew-mfc tap
+    # A prerelease tag (v5.8.0-rc1) would fail the X.Y.Z check below, so skip it
+    # rather than reporting a red release job.
+    if: ${{ github.event_name != 'release' || !github.event.release.prerelease }}
     runs-on: ubuntu-latest
     environment:
       name: homebrew
@@ -44,8 +49,9 @@ jobs:
             VERSION="5.2.0"
             echo "::notice::PR test mode - using version $VERSION"
           else
-            # Extract version from tag (remove 'v' prefix)
-            VERSION="${GITHUB_REF#refs/tags/v}"
+            # Extract version from the released tag (remove 'v' prefix)
+            VERSION="${{ github.event.release.tag_name }}"
+            VERSION="${VERSION#v}"
           fi
 
           if [[ ! "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
@@ -97,7 +103,7 @@ jobs:
           echo "- Update formula" >> $GITHUB_STEP_SUMMARY
           echo "- Push to tap" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "The full workflow will run when a \`v*\` tag is pushed after merge." >> $GITHUB_STEP_SUMMARY
+          echo "The full workflow will run when a release is published after merge." >> $GITHUB_STEP_SUMMARY
 
       - name: Checkout homebrew-mfc tap
         if: ${{ github.event_name != 'pull_request' }}

.github/workflows/homebrew-release.yml

@@ -33,4 +33,5 @@ exclude = [
     "https://code\\.visualstudio\\.com/?$",           # Root page returns 403 to automated requests
     "https://stackoverflow\\.com",                    # Returns 403 to automated requests
     "https://marketplace\\.visualstudio\\.com",        # Returns 503 to automated requests
+    "https://web\\.eng\\.ucsd\\.edu",                    # San Diego mechanism page has an untrusted SSL cert
 ]

.lychee.toml

@@ -0,0 +1 @@
+.claude/CLAUDE.md