Deleting 60 sounds in moderation queue takes forever and can lead to 504 Gateway Time-out

[qubodup]

Deleting 60 sounds in moderation queue takes forever and can lead to 504 Gateway Time-out

To reproduce

On https://freesound.org/tickets/moderation/assigned/[ID]/ delete 60 sounds in one batch.

A test account like https://freesound.org/people/freesoundtest111/ can be used for uploading a batch of sounds for testing..

This bash/sox one-liner can generate 60 test files: for i in {1..60}; do sox -n -r 48000 test_$i.ogg trim 0 $((RANDOM%61+60))s; done—although the tiny size is not comparable to real world scenarios, potentially it might lead to faster processing and avoidance of the error in Actual result.

Expected result

• You return to above URL with the same speed as if you were to approve 60 sounds in one batch (usually somewhere around 2-15 seconds)

Actual result

• The page loads for 60 seconds.
• Then you either return to above URL or
• you get a "504 Gateway Time-out" "nginx" message. I speculate that the chance of this happening might be related to the number of sounds in the batch and possibly internet speed. Simulating a slow connection or a proxy might be necessary to reproduce.
• At the same time, if you open the above URL in another tab while this one is still loading, it will not contain the currently 'deleting' sounds, which makes it seem that the waiting is unnecessary.

Notes

I don't know whether this is related to #1049

At some point in recent years mod queue Approving/Deferring page refresh speed was improved significantly (as far as I know by moving the affected sounds out of the queue to be processed in the background). Perhaps the same method could be applied here.

[alastair]

thanks for the report. It's interesting because I suspect that pending sounds shouldn't have a lot of related information and so deleting them should be quite fast.
However we'll profile the process to see what's going on. As you say it's probably easiest to process these items in the background instead of trying to do them directly from the page - although we'll need a way to indicate in the admin that these sounds are about to go away so that you don't still see them in the list after you select delete.