fix(combat-trainer): regression when all weapon skills mindlocked (elanthia-online#7345)

## Summary

Fixes regression from elanthia-online#7341 where `all_weapons_locked` disabled attacks
when all weapon skills reached 34/34 mid-hunt, breaking FA and skinning
training. Also fixes a pre-existing bug where
`combat_trainer_ignore_weapon_mindstate: true` caused rapid weapon
cycling instead of action-count-based rotation.

### Root cause

PR elanthia-online#7341 added an `all_weapons_locked` flag that disabled attacks in
`AttackProcess` when every weapon skill hit 34/34. This was intended to
prevent bare-fisted jab spam at script startup, but it also disabled
attacks **mid-hunt** when a weapon was already equipped -- breaking FA,
skinning, and any other non-weapon training that requires killing.

Users who tried `combat_trainer_ignore_weapon_mindstate: true` as a
workaround hit a second bug: `skill_done?` returns `true` immediately at
exp==34 (line 5131), triggering `determine_next_to_train` to switch
weapons every cycle -- resulting in an infinite load/aim/unload/swap
loop without ever firing.

### What changed

#### 1. Removed `all_weapons_locked` entirely
- Removed the flag from `attr_accessor`, `initialize`, and the
`AttackProcess` condition
- A weapon is now always selected (see 5a/5b below), so attacks are
never disabled by this flag

#### 2. All weapons at 34 with weapon equipped (scenario 5a)
- The all-locked guard in `determine_next_to_train` returns early
**without switching weapons**
- Attacks continue with the current weapon so the player can train FA,
skinning, etc.
- One-time user message:
  ```
  *** combat-trainer: All weapon skills are at 34/34 mindstate.
*** combat-trainer: Continuing to attack with Bow for FA/skinning
training.
*** combat-trainer: Set combat_trainer_ignore_weapon_mindstate: true to
cycle weapons by action count instead.
  ```

#### 3. All weapons at 34 with no weapon equipped at startup (scenario
5b)
- Previously returned early from the all-locked guard, leaving
`weapon_skill` nil -- causing bare-fisted jab spam (the original
pre-elanthia-online#7341 bug)
- Now falls through to weapon selection, picks the first available
weapon, then behaves as 5a
- One-time user message:
  ```
  *** combat-trainer: All weapon skills are at 34/34 mindstate.
  *** combat-trainer: Selecting initial weapon to begin attacking.
*** combat-trainer: Set combat_trainer_ignore_weapon_mindstate: true to
cycle weapons by action count instead.
  ```

#### 4. `ignore_weapon_mindstate: true` now works correctly
- Passed `ignore_weapon_mindstate` into `GameState` so `skill_done?` can
check it directly (SRP -- the decision about whether training is
complete belongs in the method making that decision)
- When the flag is true, `skill_done?` skips **all** mindstate-driven
logic:
  - No gain_check blacklisting
  - No early return at exp==34
  - No focus_threshold adjustments
  - No `target_increment` comparison
- Only evaluates: `action_count >= target_action_count`
- Weapons cycle indefinitely by action count regardless of mindstate
- One-time user message when all weapons reach 34:
  ```
*** combat-trainer: All weapon skills at 34/34 mindstate --
ignore_weapon_mindstate is active.
*** combat-trainer: Cycling weapons by combat_trainer_action_count only.
  ```

#### 5. Blank/nil `weapon_training` guard
- New guard at the top of `determine_next_to_train`: `unless
weapon_training&.any?`
- If no weapons are configured, attacks are disabled and the character
dances (bob/weave/circle) for defensive skills only
- Added `weapon_skill.nil?` check to `AttackProcess` so a missing weapon
falls into the dance path instead of attempting bare-fisted attacks
- One-time user message:
  ```
  *** combat-trainer: No weapons configured in weapon_training.
*** combat-trainer: Attacks are disabled. Only defensive dance actions
(bob/weave/circle) will be used.
*** combat-trainer: Add entries to weapon_training in your YAML if you
want to train weapon skills.
  ```

#### 6. Spec file consolidation
- Renamed `combat_trainer_bundle_spec.rb` to `combat_trainer_spec.rb`
(one spec file per script convention)
- Added `GameState` and `SetupProcess` specs covering:
- `skill_done?` with `ignore_weapon_mindstate` true/false at exp values
0, 17, and 34
- `determine_next_to_train` for 5a, 5b, mixed exp, fresh start,
ignore_mindstate, skill_done? false
  - Blank and nil `weapon_training` guard
- One-time messaging for all scenarios (5a, 5b, ignore_mindstate, blank
weapon_training)
  - Adversarial: messaging does NOT fire when not all weapons are at 34

## Test plan
- [x] 53 specs pass (`rspec spec/combat_trainer_spec.rb`)
- [x] `rubocop -A` clean on both files
- [ ] In-game: all weapons capped, no `ignore_weapon_mindstate` --
verify attacks continue with current weapon (5a), verify message appears
once
- [ ] In-game: script start with all weapons already capped -- verify a
weapon is selected and attacks proceed (5b), verify message appears once
- [ ] In-game: `ignore_weapon_mindstate: true` with all weapons capped
-- verify cycling by action count with no rapid swap loop, verify
message appears once
- [ ] In-game: `ignore_weapon_mindstate: true` with one weapon
configured -- verify attacks continue indefinitely
- [ ] In-game: blank `weapon_training` -- verify dance-only behavior
with message
- [ ] In-game: normal multi-weapon cycling unaffected when skills are
not all at 34

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: MahtraDR

combat-trainer.lic

@@ -163,23 +163,55 @@ class SetupProcess
   end
 
   def determine_next_to_train(game_state, weapon_training, ending_ranged)
+    # No weapons configured: nothing to equip or train. The character will
+    # dance (bob/weave/circle) for defensive skills only.
+    unless weapon_training&.any?
+      unless @no_weapons_warned
+        @no_weapons_warned = true
+        DRC.message('*** combat-trainer: No weapons configured in weapon_training.')
+        DRC.message('*** combat-trainer: Attacks are disabled. Only defensive dance actions (bob/weave/circle) will be used.')
+        DRC.message('*** combat-trainer: Add entries to weapon_training in your YAML if you want to train weapon skills.')
+      end
+      return
+    end
+
     return unless game_state.skill_done? || !weapon_training[game_state.weapon_skill] || ending_ranged
 
     # skip_all_weapon_max_check is a kludge for a transient condition from blacklisting a skill with
     # all remaining skills at 34
     unless @ignore_weapon_mindstate || game_state.skip_all_weapon_max_check
-      # check if all weapons are maxed exp to prevent rapid cycling
+      # All weapons at 34: stay on current weapon to prevent rapid cycling.
+      # If no weapon is equipped yet (script startup with all capped), fall
+      # through to weapon selection so one gets picked (5b becomes 5a).
       if weapon_training.reject { |skill, _| DRSkill.getxp(skill) == 34 }.empty?
-        echo 'all weapons locked, not switching' if $debug_mode_ct
-        unless game_state.all_weapons_locked
-          game_state.all_weapons_locked = true
-          echo '*** All weapon skills are at 34/34 mindstate -- no weapon will be equipped.'
-          echo '*** Attacks are disabled. Set combat_trainer_ignore_weapon_mindstate: true if any skills are permanently capped.'
+        if game_state.weapon_skill
+          unless @all_locked_warned
+            @all_locked_warned = true
+            DRC.message('*** combat-trainer: All weapon skills are at 34/34 mindstate.')
+            DRC.message("*** combat-trainer: Continuing to attack with #{game_state.weapon_skill} for FA/skinning training.")
+            DRC.message('*** combat-trainer: Set combat_trainer_ignore_weapon_mindstate: true to cycle weapons by action count instead.')
+          end
+          return
+        else
+          unless @all_locked_selecting_warned
+            @all_locked_selecting_warned = true
+            DRC.message('*** combat-trainer: All weapon skills are at 34/34 mindstate.')
+            DRC.message('*** combat-trainer: Selecting initial weapon to begin attacking.')
+            DRC.message('*** combat-trainer: Set combat_trainer_ignore_weapon_mindstate: true to cycle weapons by action count instead.')
+          end
         end
-        return
       end
     end
-    game_state.all_weapons_locked = false
+
+    # With ignore_weapon_mindstate, skill_done? only triggers on action count.
+    # Notify the user once when all weapons reach 34 that cycling continues by action count.
+    if @ignore_weapon_mindstate && !@ignore_mindstate_warned
+      if weapon_training.reject { |skill, _| DRSkill.getxp(skill) == 34 }.empty?
+        @ignore_mindstate_warned = true
+        DRC.message('*** combat-trainer: All weapon skills at 34/34 mindstate -- ignore_weapon_mindstate is active.')
+        DRC.message('*** combat-trainer: Cycling weapons by combat_trainer_action_count only.')
+      end
+    end
     game_state.skip_all_weapon_max_check = false
 
     echo('new skill needed for training') if $debug_mode_ct
@@ -3703,7 +3735,7 @@ class AttackProcess
       game_state.no_stab_current_mob = false
     end
 
-    if game_state.dancing? || game_state.all_weapons_locked || game_state.weapon_skill == 'Targeted Magic' || !game_state.is_offense_allowed?
+    if game_state.dancing? || game_state.weapon_skill.nil? || game_state.weapon_skill == 'Targeted Magic' || !game_state.is_offense_allowed?
       if game_state.finish_killing?
         echo('AttackProcess::clean_up') if $debug_mode_ct
         game_state.next_clean_up_step
@@ -4364,7 +4396,7 @@ class GameState
                 :clean_up_step, :constructs, :cooldown_timers, :current_weapon_skill,
                 :currently_whirlwinding, :dance_queue, :dancing, :danger, :focus_threshold_active, :hide_on_cast, :last_action_count, :last_exp, :last_offhand_skill,
                 :last_regalia_type, :last_weapon_skill, :loaded, :mob_died, :need_bundle,
-                :all_weapons_locked, :no_loot, :no_skins, :no_stab_current_mob, :no_stab_mobs, :offhand_last_exp, :parrying, :prepare_cfb, :prepare_cfw, :prepare_nr,
+                :no_loot, :no_skins, :no_stab_current_mob, :no_stab_mobs, :offhand_last_exp, :parrying, :prepare_cfb, :prepare_cfw, :prepare_nr,
                 :prepare_consume, :regalia_cancel, :reset_stance, :retreating, :skip_all_weapon_max_check, :starlight_values,
                 :swap_regalia_type, :target_weapon_skill, :use_charged_maneuvers,
                 :whirlwind_trainables, :wounds
@@ -4422,7 +4454,6 @@ class GameState
     @constructs = []
     @no_stab_mobs = []
     @no_loot = []
-    @all_weapons_locked = false
     @dancing = false
     @retreating = false
     @action_count = 0
@@ -4475,6 +4506,9 @@ class GameState
     echo("  @target_increment: #{@target_increment}") if $debug_mode_ct
     @target_increment_original = @target_increment
 
+    @ignore_weapon_mindstate = settings.combat_trainer_ignore_weapon_mindstate
+    echo("  @ignore_weapon_mindstate: #{@ignore_weapon_mindstate}") if $debug_mode_ct
+
     @gain_check = settings.combat_trainer_gain_check
     echo("  @gain_check: #{@gain_check}") if $debug_mode_ct
 
@@ -5108,6 +5142,13 @@ class GameState
     echo("last_exp: #{@last_exp}") if $debug_mode_ct
     echo("last_action_count: #{@last_action_count}") if $debug_mode_ct
 
+    # When ignoring weapon mindstate, cycle weapons purely by action count.
+    # Skip all mindstate-driven logic: gain_check, exp==34, focus_threshold,
+    # and target_increment comparison.
+    if @ignore_weapon_mindstate
+      return @action_count >= @target_action_count
+    end
+
     # gain_check code: logic to account for a skill that is not gaining any MS at all
     if (@gain_check > 0) && !weapon_skill.nil?
       # only check for mindstate movement if there was actually some action in the last CT cycle