From fd0b208a35882f52464ede4fcc7c378933b1dd65 Mon Sep 17 00:00:00 2001 From: MadMax Date: Tue, 21 Jul 2026 23:30:31 +0100 Subject: [PATCH 1/2] mop: route auction menu through session sender --- methods/Mangos/PlayerMethods.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/methods/Mangos/PlayerMethods.h b/methods/Mangos/PlayerMethods.h index b842cb7..c98a881 100644 --- a/methods/Mangos/PlayerMethods.h +++ b/methods/Mangos/PlayerMethods.h @@ -2072,6 +2072,9 @@ namespace LuaPlayer { Unit* unit = E->CHECKOBJ(2); +#if defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS + player->GetSession()->SendAuctionHello(unit); +#else AuctionHouseEntry const* ahEntry = AuctionHouseMgr::GetAuctionHouseEntry(unit); if (!ahEntry) return 0; @@ -2080,14 +2083,13 @@ namespace LuaPlayer data << unit->GET_GUID(); #if defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_TBC data << uint32(ahEntry->ID); -#elif defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS - data << uint32(ahEntry->ID); #else data << uint32(ahEntry->houseId); #endif data << uint8(1); player->GetSession()->SendPacket(&data); +#endif return 0; } From 9a88d15a03d4c6e20bc42c73cc3c19bc9e869914 Mon Sep 17 00:00:00 2001 From: MadMax Date: Wed, 22 Jul 2026 16:46:39 +0100 Subject: [PATCH 2/2] fix(mangos-mists): Group:SetTargetIcon 4-arg call for MoP raid markers mangos-four restored 5.4.8 raid markers, giving Group::SetTargetIcon a fourth `uint8 context` parameter (id, whoGuid, targetGuid, context). The Lua binding still called the pre-MoP 3-arg overload, breaking the mangos-four build (error C2660: SetTargetIcon does not take 3 arguments). Add a mangos-MISTS arm passing context 0 (a normal target-icon set, matching GroupHandler's default path). Classic/TBC (2-arg) and WotLK/Cata (3-arg) arms are unchanged, so the shared Eluna keeps building for every core. Co-Authored-By: Claude Opus 4.8 (1M context) --- methods/Mangos/GroupMethods.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/methods/Mangos/GroupMethods.h b/methods/Mangos/GroupMethods.h index 9b9037f..7bd4ce7 100644 --- a/methods/Mangos/GroupMethods.h +++ b/methods/Mangos/GroupMethods.h @@ -365,6 +365,10 @@ namespace LuaGroup #if (defined(CLASSIC) || defined(TBC)) group->SetTargetIcon(icon, target); +#elif defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS + // MoP (mangos-four) restored raid markers with a fourth "context" argument on + // Group::SetTargetIcon; 0 selects a normal target-icon set (see GroupHandler). + group->SetTargetIcon(icon, setter, target, 0); #else group->SetTargetIcon(icon, setter, target); #endif