Skip to content

Commit def531c

Browse files
committed
adding node versions consistency
1 parent 7784959 commit def531c

4 files changed

Lines changed: 25 additions & 5 deletions

File tree

.github/workflows/release-electron.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Node.js
2020
uses: actions/setup-node@v4
2121
with:
22-
node-version: '20'
22+
node-version: '18'
2323

2424
- name: Setup Python
2525
uses: actions/setup-python@v5
@@ -143,7 +143,7 @@ jobs:
143143
- name: Setup Node.js
144144
uses: actions/setup-node@v4
145145
with:
146-
node-version: '20'
146+
node-version: '18'
147147

148148
- name: Setup Python
149149
uses: actions/setup-python@v5
@@ -230,7 +230,7 @@ jobs:
230230
- name: Setup Node.js
231231
uses: actions/setup-node@v4
232232
with:
233-
node-version: '20'
233+
node-version: '18'
234234

235235
- name: Setup Python
236236
uses: actions/setup-python@v5
@@ -316,7 +316,7 @@ jobs:
316316
- name: Setup Node.js
317317
uses: actions/setup-node@v4
318318
with:
319-
node-version: '20'
319+
node-version: '18'
320320

321321
- name: Setup Python
322322
uses: actions/setup-python@v5
@@ -414,7 +414,7 @@ jobs:
414414
- name: Setup Node.js
415415
uses: actions/setup-node@v4
416416
with:
417-
node-version: '20'
417+
node-version: '18'
418418

419419
- name: Install Node dependencies
420420
run: npm install

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
18

CLAUDE.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,24 @@ Driver should accept `transport: SerialTransport` in constructor and use it for
428428
- `API_PORT`: FastAPI port (default: `57666`)
429429
- `UI_PORT`: Frontend dev server port (default: `52893`)
430430

431+
## Node.js Version Requirements
432+
433+
**IMPORTANT**: BenchMesh requires **Node.js v18** for Electron packaging to ensure compatibility with electron-builder and Electron v28.
434+
435+
### For Local Development
436+
437+
The repository includes `.nvmrc` files that specify Node.js v18. If you use `nvm`, run:
438+
439+
```bash
440+
nvm use
441+
```
442+
443+
This will automatically switch to the correct Node.js version.
444+
445+
### For CI/CD
446+
447+
The GitHub Actions workflow (`.github/workflows/release-electron.yml`) is configured to use Node.js v18 for all Electron builds across Linux, Windows, and macOS platforms.
448+
431449
## Notes
432450

433451
- Repository root contains example RS232 test scripts in `system/` directory

electron/.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
18

0 commit comments

Comments
 (0)