Skip to content

Change case on return value & format code for readability #2

Description

@cliffhall

function royaltyInfo(uint256 _tokenId, uint256 _salePrice) external view override(IERC2981) returns (address Receiver, uint256 royaltyAmount) {

Readability is important in reference and framework code. Formatting it with that in mind (as we did in the ERC), will be appreciated by those who evaluate it when considering adoption.

function royaltyInfo(uint256 _tokenId, uint256 _salePrice) 
external 
view 
override(IERC2981) 
returns (address Receiver, uint256 royaltyAmount) { }

Also, return values should begin with lower case receiver not Receiver.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions