forked from OpenLeagueManager/OLManager
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathpr_body.txt
More file actions
28 lines (23 loc) · 887 Bytes
/
Copy pathpr_body.txt
File metadata and controls
28 lines (23 loc) · 887 Bytes
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
## Closes
Closes #58
## Type
- [x] Code refactoring
## Summary
- Add 14 new match arms for LoL competitive regions (KR, CN, TW, JP, BR, US, CA, DE, FR, ES, VN, TR)
- Preserve backward compatibility with UK football nations (ENG, SCO, WAL, NIR)
- Add ~30 unit tests for all nationality mappings
- SDD artifacts in \docs/propose/58-update-identity-lol/\
## Changes
| File | Change |
|------|--------|
| \src-tauri/crates/domain/src/identity.rs\ | Modified: 14 new match arms + 4 new test functions |
## Test Plan
- [x] \cargo test -p domain\ passes (22/22 tests)
- [x] \cargo check -p domain\ passes without warnings
- [x] All LoL nationality codes map correctly
- [x] UK football nation codes still work (backward compatibility)
## Checklist
- [x] Linked an approved issue (Issue #58)
- [x] Conventional commit format used
- [x] Tests added/updated
- [x] No \Co-Authored-By\ trailer