From f0126d948455a2184d2ac2eb0b6b49e0bfe73265 Mon Sep 17 00:00:00 2001 From: Niphyr Date: Sat, 25 Oct 2025 19:36:23 +1100 Subject: [PATCH] Change public interfaces and classes to internal Updated multiple service interfaces and classes from public to internal for improved encapsulation. Version bump to 3.1.2 --- SimcProfileParser/Interfaces/DataSync/ICacheService.cs | 2 +- SimcProfileParser/Interfaces/ISimcItemCreationService.cs | 2 +- SimcProfileParser/Interfaces/ISimcParserService.cs | 2 +- SimcProfileParser/Interfaces/ISimcSpellCreationService.cs | 2 +- SimcProfileParser/Interfaces/ISimcTalentService.cs | 2 +- SimcProfileParser/Interfaces/ISimcVersionService.cs | 2 +- SimcProfileParser/SimcGenerationService.cs | 2 +- SimcProfileParser/SimcParserService.cs | 2 +- SimcProfileParser/SimcProfileParser.csproj | 6 +++--- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/SimcProfileParser/Interfaces/DataSync/ICacheService.cs b/SimcProfileParser/Interfaces/DataSync/ICacheService.cs index 1895034..28f55fa 100644 --- a/SimcProfileParser/Interfaces/DataSync/ICacheService.cs +++ b/SimcProfileParser/Interfaces/DataSync/ICacheService.cs @@ -7,7 +7,7 @@ namespace SimcProfileParser.Interfaces.DataSync /// /// A service for keeping local parsed json files ready for use. /// - public interface ICacheService + internal interface ICacheService { /// /// The base directory the cache service stores its files diff --git a/SimcProfileParser/Interfaces/ISimcItemCreationService.cs b/SimcProfileParser/Interfaces/ISimcItemCreationService.cs index c69513e..c11a936 100644 --- a/SimcProfileParser/Interfaces/ISimcItemCreationService.cs +++ b/SimcProfileParser/Interfaces/ISimcItemCreationService.cs @@ -4,7 +4,7 @@ namespace SimcProfileParser.Interfaces { - public interface ISimcItemCreationService + internal interface ISimcItemCreationService { Task CreateItemAsync(SimcParsedItem parsedItemData); Task CreateItemAsync(SimcItemOptions itemOptions); diff --git a/SimcProfileParser/Interfaces/ISimcParserService.cs b/SimcProfileParser/Interfaces/ISimcParserService.cs index b5c2eaa..7ba19cc 100644 --- a/SimcProfileParser/Interfaces/ISimcParserService.cs +++ b/SimcProfileParser/Interfaces/ISimcParserService.cs @@ -3,7 +3,7 @@ namespace SimcProfileParser.Interfaces { - public interface ISimcParserService + internal interface ISimcParserService { SimcParsedProfile ParseProfileAsync(List profileString); } diff --git a/SimcProfileParser/Interfaces/ISimcSpellCreationService.cs b/SimcProfileParser/Interfaces/ISimcSpellCreationService.cs index 4433a1f..ac53350 100644 --- a/SimcProfileParser/Interfaces/ISimcSpellCreationService.cs +++ b/SimcProfileParser/Interfaces/ISimcSpellCreationService.cs @@ -3,7 +3,7 @@ namespace SimcProfileParser.Interfaces { - public interface ISimcSpellCreationService + internal interface ISimcSpellCreationService { Task GenerateItemSpellAsync(SimcItem item, uint spellId); Task GenerateItemSpellAsync(SimcSpellOptions spellOptions); diff --git a/SimcProfileParser/Interfaces/ISimcTalentService.cs b/SimcProfileParser/Interfaces/ISimcTalentService.cs index 13285dd..4831cad 100644 --- a/SimcProfileParser/Interfaces/ISimcTalentService.cs +++ b/SimcProfileParser/Interfaces/ISimcTalentService.cs @@ -4,7 +4,7 @@ namespace SimcProfileParser.Interfaces { - public interface ISimcTalentService + internal interface ISimcTalentService { Task GetTalentDataAsync(int talentId, int rank); Task> GetAvailableTalentsAsync(int classId, int specId); diff --git a/SimcProfileParser/Interfaces/ISimcVersionService.cs b/SimcProfileParser/Interfaces/ISimcVersionService.cs index 3c5ec6f..3f761fa 100644 --- a/SimcProfileParser/Interfaces/ISimcVersionService.cs +++ b/SimcProfileParser/Interfaces/ISimcVersionService.cs @@ -2,7 +2,7 @@ namespace SimcProfileParser.Interfaces { - public interface ISimcVersionService + internal interface ISimcVersionService { Task GetGameDataVersionAsync(); } diff --git a/SimcProfileParser/SimcGenerationService.cs b/SimcProfileParser/SimcGenerationService.cs index 121b0dd..a1085da 100644 --- a/SimcProfileParser/SimcGenerationService.cs +++ b/SimcProfileParser/SimcGenerationService.cs @@ -49,7 +49,7 @@ public class SimcGenerationService : ISimcGenerationService /// Service for retrieving game data version information. /// Service for fetching and processing talent data. /// Service for caching and retrieving raw game data files. - public SimcGenerationService(ILogger logger, + internal SimcGenerationService(ILogger logger, ISimcParserService simcParserService, ISimcItemCreationService simcItemCreationService, ISimcSpellCreationService simcSpellCreationService, diff --git a/SimcProfileParser/SimcParserService.cs b/SimcProfileParser/SimcParserService.cs index 2ddd110..593ecbd 100644 --- a/SimcProfileParser/SimcParserService.cs +++ b/SimcProfileParser/SimcParserService.cs @@ -10,7 +10,7 @@ namespace SimcProfileParser { - public class SimcParserService : ISimcParserService + internal class SimcParserService : ISimcParserService { private readonly ILogger _logger; diff --git a/SimcProfileParser/SimcProfileParser.csproj b/SimcProfileParser/SimcProfileParser.csproj index 41716d6..aa43dd2 100644 --- a/SimcProfileParser/SimcProfileParser.csproj +++ b/SimcProfileParser/SimcProfileParser.csproj @@ -3,9 +3,9 @@ net9.0 true - 3.1.1 - 3.1.1 - 3.1.1 + 3.1.2 + 3.1.2 + 3.1.2 Mechanical Priest Mechanical Priest GPL-3.0-only