From 53a73acbd382e782777013e66a13d3f5a1b11bea Mon Sep 17 00:00:00 2001 From: Tecc Date: Thu, 3 Sep 2026 21:41:42 +0000 Subject: [PATCH] fix(Core/BG): award correct Alterac Valley reputation End-of-battle bonus reputation was accumulated in a uint8, so a normal win (towers + graveyards + mines + surviving captain) overflowed 255 and awarded almost nothing. Widen the accumulator to uint32. The three Commander quest turn-ins passed teamId as the faction id, so they modified faction 0/1 instead of Stormpike Guard (730) / Frostwolf Clan (729). --- src/server/game/Battlegrounds/Zones/BattlegroundAV.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundAV.cpp b/src/server/game/Battlegrounds/Zones/BattlegroundAV.cpp index 0941c82aa7e..0dc67cb2b4b 100644 --- a/src/server/game/Battlegrounds/Zones/BattlegroundAV.cpp +++ b/src/server/game/Battlegrounds/Zones/BattlegroundAV.cpp @@ -194,21 +194,21 @@ void BattlegroundAV::HandleQuestComplete(uint32 questid, Player* player) case AV_QUEST_A_COMMANDER1: case AV_QUEST_H_COMMANDER1: m_Team_QuestStatus[teamId][1]++; - RewardReputationToTeam(teamId, uint32(1 * _avReputationRate), teamId); + RewardReputationToTeam(teamId == TEAM_ALLIANCE ? 730 : 729, uint32(1 * _avReputationRate), teamId); if (m_Team_QuestStatus[teamId][1] == 30) LOG_DEBUG("bg.battleground", "BG_AV Quest {} completed (need to implement some events here", questid); break; case AV_QUEST_A_COMMANDER2: case AV_QUEST_H_COMMANDER2: m_Team_QuestStatus[teamId][2]++; - RewardReputationToTeam(teamId, uint32(1 * _avReputationRate), teamId); + RewardReputationToTeam(teamId == TEAM_ALLIANCE ? 730 : 729, uint32(1 * _avReputationRate), teamId); if (m_Team_QuestStatus[teamId][2] == 60) LOG_DEBUG("bg.battleground", "BG_AV Quest {} completed (need to implement some events here", questid); break; case AV_QUEST_A_COMMANDER3: case AV_QUEST_H_COMMANDER3: m_Team_QuestStatus[teamId][3]++; - RewardReputationToTeam(teamId, uint32(1 * _avReputationRate), teamId); + RewardReputationToTeam(teamId == TEAM_ALLIANCE ? 730 : 729, uint32(1 * _avReputationRate), teamId); if (m_Team_QuestStatus[teamId][3] == 120) LOG_DEBUG("bg.battleground", "BG_AV Quest {} completed (need to implement some events here", questid); break; @@ -511,7 +511,7 @@ void BattlegroundAV::EndBattleground(TeamId winnerTeamId) //calculate bonuskills for both teams: //first towers: uint8 kills[2] = {0, 0}; // 0 = Alliance 1 = Horde - uint8 rep[2] = {0, 0}; // 0 = Alliance 1 = Horde + uint32 rep[2] = {0, 0}; // 0 = Alliance 1 = Horde if (BattlegroundMgr::IsBGWeekend(GetBgTypeID(true))) kills[winnerTeamId] += 4;