-
Notifications
You must be signed in to change notification settings - Fork 0
Description
One of the main functions of the ‘calibration’ polynomials is converting from the device’s internal units to actual engineering units. It would make sense for the polynomials themselves to be able to specify the units (and/or measurement type) they output. If defined, these would override any units defined by the object (Channel, SubChannel, or EventArray) using it. UnitConverter implements this. This code could be moved from there to the base Transform class, and the related code in EventArray would be moved into the base/mixin Transformable class.
For the present, this would not have any outward effect on idelib; current Transforms (other than the UnitConverters) wouldn't have these attributes set, so the units would fall back to SubChannel's definition. However, there is discussion on the enDAQ firmware side about writing this information in the IDE's CalibrationList; having it set up on the idelib side in advance would make it easier.