Skip to content

Implement UnitConverter from/to units in base Transform class #67

@StokesMIDE

Description

@StokesMIDE

One of the main functions of the ‘calibration’ polynomials is converting from the device’s internal units to actual engineering units. It would make sense for the polynomials themselves to be able to specify the units (and/or measurement type) they output. If defined, these would override any units defined by the object (Channel, SubChannel, or EventArray) using it. UnitConverter implements this. This code could be moved from there to the base Transform class, and the related code in EventArray would be moved into the base/mixin Transformable class.

For the present, this would not have any outward effect on idelib; current Transforms (other than the UnitConverters) wouldn't have these attributes set, so the units would fall back to SubChannel's definition. However, there is discussion on the enDAQ firmware side about writing this information in the IDE's CalibrationList; having it set up on the idelib side in advance would make it easier.

Metadata

Metadata

Assignees

Labels

APIRelated to outward-facing package usability fixes/enhancementscalibrationRelated to the generation or application of `Transform` functiondevelopmentRelated to the development processenhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions