Skip to content

Should we remove ICatalog.getGenericMap()? #102

@MikeHopcroft

Description

@MikeHopcroft

This method is exposing internal implementation details of implementations of ICatalog. The only user seems to be IRuleChecker. Consider coupling RuleChecker to ICatalog, but making RuleChecker constructor take ICatalog as parameter.

This issue came up while reviewing a unit test for ICatalog.getGenericMap(). It is hard to write a satisfactory unit test for this function (need to deep compare Map) and the functionality is tested in other ICatalog methods.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions