Dripless subtitles?

[Max20720]

I really liked this app, liked how customizable it is and I think it looks gorgeous in my Samsung TV.

I watch a lot of anime and sometimes the font and style of the subtitles are kinda of the soul of the thing. Watching some 90's shows recently and the modern, bland subtitles kinda kill the vibe. They appear with the different fonts in the normal Jellyfin app for the Samsung TV, can't I change something in the settings so it also does here?

[RadicalMuffinMan]

I believe those are ASS/SSA subtitles, right?

[Max20720]

I think so

[RadicalMuffinMan]

I'll take a look into ASS/SSA for next release

[matt-hb]

Still relating to ASS/SSA subs, sometimes it seems like they might be parsed incorrectly and the comments/notes the creators leave inside get rendered, which other clients correctly discard. As an example from an anime episode, I have these blocks at the start of the file

Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Comment: 99,0:00:00.00,0:02:54.03,GJM_Main_1080p,chapter,0,0,0,,{Prologue}
Comment: 99,0:02:54.03,0:04:23.99,GJM_Main_1080p,chapter,0,0,0,,{Opening}
Comment: 99,0:04:23.99,0:22:25.03,GJM_Main_1080p,chapter,0,0,0,,{Episode}
Comment: 99,0:22:25.03,0:23:55.08,GJM_Main_1080p,chapter,0,0,0,,{Ending}
Comment: 99,0:00:00.00,0:00:00.00,GJM_Main_1080p,,0,0,0,,{-start: lines from the end of ep08-}
Comment: 99,0:00:00.00,0:00:00.00,GJM_Main_1080p,,0,0,0,,{-end: lines from the end of ep08-}
Comment: 99,0:02:54.03,0:02:54.07,GJM_Main_1080p,,0,0,0,,{-OP-}

And {Prologue}, etc. get rendered alongside the normal subs, which is annoying (I think anything that is marked as Comment: is meant to not be rendered, or just simply being in braces).

There are also lines such as this, where there are comments in braces that should not be rendered.

Dialogue: 99,0:00:44.77,0:00:49.28,GJM_Main_1080p,,0,0,0,,Don't go dying on me, Aki.{same line we've had a couple of times before}

Also yes, confirming styling/font handling/coloring/positioning is the point of ASS/SSA, kinda feels like a waste to just parse and render them the same as regular SRTs, would be massively appreciated if this can be looked at.

My suggestion for handling styled sub formats is the same as the built-in web UI's way of handling it, allow the user to set whether they want to force burned-in subtitles when they are complex formats like ASS/SSA, and direct play when they are regular SRT, this works really quite well for being such a simple way of doing it.

[RadicalMuffinMan]

SSA/SSA implementation is planned for next release, I'll probably bug you two for some testing when it's ready, if you don't mind.

[matt-hb]

That is great, thank you very much!

[Max20720]

No problem, happy to help.

[RadicalMuffinMan]

Implemented in #151 , coming out today

[matt-hb]

On my end (LG C9 OLED, webOS 4.5), even after updating to v2.4.0 (even reinstalled the app), the same behaviour persists, subs are being treated as plaintext, and I can't find anything in settings to enable styling either.

[Max20720]

Yeah same thing here, on my Samsung TV the subtitles are still appearing in plain text