Skip to content

Audit other wai workflows for stale non-gha duplicates #51

Description

@d-morrison

claude-code-review.yml was a stale, hand-rolled, pre-migration copy of
what's now a canonical Morrison-Lab/gha reusable workflow (see #49/#50) --
it carried real bugs the gha version has since fixed across 15+ documented
incidents, simply because it was never migrated to delegate.

Worth checking whether the same is true of this repo's other workflows.
A quick pass over .github/workflows/'s uses: lines shows four already
correctly delegate to Morrison-Lab/gha:

  • bump-ai-config.yml -> bump-submodule.yml
  • check-bibliography-dois.yml -> check-bibliography-dois.yml
  • check-links.yml -> check-links.yml
  • check-non-standard-chars.yaml -> check-non-standard-chars.yml

But several others call third-party actions directly, and gha has a
same-named reusable workflow for at least some of them:

  • claude.yml -- calls anthropics/claude-code-action@v1 directly; gha
    has its own claude.yml.
  • check-spelling.yaml -- calls insightsengineering/r-spellcheck-action
    directly; unclear if gha has an equivalent (worth checking).
  • preview.yml, preview-deploy.yml -- gha has same-named workflows.
  • publish.yml -- gha has quarto-publish.yml, which may or may not be
    the intended counterpart.
  • summary.yml -- gha has a same-named workflow.
  • lint-changed-files.yaml, lint-project.yaml -- gha has
    lint-changed-lines.yml, lint-markdown.yml, lint-qmd.yml,
    lint-yaml.yml, which may cover the same ground under different names.

For each: check whether gha's version is a genuine drop-in replacement
(same capability, same or better), and if so migrate to a thin caller
matching this repo's own established pattern (see the four workflows
above, or #50's version of claude-code-review.yml). Where gha has no
equivalent, leave the standalone workflow as-is.

Not investigated in depth here -- this is a scoping issue for that audit,
found while fixing #49.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions