Feature/hebrew language#56
Merged
NoamBenShimon merged 4 commits intoMay 27, 2026
Merged
Conversation
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces internationalization (i18n) support to the project using
next-intl, adds English and Hebrew translation files, and updates test mocks and assertions to work with localized text. It also makes minor test improvements for component coverage and selector accuracy.Internationalization integration:
next-intlas a dependency and configured it innext.config.tsusing the Next.js plugin system, enabling i18n support throughout the app. [1] [2] [3]messages/en.json) and Hebrew (messages/he.json) translation files covering all major UI sections and components. [1] [2]Testing and mocking improvements:
jest.setup.tsto mocknext-intlhooks and server methods, ensuring tests resolve real translation strings frommessages/en.jsonand remain stable regardless of ESM module issues. Also, stubbed locale-cookie actions to prevent ESM-related test failures.ConfirmDialogandEquipmentListtests. [1] [2] [3] [4] [5] [6]These changes lay the groundwork for a fully localized user experience and ensure tests remain reliable as the UI adapts to multiple languages.