Skip to content

Feature/hebrew language#56

Merged
NoamBenShimon merged 4 commits into
Motzklist:mainfrom
NoamBenShimon:feature/hebrew-language
May 27, 2026
Merged

Feature/hebrew language#56
NoamBenShimon merged 4 commits into
Motzklist:mainfrom
NoamBenShimon:feature/hebrew-language

Conversation

@NoamBenShimon

Copy link
Copy Markdown
Contributor

This pull request introduces internationalization (i18n) support to the project using next-intl, adds English and Hebrew translation files, and updates test mocks and assertions to work with localized text. It also makes minor test improvements for component coverage and selector accuracy.

Internationalization integration:

  • Added next-intl as a dependency and configured it in next.config.ts using the Next.js plugin system, enabling i18n support throughout the app. [1] [2] [3]
  • Added comprehensive English (messages/en.json) and Hebrew (messages/he.json) translation files covering all major UI sections and components. [1] [2]

Testing and mocking improvements:

  • Updated jest.setup.ts to mock next-intl hooks and server methods, ensuring tests resolve real translation strings from messages/en.json and remain stable regardless of ESM module issues. Also, stubbed locale-cookie actions to prevent ESM-related test failures.
  • Updated component tests to use role-based queries and localized text, improving selector robustness and reflecting the new i18n setup. This includes more accurate button selection and variant class assertions in ConfirmDialog and EquipmentList tests. [1] [2] [3] [4] [5] [6]

These changes lay the groundwork for a fully localized user experience and ensure tests remain reliable as the UI adapts to multiple languages.

NoamBenShimon and others added 4 commits May 26, 2026 22:55
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
Signed-off-by: Noam Ben Shimon <Noambs2999@gmail.com>
@NoamBenShimon NoamBenShimon merged commit ff4e776 into Motzklist:main May 27, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant