feat: improve accessibility - ARIA labels, keyboard nav, screen reade…#138
Open
shresthbhargava wants to merge 1 commit into
Open
feat: improve accessibility - ARIA labels, keyboard nav, screen reade…#138shresthbhargava wants to merge 1 commit into
shresthbhargava wants to merge 1 commit into
Conversation
Owner
|
@shresthbhargava add some screenshot & resolve the script.js conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123
What's Changed
script.jsrole="region"andaria-labelto all result cards so screen readers announce scan outcomesaria-busy="true"while scanning and updates itsaria-labelto "Scanning URL, please wait..."aria-pressedand descriptive labels ("Switch to light/dark mode")aria-hidden="true"so screen readers skip themaria-hidden="true"+ adjacent.sr-onlytext for screen reader meaningrole="list"+role="listitem"for proper screen reader navigationrole="progressbar"witharia-valuenow,aria-valuemin,aria-valuemaxrole="list"with each card asrole="listitem"fillExample()updatesaria-labelon input to reflect filled valueindex.htmltype="button"to all buttons to prevent accidental form submissionrole="alert"andaria-live="assertive"aria-hidden="true"aria-live="polite",aria-atomic="true",role="status"style.css:focus-visibleoutline using brand color#00ffb4for keyboard users:focus:not(:focus-visible)to remove outline for mouse users only.sr-onlyutility class for screen-reader-only textTesting