From 996465dea047551738d907503ef91ea7ba800cc5 Mon Sep 17 00:00:00 2001 From: kzubatov Date: Sun, 2 Nov 2025 13:08:57 +0300 Subject: [PATCH 1/6] fix PR comments --- .github/workflows/lint.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 42a50877..1fba296f 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -8,9 +8,6 @@ on: - '**.clang-format' - '**.clang-tidy' -permissions: - contents: read - jobs: check-format-and-tidy: runs-on: ubuntu-latest From 50dd14917b68e03ac2c2e32fb0e75b29951f3fa3 Mon Sep 17 00:00:00 2001 From: kzubatov Date: Sun, 2 Nov 2025 14:19:39 +0300 Subject: [PATCH 2/6] fix comments for private repos --- .github/workflows/lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 1fba296f..cf7c2384 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -44,7 +44,7 @@ jobs: cmake_command: | cmake -Bbuild -S. -DCMAKE_EXPORT_COMPILE_COMMANDS=on -DGLFW_BUILD_WAYLAND=off clang_tidy_checks: '' # Use closest .clang-tidy config, not some weird default - split_workflow: true # So that comments work with fork PRs + split_workflow: github.event.repository.public # So that comments work with fork PRs # Upload review results as artifacts, a different workflow posts them # as comments. This is required due to security stuff. From efd429783db65f83356cf394ea7149a3a2b95384 Mon Sep 17 00:00:00 2001 From: kzubatov Date: Sun, 2 Nov 2025 14:32:01 +0300 Subject: [PATCH 3/6] i hate yaml --- .github/workflows/lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index cf7c2384..c0aa0664 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -44,7 +44,7 @@ jobs: cmake_command: | cmake -Bbuild -S. -DCMAKE_EXPORT_COMPILE_COMMANDS=on -DGLFW_BUILD_WAYLAND=off clang_tidy_checks: '' # Use closest .clang-tidy config, not some weird default - split_workflow: github.event.repository.public # So that comments work with fork PRs + split_workflow: ${{ github.event.repository.public }} # So that comments work with fork PRs # Upload review results as artifacts, a different workflow posts them # as comments. This is required due to security stuff. From a0685b1897477f28dade2ddaefeb25a8fb233d76 Mon Sep 17 00:00:00 2001 From: kzubatov Date: Sun, 2 Nov 2025 14:57:23 +0300 Subject: [PATCH 4/6] ok.lets.use.this.param.because.why.not --- .github/workflows/lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index c0aa0664..cb66acf5 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -44,7 +44,7 @@ jobs: cmake_command: | cmake -Bbuild -S. -DCMAKE_EXPORT_COMPILE_COMMANDS=on -DGLFW_BUILD_WAYLAND=off clang_tidy_checks: '' # Use closest .clang-tidy config, not some weird default - split_workflow: ${{ github.event.repository.public }} # So that comments work with fork PRs + split_workflow: ${{ github.event.pull_request.head.repo.fork }} # So that comments work with fork PRs # Upload review results as artifacts, a different workflow posts them # as comments. This is required due to security stuff. From 87ad9457176ee8a12190172855f3018069f20e5f Mon Sep 17 00:00:00 2001 From: kzubatov Date: Mon, 3 Nov 2025 17:46:51 +0300 Subject: [PATCH 5/6] add minor fixes for lint and format --- .github/workflows/format.yaml | 2 +- .github/workflows/lint.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/format.yaml b/.github/workflows/format.yaml index 087d25e7..eeb8e9e9 100644 --- a/.github/workflows/format.yaml +++ b/.github/workflows/format.yaml @@ -11,7 +11,7 @@ permissions: contents: read jobs: - check-format-and-tidy: + check-format: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index cb66acf5..383d1770 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -5,7 +5,6 @@ on: paths: - '**.hpp' - '**.cpp' - - '**.clang-format' - '**.clang-tidy' jobs: @@ -49,6 +48,7 @@ jobs: # Upload review results as artifacts, a different workflow posts them # as comments. This is required due to security stuff. - uses: ZedThree/clang-tidy-review/upload@v0.21.0 + id: upload-review # If there are any comments, fail the check - if: steps.review.outputs.total_comments > 0 From 2c788e478e13e000d07871872fe617327fba987b Mon Sep 17 00:00:00 2001 From: kzubatov Date: Fri, 31 Oct 2025 17:40:10 +0300 Subject: [PATCH 6/6] stupid commit to test CI --- samples/shadowmap/App.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/shadowmap/App.cpp b/samples/shadowmap/App.cpp index 6a188531..fa48e992 100644 --- a/samples/shadowmap/App.cpp +++ b/samples/shadowmap/App.cpp @@ -31,10 +31,10 @@ App::App() auto instExts = windowing.getRequiredVulkanInstanceExtensions(); renderer->initVulkan(instExts); - auto surface = mainWindow->createVkSurface(etna::get_context().getInstance()); + auto surface_ = mainWindow->createVkSurface(etna::get_context().getInstance()); renderer->initFrameDelivery( - std::move(surface), [window = mainWindow.get()]() { return window->getResolution(); }); + std::move(surface_), [window = mainWindow.get()]() { return window->getResolution(); }); // TODO: this is bad design, this initialization is dependent on the current ImGui context, but we // pass it implicitly here instead of explicitly. Beware if trying to do something tricky.