NRL-721 Sonarqube fixes

Author: sandyforresternhs

scripts/delete_all_table_items.py

@@ -22,7 +22,7 @@ def _handle_table_access_error(e, table_name):
     sys.exit(1)
 
 
-def _scan_and_delete_batch(table, key_names, scan_kwargs, deleted_count):
+def _scan_and_delete_batch(table, scan_kwargs, deleted_count):
     try:
         response = table.scan(**scan_kwargs)
     except ClientError as e:
@@ -57,7 +57,7 @@ def delete_all_table_items(table_name):
     try:
         while True:
             last_key, deleted_count, was_throttled = _scan_and_delete_batch(
-                table, key_names, scan_kwargs, deleted_count
+                table, scan_kwargs, deleted_count
             )
 
             if was_throttled:

scripts/seed_sandbox_table.py

@@ -200,7 +200,7 @@ def _write_batch_to_dynamodb(table_name: str, batch_items: list[dict]) -> bool:
     except ClientError as e:
         error_code = e.response["Error"]["Code"]
         if error_code == "ProvisionedThroughputExceededException":
-            print(f"\n✗ Throttled. Retrying batch...")
+            print("\n✗ Throttled. Retrying batch...")
         else:
             print(f"\n✗ Error writing batch, batch cancelled: {e}")
         return False

scripts/tests/test_seed_sandbox_table.py

@@ -229,7 +229,7 @@ def test_creates_content_structure_when_missing(
         mock_pointer = MagicMock()
         mock_pointer_class.from_document_reference.return_value = mock_pointer
 
-        result = _make_realistic_pointer(template, "Y12345", "9000000001", 1)
+        _make_realistic_pointer(template, "Y12345", "9000000001", 1)
 
         call_args = mock_doc_ref_class.call_args[1]
         assert "content" in call_args
@@ -263,7 +263,7 @@ def test_adds_retrieval_mechanism_when_content_exists_without_it(
         mock_pointer = MagicMock()
         mock_pointer_class.from_document_reference.return_value = mock_pointer
 
-        result = _make_realistic_pointer(template, "Y12345", "9000000001", 1)
+        _make_realistic_pointer(template, "Y12345", "9000000001", 1)
 
         call_args = mock_doc_ref_class.call_args[1]
         extensions = call_args["content"][0]["extension"]
@@ -310,7 +310,7 @@ def test_does_not_duplicate_retrieval_mechanism_when_already_present(
         mock_pointer = MagicMock()
         mock_pointer_class.from_document_reference.return_value = mock_pointer
 
-        result = _make_realistic_pointer(template, "Y12345", "9000000001", 1)
+        _make_realistic_pointer(template, "Y12345", "9000000001", 1)
 
         call_args = mock_doc_ref_class.call_args[1]
         extensions = call_args["content"][0]["extension"]