From 122f97cb59d72f9a0b516f13bbbadee702c77ff8 Mon Sep 17 00:00:00 2001 From: Gareth Morgan Date: Tue, 13 Oct 2026 15:25:04 -0400 Subject: [PATCH] test(webxr): enable warm-up simulation in StreamAttachTimeoutTest attempt 2 Attempt 2 ("attaches, no frame ever") left MockCloudXR's warm-up simulation off, so the mock rendered normally and emitted streaming metrics for the whole attempt. The test's "no streaming metrics before warm-up completes" check treated that as a failure, so the spec failed on main. Turn the simulation on with warmupTotalFrames: null. render() then stays black like a stuck decoder, no metrics fire, and the warm-up-begin timeout still triggers because no warm-up frame is ever fed. Co-Authored-By: Claude Sonnet 5.5 Signed-off-by: Gareth Morgan --- .../webxr_client/tests/mock/StreamAttachTimeoutTest.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/deps/cloudxr/webxr_client/tests/mock/StreamAttachTimeoutTest.tsx b/deps/cloudxr/webxr_client/tests/mock/StreamAttachTimeoutTest.tsx index e563922531..2f17267ced 100644 --- a/deps/cloudxr/webxr_client/tests/mock/StreamAttachTimeoutTest.tsx +++ b/deps/cloudxr/webxr_client/tests/mock/StreamAttachTimeoutTest.tsx @@ -78,7 +78,10 @@ interface AttemptConfig { // Per-attempt mock configuration - see the module doc comment for what each attempt tests. const ATTEMPT_CONFIGS: AttemptConfig[] = [ { connectWaitMs: 1250, frameCallCount: 0 }, // 1: attach timeout (over 1x budget) - { connectWaitMs: 100, frameCallCount: 0 }, // 2: attaches fine, no frame ever -> warmup-begin timeout + // 2: attaches fine, no frame ever -> warmup-begin timeout. warmupTotalFrames: null turns warm-up + // simulation on (render() stays black, no streaming metrics); left off, the mock renders and + // emits streaming metrics, which trips the "no metrics during warm-up" check below. + { connectWaitMs: 100, warmupTotalFrames: null, frameCallCount: 0 }, { connectWaitMs: 100, warmupTotalFrames: null, frameCallCount: 1 }, // 3: warm-up begins, then stalls -> warmup-end timeout { connectWaitMs: 100, warmupTotalFrames: 2, frameCallCount: 3 }, // 4: warm-up begins and completes fast -> success ];