Skip to content

Commit fd2621a

Browse files
committed
fix(e2e): pass resolved openshell binary to MCP bridge
Signed-off-by: Kris Hicks <khicks@nvidia.com>
1 parent fa8ab4b commit fd2621a

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

e2e/mcp-conformance.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,21 @@ openshell_bin() {
111111

112112
start_host_bridge() {
113113
local port=$1
114-
local runner_ip
114+
local openshell runner_ip
115115
HOST_BRIDGE_LOG="${ROOT}/.cache/mcp-conformance/host-bridge.log"
116116
mkdir -p "$(dirname "${HOST_BRIDGE_LOG}")"
117117

118+
if ! openshell="$(openshell_bin)"; then
119+
return 1
120+
fi
118121
if ! runner_ip="$(runner_container_ip)"; then
119122
return 1
120123
fi
121124

122125
RUNNER_CONTAINER_IP="${runner_ip}"
123126
HOST_BRIDGE_TOKEN="$(python3 -c 'import secrets; print(secrets.token_urlsafe(32))')"
124-
OPENSHELL_MCP_CONFORMANCE_RUNNER_IP="${runner_ip}" \
127+
OPENSHELL_BIN="${openshell}" \
128+
OPENSHELL_MCP_CONFORMANCE_RUNNER_IP="${runner_ip}" \
125129
OPENSHELL_MCP_CONFORMANCE_BRIDGE_TOKEN="${HOST_BRIDGE_TOKEN}" \
126130
python3 "${ROOT}/e2e/mcp-conformance/host-bridge.py" \
127131
"${port}" "${ROOT}" "${HOST_BRIDGE_LOG}" &

e2e/mcp-conformance/client-through-openshell.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ ROOT="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
2727

2828
# shellcheck source=e2e/support/gateway-common.sh disable=SC1091
2929
source "${ROOT}/e2e/support/gateway-common.sh"
30-
TARGET_DIR="$(e2e_cargo_target_dir "${ROOT}")"
31-
OPENSHELL_BIN="${OPENSHELL_BIN:-${TARGET_DIR}/debug/openshell}"
30+
if [ -z "${OPENSHELL_BIN:-}" ]; then
31+
TARGET_DIR="$(e2e_cargo_target_dir "${ROOT}")"
32+
OPENSHELL_BIN="${TARGET_DIR}/debug/openshell"
33+
fi
3234

3335
require_active_gateway() {
3436
local status_output

0 commit comments

Comments
 (0)