Skip to content

nv-boot notice_check_test is broken in the monorepo layout (quarantined) #323

Description

@balajinvda

Problem

//src/libraries/java/nv-boot-parent/tools/bazel:notice_check_test fails on main (ModuleNotFoundError: No module named 'generate_notice'). It was written for nv-boot-parent as a standalone workspace root: it locates generate_notice.py and its metadata at ${workspace}/tools/bazel/..., but in the monorepo the workspace root is the repo root, so those files live under src/libraries/java/nv-boot-parent/tools/bazel. It also runs generate_notice --check against the aggregate root NOTICE using only nv-boot roots, which cannot match.

It never ran in CI before because root tests were skipped until #311 enabled them; the #269 merge then turned main red.

Immediate action

Quarantined via .github/bazel-root-test-quarantine.txt to restore a green main.

Proper fix (nv-boot owner)

Rewrite the test for the monorepo layout: resolve generate_notice.py/metadata/roots via runfiles (its data deps) instead of ${workspace}/tools/bazel, and scope the NOTICE --check correctly (nv-boot's own NOTICE, or integrate into the repo-wide NOTICE tooling). Then remove the quarantine entry.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions