From 3640a0165b226162061a432307bdda35c4f3be35 Mon Sep 17 00:00:00 2001 From: Anil Balireddy Date: Fri, 11 Sep 2026 10:18:11 -0700 Subject: [PATCH 1/2] Fix stale retail/healthcare recipe references and placeholder package metadata Two doc/metadata drift issues found while reviewing the codebase: 1. nvflow/cli/main.py's --recipe help text and nvflow/core/stage_registry.py's register()/class docstrings referenced "retail" and "healthcare" as example recipes. Only finance, example, and multimodal recipes exist anywhere in the codebase -- retail/healthcare appear to be leftover placeholder names from before the repo's public release. Updated the examples to reference real recipes. 2. pyproject.toml shipped an unfilled template placeholder (authors = [{name = "Your Team", email = "team@example.com"}]) in the public release. Replaced with "NVIDIA Corporation" -- happy to adjust to a specific team alias/email if maintainers prefer one. Co-Authored-By: Claude Sonnet 5 Signed-off-by: Anil Balireddy --- nvflow/cli/main.py | 2 +- nvflow/core/stage_registry.py | 4 ++-- pyproject.toml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/nvflow/cli/main.py b/nvflow/cli/main.py index fbfe72e..b3a861a 100644 --- a/nvflow/cli/main.py +++ b/nvflow/cli/main.py @@ -165,7 +165,7 @@ def list_stages( None, "--config", "-c", help="Optional: Show only stages defined in this config file" ), recipe: str | None = typer.Option( - None, "--recipe", "-r", help="Optional: Filter by recipe (finance, retail, healthcare)" + None, "--recipe", "-r", help="Optional: Filter by recipe (finance, example, multimodal)" ), workflow: str | None = typer.Option( None, "--workflow", "-w", help="Optional: Filter by workflow (training_sft, sdg_basic)" diff --git a/nvflow/core/stage_registry.py b/nvflow/core/stage_registry.py index 49daae9..3081539 100644 --- a/nvflow/core/stage_registry.py +++ b/nvflow/core/stage_registry.py @@ -40,7 +40,7 @@ class StageRegistry: """Hierarchical registry for workflow stages. Stages are organized in a three-level hierarchy: - - Recipe (e.g., "finance", "retail") + - Recipe (e.g., "finance", "multimodal") - Workflow (e.g., "training_sft", "sdg_basic") - Stage (e.g., "baseline", "generate_qa") @@ -70,7 +70,7 @@ def register(cls, recipe: str, workflow: str, stage: str): """Decorator to register a stage class in the hierarchy. Args: - recipe: Recipe name (e.g., "finance", "retail") + recipe: Recipe name (e.g., "finance", "multimodal") workflow: Workflow name within recipe (e.g., "training_sft", "sdg_basic") stage: Stage name within workflow (e.g., "baseline", "generate_qa") diff --git a/pyproject.toml b/pyproject.toml index 31761ea..81ab51d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -3,7 +3,7 @@ name = "nvflow" dynamic = ["version"] # Version determined from git tags via hatch-vcs description = "Workflow orchestration for end-to-end model training on NeMo ecosystem" authors = [ - {name = "Your Team", email = "team@example.com"} + {name = "NVIDIA Corporation"} ] readme = "README.md" requires-python = ">=3.12,<3.14" From 530dd4ab7111ccccba2464408c469d2fffb00e25 Mon Sep 17 00:00:00 2001 From: Anil Balireddy Date: Tue, 15 Sep 2026 15:57:26 -0700 Subject: [PATCH 2/2] Fix stale sdg_basic workflow example in --workflow help text Per review feedback: sdg_basic isn't a real workflow (same class of issue as the retail/healthcare recipe names this PR already fixes). Replaced with sdg_simple, the example recipe's actual registered workflow. Co-Authored-By: Claude Sonnet 5 Signed-off-by: Anil Balireddy --- nvflow/cli/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nvflow/cli/main.py b/nvflow/cli/main.py index b3a861a..fd57bd6 100644 --- a/nvflow/cli/main.py +++ b/nvflow/cli/main.py @@ -168,7 +168,7 @@ def list_stages( None, "--recipe", "-r", help="Optional: Filter by recipe (finance, example, multimodal)" ), workflow: str | None = typer.Option( - None, "--workflow", "-w", help="Optional: Filter by workflow (training_sft, sdg_basic)" + None, "--workflow", "-w", help="Optional: Filter by workflow (training_sft, sdg_simple)" ), ): """List all available stages or stages in a workflow config."""