Weather Discussion Renders Incorrectly on Android

[stevekuznetsov]

We're seeing the same Collapsible issue as in #854 on Android for weather forecast discussions. Absolutely no idea why the patch fixed the render for all other instances of this library but not the weather discussion.

[rossobrien]

I see this bug on my android, gonna take a stab at it

[rossobrien]

@stevekuznetsov is this bug referring only to the "Weather Discussion" CollapsibleCard for the SAC forecasts? I see the bug in the production app when looking at an SAC forecast, but it displays correctly on main in Expo Go. The NWAC weather forecast cards have startsCollapsed={true} so they seem to be intended to display as collapsed initially.

[stevekuznetsov]

@rossobrien so sorry I missed your message. You're correct - this affects non-NWAC forecasts for the reason you mention.

The Expo Go sandbox uses the New Architecture by default so I'm not certain if it's a good testbed - which is unfortunate. We're blocked on moving to the New Architecture until react-native-maps supports it.

The RCA issue in the collapsible library seemed to manifest for folks way before the New Architecture was made default (reported as a bug with 0.74, new architecture was 0.76) so I don't know for sure but building a dev build and running that on an emulator would likely be a more accurate way to reproduce it.

[rustynwac]

https://drive.google.com/file/d/1PFRitvYxBdDM-KBIyxMOkBo3y9QJkd6I/view?usp=sharing

[kevinherdez]

There seems to be something funky happening because we're showing these collapsible cards as a part of a top tab navigator. They only seem to correctly render if the view they're on is the initial view shown by the top tab. You can test this by changing the initialRouteName to weather in ForecastScreen.tsx. By doing that the collapsible cards in the Weather tab should work, but the ones in the Avalanche tab will be broken.

The local branch that I have with the New Architecture and Expo 53 seems to fix this issue. Depending on how quickly we can get this out, a potential quick and dirty solution would be to have the cards initially collapsed only on Android.

I'll keep digging in to see if there's a better patch, but if we can get Mapbox, the New Architecture, and Expo 53 out soon. It might not be worth spending a ton of time knowing that the New Architecture will fix it

[stevekuznetsov]

something funky

4 sure