Some naming was quickly introduced in PR #91 and it may be more clear to have some renaming of both folders, files, and components/groups/subsystems in bert.py
Renaming Folders/Files
The current file structure exists because of legacy ideas about the organization of the code which no longer apply. The proposed renaming are:
components/stack rename to components/degradationcomponents/cluster rename to components/dynamicsconnectors/: maybe add subfolders to this to distinguish different types of connector components.
bounds_baseclass.py:scale_power.py: maybe this should be moved to a new folder called scalars?
translators/ rename to ??
simple_power_translator.py
PowerToCurrentCurveCoeffPowerToCurrent
Renaming subsystems and groups
The OpenMDAO refactor requires many more "side" components than the previous workflow. Currently, each cluster has the following 3 major subsystems:
converter: "pre-translator" that does calculations needed for the translator and simulation components
IJ_ref: gets reference points for Power-Current curve fit and outputs lower and upper bounds of current density and currentref_cell: reference cell that calculated power consumption for each current reference pointp2i: calculates curve coefficients to convert power to current
translator:
cluster_to_stack: scale down power signal from cluster-level to stack-levelstack_to_cell: scale down power signal from stack-level to cell-levelcommand_to_current: takes in the coefficients from p2i and translates the power signal from the controller to current
simulation
dynamicscell_nominaldegradationcell_real
Possible renaming is:
converter: ?
IJ_ref: boundsref_cell: OK as-isp2i: translator_coeffs?
translator: ?
cluster_to_stack:stack_to_cell:command_to_current: maybe use the control command name instead. So its hydrogen_to_current or power_to_current?
simulation: these are good
dynamicscell_nominaldegradationcell_real
Some naming was quickly introduced in PR #91 and it may be more clear to have some renaming of both folders, files, and components/groups/subsystems in bert.py
Renaming Folders/Files
The current file structure exists because of legacy ideas about the organization of the code which no longer apply. The proposed renaming are:
components/stackrename tocomponents/degradationcomponents/clusterrename tocomponents/dynamicsconnectors/: maybe add subfolders to this to distinguish different types of connector components.bounds_baseclass.py:scale_power.py: maybe this should be moved to a new folder calledscalars?translators/rename to ??simple_power_translator.pyPowerToCurrentCurveCoeffPowerToCurrentRenaming subsystems and groups
The OpenMDAO refactor requires many more "side" components than the previous workflow. Currently, each cluster has the following 3 major subsystems:
converter: "pre-translator" that does calculations needed for thetranslatorandsimulationcomponentsIJ_ref: gets reference points for Power-Current curve fit and outputs lower and upper bounds of current density and currentref_cell: reference cell that calculated power consumption for each current reference pointp2i: calculates curve coefficients to convert power to currenttranslator:cluster_to_stack: scale down power signal from cluster-level to stack-levelstack_to_cell: scale down power signal from stack-level to cell-levelcommand_to_current: takes in the coefficients fromp2iand translates the power signal from the controller to currentsimulationdynamicscell_nominaldegradationcell_realPossible renaming is:
converter: ?IJ_ref:boundsref_cell: OK as-isp2i:translator_coeffs?translator: ?cluster_to_stack:stack_to_cell:command_to_current: maybe use the control command name instead. So itshydrogen_to_currentorpower_to_current?simulation: these are gooddynamicscell_nominaldegradationcell_real