[Bug] Use `sendResponse` wrapper in `deleteUserController` for consistent API envelope

[kingksjo]

Domain: Identity

---

Issue [Bug] Use sendResponse wrapper in deleteUserController for consistent API envelope

Tier: 🟢 Easy

Description:

• Problem: The deleteUserController in src/modules/users/users.controller.ts line 22 uses raw res.json() to send the response instead of the standardized sendResponse() utility. This breaks the API contract — all other endpoints return the { success, message, data, meta } envelope, but user deletion returns a bare JSON object. The frontend's Axios interceptor expects the standard envelope and will fail to extract the response correctly.
• Implementation: Replace res.json(...) with sendResponse(res, 200, true, 'User deleted successfully', result) (or appropriate message). Ensure the import for sendResponse is present at the top of the file.

Dependencies:

• Depends on None

Acceptance Criteria:

• deleteUserController uses sendResponse() instead of res.json().
• Response follows the { success, message, data } envelope format.
• Frontend can parse the delete response using the standard interceptor.
• Proper HTTP status codes and our standard JSON response wrapper are used.
• Edge cases (e.g., missing data, unauthorized roles) are handled gracefully.

Testing Requirements:

• Add test: DELETE /users/:id response matches { success: true, message: string, data: ... } shape.
• Run existing user tests to confirm no regressions.
• Unit tests written for the core logic (target 80%+ coverage).
• External API calls or database connections are mocked in unit tests.
• Postman collection or Swagger spec updated (if this adds/modifies an endpoint).

PR Checklist:

• Branch is named conventionally (e.g., fix/issue-55-delete-user-response-envelope).
• npm run lint and npm run build pass with zero warnings.
• Screenshot of passing Jest terminal logs is attached to the PR.
• Database migrations/seed scripts updated (if applicable).

[TheShnider]

@TheShnider has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi. I have reviewed this issue and would like to work on it.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @TheShnider to this issue.

[ayo-ola0710]

@ayo-ola0710 has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi i would love to handle these issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @ayo-ola0710 to this issue.

[drips-wave]

Congratulations, @ayo-ola0710! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @ayo-ola0710: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @ayo-ola0710 as part of the Stellar Wave Program's 5th Wave 🥳

😎 @ayo-ola0710: You earned 150 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.