From 28064a90a31db2590e546c11ff5ae27a1efdb1b9 Mon Sep 17 00:00:00 2001 From: Daniel McKnight Date: Thu, 12 Mar 2026 14:01:41 -0700 Subject: [PATCH 1/4] Update visibility to handle default value of `None` --- neon_skill_weather/api_data_models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neon_skill_weather/api_data_models.py b/neon_skill_weather/api_data_models.py index 84a97dbf..43a3c83a 100644 --- a/neon_skill_weather/api_data_models.py +++ b/neon_skill_weather/api_data_models.py @@ -47,7 +47,7 @@ class WeatherCondition(BaseModel): dew_point: float = Field(description="dew point temperature") uvi: float = Field(description="UV index") clouds: int = Field(description="cloudiness percentage") - visibility: Optional[int] = Field(description="visibility in meters") + visibility: Optional[int] = Field(default=None, description="visibility in meters") wind_speed: float = Field(description="wind speed in requested unit") wind_deg: int = Field(description="wind direction in degrees") weather_id: int = Field(description="weather condition description") From e417ab9d72e4adaf4dafdd2f599fdc7fee5e820e Mon Sep 17 00:00:00 2001 From: NeonDaniel Date: Thu, 12 Mar 2026 21:02:35 +0000 Subject: [PATCH 2/4] Update skill.json --- skill.json | 44 +++++++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/skill.json b/skill.json index d896e679..e04bed7b 100644 --- a/skill.json +++ b/skill.json @@ -1,28 +1,42 @@ { - "title": "Weather", - "url": "https://github.com/NeonGeckoCom/skill-weather", + "title": "neon-skill-weather", + "icon": "https://rawgithub.com/FortAwesome/Font-Awesome/master/svgs/solid/sun.svg", "summary": "Get current weather and forecast info.", - "short_description": "Get current weather and forecast info.", "description": "This skill provides current weather information at different locations and forecasts up to 5 days. Use of this skill requires use of third-party APIs. If you do not have access to Neon API servers, you may access the Alpha Vantage API directly by providing a key in `~/owm.txt`. You can generate an Open Weather Map key [here](https://home.openweathermap.org/users/sign_up)", "examples": [ "What is the weather in Los Angeles?", "What is the forecast for Friday?" ], - "desktopFile": false, - "warning": "", - "systemDeps": false, + "credits": [ + "Neongecko" + ], + "category": "", + "package_name": "neon-skill-weather", + "pip_spec": "neon-skill-weather", + "license": "BSD-3-Clause", + "author": "Neongecko", + "tags": [], + "version": "3.1.1a3", + "url": "https://github.com/NeonGeckoCom/skill-weather", + "skill_id": "skill-weather.neongeckocom=neon_skill_weather:WeatherSkill", + "skillname": "skill-weather", + "authorname": "NeonGeckoCom", + "name": "neon-skill-weather", "requirements": { "python": [ "multi-key-dict==2.0.3", + "requests>=2.13.0", "neon-utils~=1.9", "ovos-utils~=0.0, >=0.0.28", "ovos-workshop~=0.0", - "pydantic~=2.0", - "requests>=2.13.0" + "pydantic~=2.0" ], "system": {}, "skill": [] }, + "desktopFile": false, + "warning": "", + "systemDeps": false, "incompatible_skills": [], "platforms": [ "i386", @@ -32,18 +46,6 @@ "arm" ], "branch": "master", - "license": "BSD-3-Clause", - "icon": "https://rawgithub.com/FortAwesome/Font-Awesome/master/svgs/solid/sun.svg", - "category": "", - "categories": [], - "tags": [], - "credits": [ - "Mycroft AI", - "NeonDaniel", - "reginaneon" - ], - "skillname": "skill-weather", - "authorname": "NeonGeckoCom", "foldername": null, - "troubleshooting": "Try asking for a different location or changing your default location by saying `Neon change my location to Seattle`." + "short_description": "Get current weather and forecast info." } \ No newline at end of file From 94e2860150252e38d755cd7ef4783109ef2941ed Mon Sep 17 00:00:00 2001 From: Daniel McKnight Date: Fri, 13 Mar 2026 10:02:55 -0700 Subject: [PATCH 3/4] Update neon-utils dependency to resolve test failures --- requirements/requirements.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/requirements/requirements.txt b/requirements/requirements.txt index e7a89e40..caadc2da 100644 --- a/requirements/requirements.txt +++ b/requirements/requirements.txt @@ -1,6 +1,7 @@ multi-key-dict==2.0.3 requests>=2.13.0 -neon-utils~=1.9 +#TODO: `network` extra included to patch dependency resolution +neon-utils[network]~=1.9,>=1.14.1a1 ovos-utils~=0.0, >=0.0.28 ovos-workshop~=0.0 pydantic~=2.0 From 2cdff49db37001ab940082d8f62b81e746893db4 Mon Sep 17 00:00:00 2001 From: NeonDaniel Date: Fri, 13 Mar 2026 17:08:33 +0000 Subject: [PATCH 4/4] Update skill.json --- skill.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skill.json b/skill.json index e04bed7b..40d16660 100644 --- a/skill.json +++ b/skill.json @@ -26,7 +26,7 @@ "python": [ "multi-key-dict==2.0.3", "requests>=2.13.0", - "neon-utils~=1.9", + "neon-utils[network]~=1.9,>=1.14.1a1", "ovos-utils~=0.0, >=0.0.28", "ovos-workshop~=0.0", "pydantic~=2.0"