Skip to content

MSIP for GMMs#23

Merged
dannys4 merged 8 commits into
mainfrom
msip_for_GMMs
Apr 16, 2026
Merged

MSIP for GMMs#23
dannys4 merged 8 commits into
mainfrom
msip_for_GMMs

Conversation

@AyoubBelhadji
Copy link
Copy Markdown
Member

No description provided.

In test_msipgmm.py, MSIPGMMGaussianKernel is compared to MSIPQuadGradientInformed.
In msip-vs-msipgs_on_gmms.py, msip is compared to msip_gs.
@AyoubBelhadji AyoubBelhadji requested a review from dannys4 April 10, 2026 18:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

Test Results

2 tests  ±0   2 ✅ ±0   7s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4f012ea. ± Comparison against base commit cce71d9.

♻️ This comment has been updated with latest results.

@AyoubBelhadji AyoubBelhadji changed the title Msip for gm ms MSIP for gmms Apr 10, 2026
@AyoubBelhadji AyoubBelhadji changed the title MSIP for gmms MSIP for GMMs Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/nak_torch/algorithms/msip/estimators.py 12.90% 27 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread src/nak_torch/algorithms/msip/estimators.py Outdated
@dannys4 dannys4 merged commit 926c09f into main Apr 16, 2026
2 of 3 checks passed
@dannys4 dannys4 deleted the msip_for_GMMs branch April 16, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants