From 80a7bcc4a23bb34a4aac3fa42877ace00000bbc7 Mon Sep 17 00:00:00 2001
From: NoisemakerJon <139656120+Noisemaker111@users.noreply.github.com>
Date: Fri, 4 Sep 2026 22:57:39 -0400
Subject: [PATCH] Repair release prerequisites and deterministic package tests

---
 .github/workflows/ci.yml                      |  3 +++
 .github/workflows/publish.yml                 |  3 +++
 CHANGELOG.md                                  |  5 +++++
 .../editor/src/mcp/loadGameCatalogs.test.ts   | 14 +++++++------
 .../catalog-game/src/editorCatalogs.ts        |  8 ++++++++
 packages/shell/src/render/useFootIk.test.ts   | 20 ++++++++++++++++---
 packages/shell/src/render/useFootIk.ts        |  4 +++-
 7 files changed, 47 insertions(+), 10 deletions(-)
 create mode 100644 packages/editor/testFixtures/catalog-game/src/editorCatalogs.ts

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index be7e9d9fc..21c007ae5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -61,6 +61,9 @@ jobs:
       - run: bun install --frozen-lockfile
       - run: bun run build
       - run: bun run build:registry
+      - run: bun run games:clone
+        env:
+          GAMES_CLONE_TOKEN: ${{ secrets.GAMES_CLONE_TOKEN }}
       - run: bun run check-types
       - run: bun test packages apps/dev scripts
 
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 61cb349c1..9e94cdb43 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -43,6 +43,9 @@ jobs:
         run: bun run stage-skills
       - run: bun run check-artifacts
       - run: bun run build
+      - run: bun run games:clone
+        env:
+          GAMES_CLONE_TOKEN: ${{ secrets.GAMES_CLONE_TOKEN }}
       - run: bun run check-types
       - run: bun test packages Games
       - name: Publish unpublished packages in dependency order
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 141b71eb4..a3e5209c4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,11 @@ between (`--json` for structured output).
 
 ## [Unreleased]
 
+### Fixed
+
+- Correct foot-IK endpoint recomputation after hip rotation; verify reachable targets and clamping without changing bone lengths.
+- Restore release CI prerequisites and make catalog-loader tests independent of the external Games checkout.
+
 <!--
 Every PR that changes `packages/*/src` records its consumer-facing change here, so
 the next release's notes are complete by construction. Add a bullet under the right
diff --git a/packages/editor/src/mcp/loadGameCatalogs.test.ts b/packages/editor/src/mcp/loadGameCatalogs.test.ts
index 731744c5b..6e7ef3e52 100644
--- a/packages/editor/src/mcp/loadGameCatalogs.test.ts
+++ b/packages/editor/src/mcp/loadGameCatalogs.test.ts
@@ -43,13 +43,15 @@ describe("loadGameCatalogs", () => {
     expect(loaded.catalogs).toEqual([]);
   });
 
-  test("tower-guard editorCatalogs export decodes with tower schema entries", async () => {
-    const loaded = await loadGameCatalogs("tower-guard");
+  test("loads an exported catalog factory with its schema and entries", async () => {
+    const loaded = await loadGameCatalogs("../packages/editor/testFixtures/catalog-game");
     expect(loaded.ok).toBe(true);
     if (!loaded.ok) throw new Error(`expected load success: ${loaded.errors.map((e) => e.message).join("; ")}`);
-    expect(loaded.catalogs.some((catalog) => catalog.id === "towers")).toBe(true);
-    const towers = loaded.catalogs.find((catalog) => catalog.id === "towers")!;
-    expect(towers.entries.length).toBeGreaterThan(0);
-    expect(towers.schema.fields.some((field) => field.key === "damage")).toBe(true);
+    expect(loaded.catalogs).toEqual([{
+      id: "towers",
+      label: "Towers",
+      schema: { fields: [{ key: "damage", type: "number", default: 1 }] },
+      entries: [{ id: "arrow", label: "Arrow tower", meta: { damage: 8 } }],
+    }]);
   });
 });
diff --git a/packages/editor/testFixtures/catalog-game/src/editorCatalogs.ts b/packages/editor/testFixtures/catalog-game/src/editorCatalogs.ts
new file mode 100644
index 000000000..00e94ec63
--- /dev/null
+++ b/packages/editor/testFixtures/catalog-game/src/editorCatalogs.ts
@@ -0,0 +1,8 @@
+export function editorCatalogs() {
+  return [{
+    id: "towers",
+    label: "Towers",
+    schema: { fields: [{ key: "damage", type: "number", default: 1 }] },
+    entries: [{ id: "arrow", label: "Arrow tower", meta: { damage: 8 } }],
+  }];
+}
diff --git a/packages/shell/src/render/useFootIk.test.ts b/packages/shell/src/render/useFootIk.test.ts
index d7e4dcdd9..578ff3a89 100644
--- a/packages/shell/src/render/useFootIk.test.ts
+++ b/packages/shell/src/render/useFootIk.test.ts
@@ -20,7 +20,10 @@ describe("applyFootIk", () => {
     expect(model.url).toContain("kaykit-adventurers");
   });
 
-  test("solves a configured foot chain against the scene raycast", () => {
+  test.each([
+    { name: "reaches a reachable terrain target", target: [0.15, 0.2, 0.1] as const },
+    { name: "clamps an unreachable terrain target to the leg length", target: [0.15, -0.2, 0] as const },
+  ])("$name without stretching either bone", ({ target }) => {
     const scene = new THREE.Object3D();
     const root = new THREE.Object3D();
     root.name = "thigh";
@@ -49,7 +52,7 @@ describe("applyFootIk", () => {
           damageEligible: false,
           blocks: true,
           distance: 0.75,
-          point: [0.15, -0.2, 0],
+          point: target,
           normal: [0.45, 0.89, 0],
         };
       },
@@ -58,7 +61,18 @@ describe("applyFootIk", () => {
 
     expect(grounded).toBe(true);
     expect(input).toMatchObject({ direction: [0, -1, 0], maxDistance: 2, filter: { terrain: true } });
-    expect(tip.getWorldPosition(new THREE.Vector3()).y).toBeCloseTo(-0.2, 3);
+    const rootPosition = root.getWorldPosition(new THREE.Vector3());
+    const midPosition = mid.getWorldPosition(new THREE.Vector3());
+    const tipPosition = tip.getWorldPosition(new THREE.Vector3());
+    const targetPosition = new THREE.Vector3(...target);
+    const direction = targetPosition.clone().sub(rootPosition);
+    const expectedTip = rootPosition.clone().add(direction.clone().normalize().multiplyScalar(Math.min(1, direction.length())));
+    expect(tipPosition.distanceTo(expectedTip)).toBeLessThan(1e-6);
+    expect(rootPosition.toArray()).toEqual([0, 1, 0]);
+    expect(rootPosition.distanceTo(midPosition)).toBeCloseTo(0.5, 6);
+    expect(midPosition.distanceTo(tipPosition)).toBeCloseTo(0.5, 6);
+    expect(mid.position.toArray()).toEqual([0, -0.5, 0]);
+    expect(tip.position.toArray()).toEqual([0, -0.5, 0]);
   });
 
   test("does not mutate a rig when the ray misses", () => {
diff --git a/packages/shell/src/render/useFootIk.ts b/packages/shell/src/render/useFootIk.ts
index 3689fe2d3..cb74ebcec 100644
--- a/packages/shell/src/render/useFootIk.ts
+++ b/packages/shell/src/render/useFootIk.ts
@@ -70,7 +70,9 @@ export function applyFootIk(
     aimSegment(root, rootPosition, midPosition, output.mid, weight);
     root.updateMatrixWorld(true);
     const solvedMid = mid.getWorldPosition(new THREE.Vector3());
-    aimSegment(mid, solvedMid, tipPosition, output.tip, weight);
+    // Rotating the root also moves the tip; aim the shin from that updated pose.
+    const currentTip = tip.getWorldPosition(new THREE.Vector3());
+    aimSegment(mid, solvedMid, currentTip, output.tip, weight);
   }
   if (config.lookAt !== undefined && cameraTarget !== undefined) {
     const bone = scene.getObjectByName(config.lookAt.bone);