From 50e75348c3bc95fcdb5c29a25281a1038e301908 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:45:41 +0000 Subject: [PATCH 01/11] Run ignition-core's integration tests with node:test Move test:integrations from Mocha to node --test with the repo's test reporter, importing describe, it and the hooks from node:test. Chai stays for now: test/setup.ts is loaded with --import so chai-as-promised is still registered. The unit tests still run on Mocha. --- packages/ignition-core/package.json | 3 ++- .../test-integrations/helpers/hardhat-projects.ts | 1 + .../test-integrations/internal/execution/jsonrpc-client.ts | 1 + .../test-integrations/test-execution-result-fixtures.ts | 1 + pnpm-lock.yaml | 3 +++ 5 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/ignition-core/package.json b/packages/ignition-core/package.json index 4b63af6579b..0388ae5c709 100644 --- a/packages/ignition-core/package.json +++ b/packages/ignition-core/package.json @@ -48,7 +48,7 @@ "test:debug": "DEBUG='ignition:*' pnpm test", "test:coverage": "nyc mocha --recursive \"test/**/*.ts\" \"test-integrations/**/*.ts\"", "test:unit": "mocha --recursive \"test/**/*.ts\"", - "test:integrations": "mocha --recursive \"test-integrations/**/*.ts\"", + "test:integrations": "node --import tsx/esm --import ./test/setup.ts --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test-integrations/*.ts\" \"test-integrations/!(fixture-projects|helpers)/**/*.ts\"", "clean": "rimraf dist", "prepack": "pnpm build" }, @@ -61,6 +61,7 @@ "devDependencies": { "@istanbuljs/nyc-config-typescript": "1.0.2", "@microsoft/api-extractor": "7.60.1", + "@nomicfoundation/hardhat-node-test-reporter": "workspace:^3.1.0", "@nomicfoundation/hardhat-test-utils": "workspace:^", "@types/chai": "^5.2.3", "@types/chai-as-promised": "^8.0.1", diff --git a/packages/ignition-core/test-integrations/helpers/hardhat-projects.ts b/packages/ignition-core/test-integrations/helpers/hardhat-projects.ts index 3099a81d81d..669c2349c08 100644 --- a/packages/ignition-core/test-integrations/helpers/hardhat-projects.ts +++ b/packages/ignition-core/test-integrations/helpers/hardhat-projects.ts @@ -1,3 +1,4 @@ +import { before, after } from "node:test"; import path from "node:path"; import { cpSync } from "node:fs"; diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index ccbd9981774..55c79eb7ae8 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -1,6 +1,7 @@ import type { HardhatRuntimeEnvironment } from "hardhat/types/hre"; import { assert } from "chai"; +import { describe, it } from "node:test"; import type { Artifact } from "../../../src/index.js"; import { diff --git a/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts b/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts index 150fad2c3ac..d347bdad7ce 100644 --- a/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts +++ b/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { encodeArtifactDeploymentData, diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 5d538fa59ad..4178f081244 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1929,6 +1929,9 @@ importers: '@microsoft/api-extractor': specifier: 7.60.1 version: 7.60.1(@types/node@22.20.5) + '@nomicfoundation/hardhat-node-test-reporter': + specifier: workspace:^3.1.0 + version: link:../hardhat-node-test-reporter '@nomicfoundation/hardhat-test-utils': specifier: workspace:^ version: link:../hardhat-test-utils From 233bcb7d130fff3c4122a9e54fdffe4ae0c68291 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:46:08 +0000 Subject: [PATCH 02/11] Run ignition-core's unit tests with node:test Move test:unit from Mocha to node --test with the repo's test reporter, importing describe, it and the hooks from node:test. Chai stays for now, with test/setup.ts loaded through --import. --- packages/ignition-core/package.json | 2 +- packages/ignition-core/test/batcher.ts | 1 + packages/ignition-core/test/build-module.ts | 1 + packages/ignition-core/test/call.ts | 1 + packages/ignition-core/test/contract.ts | 1 + packages/ignition-core/test/contractAt.ts | 1 + packages/ignition-core/test/contractAtFromArtifact.ts | 1 + packages/ignition-core/test/contractFromArtifact.ts | 1 + packages/ignition-core/test/encodeFunctionCall.ts | 1 + packages/ignition-core/test/execution/abi.ts | 1 + packages/ignition-core/test/execution/execution-engine.ts | 1 + .../future-processor/helpers/build-initialize-message-for.ts | 1 + .../future-processor/helpers/network-interaction-execution.ts | 1 + .../test/execution/future-processor/named-contract-at-deploy.ts | 1 + .../test/execution/future-processor/named-contract-deploy.ts | 1 + packages/ignition-core/test/execution/libraries.ts | 1 + .../test/execution/nonce-management/get-nonce-sync-messages.ts | 1 + .../test/execution/nonce-management/json-rpc-nonce-manager.ts | 1 + .../ignition-core/test/execution/reducers/running-a-call.ts | 1 + .../test/execution/reducers/running-a-named-contract-deploy.ts | 1 + .../test/execution/reducers/running-a-named-library-deploy.ts | 1 + .../test/execution/reducers/running-a-read-event-arg.ts | 1 + .../test/execution/reducers/running-a-static-call.ts | 1 + .../test/execution/reducers/running-contract-at.ts | 1 + .../ignition-core/test/execution/reducers/running-send-data.ts | 1 + .../ignition-core/test/execution/reducers/start-a-new-run.ts | 1 + .../test/execution/utils/convert-evm-tuple-to-solidity-param.ts | 1 + .../test/execution/views/find-result-for-future-by-id.ts | 1 + packages/ignition-core/test/getAccount.ts | 1 + packages/ignition-core/test/getParameter.ts | 1 + packages/ignition-core/test/ignition-module-serializer.ts | 1 + packages/ignition-core/test/library.ts | 1 + packages/ignition-core/test/libraryFromArtifact.ts | 1 + packages/ignition-core/test/list-transactions.ts | 1 + packages/ignition-core/test/listDeployments.ts | 1 + packages/ignition-core/test/readEventArgument.ts | 1 + .../test/reconciliation/futures/reconcileArtifactContractAt.ts | 1 + .../futures/reconcileArtifactContractDeployment.ts | 1 + .../futures/reconcileArtifactLibraryDeployment.ts | 1 + .../test/reconciliation/futures/reconcileNamedContractAt.ts | 1 + .../test/reconciliation/futures/reconcileNamedContractCall.ts | 1 + .../reconciliation/futures/reconcileNamedContractDeployment.ts | 1 + .../reconciliation/futures/reconcileNamedEncodeFunctionCall.ts | 1 + .../reconciliation/futures/reconcileNamedLibraryDeployment.ts | 1 + .../test/reconciliation/futures/reconcileNamedStaticCall.ts | 1 + .../test/reconciliation/futures/reconcileReadEventArgument.ts | 1 + .../test/reconciliation/futures/reconcileSendData.ts | 1 + packages/ignition-core/test/reconciliation/reconciler.ts | 1 + packages/ignition-core/test/send.ts | 1 + packages/ignition-core/test/staticCall.ts | 1 + packages/ignition-core/test/status.ts | 1 + packages/ignition-core/test/track-transaction.ts | 1 + packages/ignition-core/test/types/deployment-loader.ts | 1 + packages/ignition-core/test/useModule.ts | 1 + packages/ignition-core/test/utils/adjacency-list.ts | 1 + packages/ignition-core/test/utils/check-automined-network.ts | 1 + packages/ignition-core/test/utils/future-id-builders.ts | 1 + packages/ignition-core/test/utils/replace-within-arg.ts | 1 + packages/ignition-core/test/validations/id-rules.ts | 1 + .../ignition-core/test/validations/identifier-validators.ts | 1 + packages/ignition-core/test/verify.ts | 1 + packages/ignition-core/test/wipe.ts | 1 + 62 files changed, 62 insertions(+), 1 deletion(-) diff --git a/packages/ignition-core/package.json b/packages/ignition-core/package.json index 0388ae5c709..a1eb5a5edd1 100644 --- a/packages/ignition-core/package.json +++ b/packages/ignition-core/package.json @@ -47,7 +47,7 @@ "test": "pnpm test:unit && pnpm test:integrations", "test:debug": "DEBUG='ignition:*' pnpm test", "test:coverage": "nyc mocha --recursive \"test/**/*.ts\" \"test-integrations/**/*.ts\"", - "test:unit": "mocha --recursive \"test/**/*.ts\"", + "test:unit": "node --import tsx/esm --import ./test/setup.ts --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test/*.ts\" \"test/!(fixture-projects|helpers)/**/*.ts\"", "test:integrations": "node --import tsx/esm --import ./test/setup.ts --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test-integrations/*.ts\" \"test-integrations/!(fixture-projects|helpers)/**/*.ts\"", "clean": "rimraf dist", "prepack": "pnpm build" diff --git a/packages/ignition-core/test/batcher.ts b/packages/ignition-core/test/batcher.ts index 9991e3199b4..f8822a12246 100644 --- a/packages/ignition-core/test/batcher.ts +++ b/packages/ignition-core/test/batcher.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { Batcher } from "../src/internal/batcher.js"; diff --git a/packages/ignition-core/test/build-module.ts b/packages/ignition-core/test/build-module.ts index a26163c9f41..4c164884b10 100644 --- a/packages/ignition-core/test/build-module.ts +++ b/packages/ignition-core/test/build-module.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/call.ts b/packages/ignition-core/test/call.ts index 29f62ad4416..badedf9fa8a 100644 --- a/packages/ignition-core/test/call.ts +++ b/packages/ignition-core/test/call.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/contract.ts b/packages/ignition-core/test/contract.ts index 8b84abeb152..2340a9396ec 100644 --- a/packages/ignition-core/test/contract.ts +++ b/packages/ignition-core/test/contract.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/contractAt.ts b/packages/ignition-core/test/contractAt.ts index 46c2e101b2f..77fe0b1ea29 100644 --- a/packages/ignition-core/test/contractAt.ts +++ b/packages/ignition-core/test/contractAt.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { FutureType } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/contractAtFromArtifact.ts b/packages/ignition-core/test/contractAtFromArtifact.ts index 56df27db176..71e89713e88 100644 --- a/packages/ignition-core/test/contractAtFromArtifact.ts +++ b/packages/ignition-core/test/contractAtFromArtifact.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { FutureType } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/contractFromArtifact.ts b/packages/ignition-core/test/contractFromArtifact.ts index 1bd4e110262..f742018a5a7 100644 --- a/packages/ignition-core/test/contractFromArtifact.ts +++ b/packages/ignition-core/test/contractFromArtifact.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { type Artifact, FutureType } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/encodeFunctionCall.ts b/packages/ignition-core/test/encodeFunctionCall.ts index 61893e4411f..b3d0706c40a 100644 --- a/packages/ignition-core/test/encodeFunctionCall.ts +++ b/packages/ignition-core/test/encodeFunctionCall.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/execution/abi.ts b/packages/ignition-core/test/execution/abi.ts index d82a8eaa353..0dc95f1b055 100644 --- a/packages/ignition-core/test/execution/abi.ts +++ b/packages/ignition-core/test/execution/abi.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { ethers } from "ethers"; import type { Artifact } from "../../src/types/artifact.js"; diff --git a/packages/ignition-core/test/execution/execution-engine.ts b/packages/ignition-core/test/execution/execution-engine.ts index e11ae324163..7ac62067165 100644 --- a/packages/ignition-core/test/execution/execution-engine.ts +++ b/packages/ignition-core/test/execution/execution-engine.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import path from "path"; import { ExecutionEngine } from "../../src/internal/execution/execution-engine.js"; diff --git a/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts b/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts index e9182dbfec6..eb6182a1941 100644 --- a/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts +++ b/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentLoader } from "../../../../src/internal/deployment-loader/types.js"; import { buildInitializeMessageFor } from "../../../../src/internal/execution/future-processor/helpers/build-initialize-message-for.js"; diff --git a/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts b/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts index 79aea5d723d..4d7a8e845f5 100644 --- a/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts +++ b/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import { monitorOnchainInteraction } from "../../../../src/internal/execution/future-processor/handlers/monitor-onchain-interaction.js"; import { decodeSimulationResult } from "../../../../src/internal/execution/future-processor/helpers/decode-simulation-result.js"; diff --git a/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts b/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts index 8e1bd75b0b5..aa0082a436f 100644 --- a/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts +++ b/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import type { NamedArtifactContractAtFuture } from "../../../src/index.js"; import { deploymentStateReducer } from "../../../src/internal/execution/reducers/deployment-state-reducer.js"; diff --git a/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts b/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts index da8553c1d59..a14b817676f 100644 --- a/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import type { NamedArtifactContractDeploymentFuture } from "../../../src/index.js"; import type { TransactionParams } from "../../../src/internal/execution/jsonrpc-client.js"; diff --git a/packages/ignition-core/test/execution/libraries.ts b/packages/ignition-core/test/execution/libraries.ts index ae492a3ec5a..80d67eb2f23 100644 --- a/packages/ignition-core/test/execution/libraries.ts +++ b/packages/ignition-core/test/execution/libraries.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { linkLibraries, diff --git a/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts b/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts index 4fd4530a06a..5f0925e8630 100644 --- a/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts +++ b/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts @@ -4,6 +4,7 @@ import { } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import { FutureType, diff --git a/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts b/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts index 241a8154075..4ef71b1316d 100644 --- a/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts +++ b/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts @@ -3,6 +3,7 @@ import type { JsonRpcClient } from "../../../src/internal/execution/jsonrpc-clie import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { JsonRpcNonceManager } from "../../../src/internal/execution/nonce-management/json-rpc-nonce-manager.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-call.ts b/packages/ignition-core/test/execution/reducers/running-a-call.ts index e97ce769291..e721d37ac8a 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-call.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { EvmExecutionResultTypes } from "../../../src/internal/execution/types/evm-execution.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts index fdb254014c2..8e765735f75 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { EvmExecutionResultTypes } from "../../../src/internal/execution/types/evm-execution.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts index 5d20aae6d5d..03d44678a91 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts b/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts index 0859006b317..5ce8f68bdd8 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { diff --git a/packages/ignition-core/test/execution/reducers/running-a-static-call.ts b/packages/ignition-core/test/execution/reducers/running-a-static-call.ts index a94e0aaf12e..be8c6de3595 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-static-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-static-call.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { EvmExecutionResultTypes } from "../../../src/internal/execution/types/evm-execution.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-contract-at.ts b/packages/ignition-core/test/execution/reducers/running-contract-at.ts index 5f31b56b027..cc0494ac25a 100644 --- a/packages/ignition-core/test/execution/reducers/running-contract-at.ts +++ b/packages/ignition-core/test/execution/reducers/running-contract-at.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { diff --git a/packages/ignition-core/test/execution/reducers/running-send-data.ts b/packages/ignition-core/test/execution/reducers/running-send-data.ts index c465148bf24..0cb077bef3d 100644 --- a/packages/ignition-core/test/execution/reducers/running-send-data.ts +++ b/packages/ignition-core/test/execution/reducers/running-send-data.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; import { EvmExecutionResultTypes } from "../../../src/internal/execution/types/evm-execution.js"; diff --git a/packages/ignition-core/test/execution/reducers/start-a-new-run.ts b/packages/ignition-core/test/execution/reducers/start-a-new-run.ts index d74cef9aef3..5f9c637edd0 100644 --- a/packages/ignition-core/test/execution/reducers/start-a-new-run.ts +++ b/packages/ignition-core/test/execution/reducers/start-a-new-run.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import { deploymentStateReducer } from "../../../src/internal/execution/reducers/deployment-state-reducer.js"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts b/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts index 83bc18df4ae..65d05abb0d9 100644 --- a/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts +++ b/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import type { EvmTuple } from "../../../src/internal/execution/types/evm-execution.js"; import { convertEvmTupleToSolidityParam } from "../../../src/internal/execution/utils/convert-evm-tuple-to-solidity-param.js"; diff --git a/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts b/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts index 7c454d31da8..5ad39af651c 100644 --- a/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts +++ b/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; import { ExecutionSateType } from "../../../src/internal/execution/types/execution-state.js"; diff --git a/packages/ignition-core/test/getAccount.ts b/packages/ignition-core/test/getAccount.ts index cdb111692b3..aed161d96b7 100644 --- a/packages/ignition-core/test/getAccount.ts +++ b/packages/ignition-core/test/getAccount.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { AccountRuntimeValueImplementation } from "../src/internal/module.js"; diff --git a/packages/ignition-core/test/getParameter.ts b/packages/ignition-core/test/getParameter.ts index 8189c13994e..d4ceeafb4e8 100644 --- a/packages/ignition-core/test/getParameter.ts +++ b/packages/ignition-core/test/getParameter.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { ModuleParameterRuntimeValueImplementation } from "../src/internal/module.js"; diff --git a/packages/ignition-core/test/ignition-module-serializer.ts b/packages/ignition-core/test/ignition-module-serializer.ts index 6d76df3b3f8..5e719f4d887 100644 --- a/packages/ignition-core/test/ignition-module-serializer.ts +++ b/packages/ignition-core/test/ignition-module-serializer.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { diff --git a/packages/ignition-core/test/library.ts b/packages/ignition-core/test/library.ts index 54b3773c6ec..317a19edfac 100644 --- a/packages/ignition-core/test/library.ts +++ b/packages/ignition-core/test/library.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { diff --git a/packages/ignition-core/test/libraryFromArtifact.ts b/packages/ignition-core/test/libraryFromArtifact.ts index 29b6d5318d1..0ead68a111a 100644 --- a/packages/ignition-core/test/libraryFromArtifact.ts +++ b/packages/ignition-core/test/libraryFromArtifact.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { diff --git a/packages/ignition-core/test/list-transactions.ts b/packages/ignition-core/test/list-transactions.ts index 2eca1b83b6c..2b3d81b6d4c 100644 --- a/packages/ignition-core/test/list-transactions.ts +++ b/packages/ignition-core/test/list-transactions.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import path from "path"; import { diff --git a/packages/ignition-core/test/listDeployments.ts b/packages/ignition-core/test/listDeployments.ts index 22115598ccd..85ac0e51a9c 100644 --- a/packages/ignition-core/test/listDeployments.ts +++ b/packages/ignition-core/test/listDeployments.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import path from "node:path"; import { listDeployments } from "../src/index.js"; diff --git a/packages/ignition-core/test/readEventArgument.ts b/packages/ignition-core/test/readEventArgument.ts index f4bc8b50d8f..0adff3bedb8 100644 --- a/packages/ignition-core/test/readEventArgument.ts +++ b/packages/ignition-core/test/readEventArgument.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { type Artifact, diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts index 6fe1088f62f..e5b086cc649 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts index a795209f0db..3a6feb2f714 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts index a12fbe081c5..1dadf860b49 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts index 40bdff28fae..12b856ee72c 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts index 869857a4ade..1c3860ff359 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts index 559c8631f28..9098ef04c10 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts index 6e2f8480b09..2a44482f956 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts index 6bbaac860ee..5c8a8a7897c 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts index b4f61762477..f308d5f388e 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts b/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts index 0a68f10adbd..857d312764d 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts b/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts index 32335800558..738d6b777ec 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; import { diff --git a/packages/ignition-core/test/reconciliation/reconciler.ts b/packages/ignition-core/test/reconciliation/reconciler.ts index 4abf8fc187e..c75eeb44439 100644 --- a/packages/ignition-core/test/reconciliation/reconciler.ts +++ b/packages/ignition-core/test/reconciliation/reconciler.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../src/build-module.js"; import { diff --git a/packages/ignition-core/test/send.ts b/packages/ignition-core/test/send.ts index e6f4b88c603..414d21c1bb2 100644 --- a/packages/ignition-core/test/send.ts +++ b/packages/ignition-core/test/send.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; import { diff --git a/packages/ignition-core/test/staticCall.ts b/packages/ignition-core/test/staticCall.ts index ec577b85735..380e84f1a70 100644 --- a/packages/ignition-core/test/staticCall.ts +++ b/packages/ignition-core/test/staticCall.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/status.ts b/packages/ignition-core/test/status.ts index 02d7a786a2e..762c31310e5 100644 --- a/packages/ignition-core/test/status.ts +++ b/packages/ignition-core/test/status.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import path from "path"; import { status } from "../src/index.js"; diff --git a/packages/ignition-core/test/track-transaction.ts b/packages/ignition-core/test/track-transaction.ts index 8ced8c191db..a2dee8dce62 100644 --- a/packages/ignition-core/test/track-transaction.ts +++ b/packages/ignition-core/test/track-transaction.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import path from "path"; import { diff --git a/packages/ignition-core/test/types/deployment-loader.ts b/packages/ignition-core/test/types/deployment-loader.ts index ea8bfa7246d..dfbab3b46e2 100644 --- a/packages/ignition-core/test/types/deployment-loader.ts +++ b/packages/ignition-core/test/types/deployment-loader.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { EphemeralDeploymentLoader } from "../../src/internal/deployment-loader/ephemeral-deployment-loader.js"; import { FileDeploymentLoader } from "../../src/internal/deployment-loader/file-deployment-loader.js"; diff --git a/packages/ignition-core/test/useModule.ts b/packages/ignition-core/test/useModule.ts index a39048e5af9..70fb25f971a 100644 --- a/packages/ignition-core/test/useModule.ts +++ b/packages/ignition-core/test/useModule.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { type Artifact, DeploymentResultType } from "../src/index.js"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/utils/adjacency-list.ts b/packages/ignition-core/test/utils/adjacency-list.ts index 1ea7b9a1be6..d964ed552f4 100644 --- a/packages/ignition-core/test/utils/adjacency-list.ts +++ b/packages/ignition-core/test/utils/adjacency-list.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { AdjacencyList } from "../../src/internal/utils/adjacency-list.js"; diff --git a/packages/ignition-core/test/utils/check-automined-network.ts b/packages/ignition-core/test/utils/check-automined-network.ts index 5e48d13757c..6f2bbf14542 100644 --- a/packages/ignition-core/test/utils/check-automined-network.ts +++ b/packages/ignition-core/test/utils/check-automined-network.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { checkAutominedNetwork } from "../../src/internal/utils/check-automined-network.js"; import type { EIP1193Provider } from "../../src/types/provider.js"; diff --git a/packages/ignition-core/test/utils/future-id-builders.ts b/packages/ignition-core/test/utils/future-id-builders.ts index b94256778cc..ae7a86bc4d3 100644 --- a/packages/ignition-core/test/utils/future-id-builders.ts +++ b/packages/ignition-core/test/utils/future-id-builders.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { toCallFutureId, diff --git a/packages/ignition-core/test/utils/replace-within-arg.ts b/packages/ignition-core/test/utils/replace-within-arg.ts index 3bf9bcaa4df..c7c0abf7564 100644 --- a/packages/ignition-core/test/utils/replace-within-arg.ts +++ b/packages/ignition-core/test/utils/replace-within-arg.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it, beforeEach } from "node:test"; import { type ArgumentType, diff --git a/packages/ignition-core/test/validations/id-rules.ts b/packages/ignition-core/test/validations/id-rules.ts index bdaffc71ea2..669ba883c1f 100644 --- a/packages/ignition-core/test/validations/id-rules.ts +++ b/packages/ignition-core/test/validations/id-rules.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { buildModule } from "../../src/build-module.js"; import { fakeArtifact } from "../helpers.js"; diff --git a/packages/ignition-core/test/validations/identifier-validators.ts b/packages/ignition-core/test/validations/identifier-validators.ts index ed86dc27c9e..2cb4b265786 100644 --- a/packages/ignition-core/test/validations/identifier-validators.ts +++ b/packages/ignition-core/test/validations/identifier-validators.ts @@ -1,4 +1,5 @@ import { assert } from "chai"; +import { describe, it } from "node:test"; import { isValidFunctionOrEventName } from "../../src/internal/utils/identifier-validators.js"; diff --git a/packages/ignition-core/test/verify.ts b/packages/ignition-core/test/verify.ts index b2951b13cb7..9fa2b91810a 100644 --- a/packages/ignition-core/test/verify.ts +++ b/packages/ignition-core/test/verify.ts @@ -4,6 +4,7 @@ import { fileURLToPath } from "node:url"; import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import { type VerifyResult, getVerificationInformation } from "../src/index.js"; diff --git a/packages/ignition-core/test/wipe.ts b/packages/ignition-core/test/wipe.ts index 6b2f4205c6a..791fa1aac3e 100644 --- a/packages/ignition-core/test/wipe.ts +++ b/packages/ignition-core/test/wipe.ts @@ -1,6 +1,7 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; +import { describe, it } from "node:test"; import type { ArtifactResolver } from "../src/index.js"; import { EphemeralDeploymentLoader } from "../src/internal/deployment-loader/ephemeral-deployment-loader.js"; From f831244abe9da159e30eede30653d0997880b27f Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:47:31 +0000 Subject: [PATCH 03/11] Replace chai's isDefined and isUndefined in ignition-core tests assert.isDefined(x) becomes assert.notEqual(x, undefined) and assert.isUndefined(x) becomes assert.equal(x, undefined), forms that chai and node:assert share. --- .../internal/execution/jsonrpc-client.ts | 42 +++++++++---------- .../test-execution-result-fixtures.ts | 9 +++- packages/ignition-core/test/batcher.ts | 2 +- packages/ignition-core/test/call.ts | 18 ++++---- packages/ignition-core/test/contract.ts | 20 ++++----- packages/ignition-core/test/contractAt.ts | 2 +- .../test/contractAtFromArtifact.ts | 2 +- .../test/contractFromArtifact.ts | 12 +++--- .../ignition-core/test/encodeFunctionCall.ts | 10 ++--- packages/ignition-core/test/execution/abi.ts | 11 +++-- .../helpers/network-interaction-execution.ts | 6 +-- .../test/execution/reducers/running-a-call.ts | 2 +- .../running-a-named-contract-deploy.ts | 2 +- .../execution/reducers/running-send-data.ts | 2 +- packages/ignition-core/test/library.ts | 10 ++--- .../ignition-core/test/libraryFromArtifact.ts | 8 ++-- packages/ignition-core/test/send.ts | 22 +++++----- packages/ignition-core/test/staticCall.ts | 18 ++++---- .../test/types/deployment-loader.ts | 4 +- packages/ignition-core/test/wipe.ts | 8 ++-- 20 files changed, 109 insertions(+), 101 deletions(-) diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index 55c79eb7ae8..36d93f4bd4a 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -44,9 +44,9 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(tx); - assert.isDefined(receipt); + assert.notEqual(receipt, undefined); assert.equal(receipt!.status, TransactionReceiptStatus.SUCCESS); - assert.isDefined(receipt!.contractAddress); + assert.notEqual(receipt!.contractAddress, undefined); return { artifact, address: receipt!.contractAddress! }; } @@ -1153,7 +1153,7 @@ describe("JSON-RPC client", function () { const tx = await client.getTransaction(hash); - assert.isDefined(tx); + assert.notEqual(tx, undefined); assert.equal(tx!.hash, hash); assert("maxFeePerGas" in tx!.fees); @@ -1199,7 +1199,7 @@ describe("JSON-RPC client", function () { const tx = await client.getTransaction(hash); - assert.isDefined(tx); + assert.notEqual(tx, undefined); assert.equal(tx!.hash, hash); assert("maxFeePerGas" in tx!.fees); assert("maxPriorityFeePerGas" in tx!.fees); @@ -1217,7 +1217,7 @@ describe("JSON-RPC client", function () { "0x0000000000000000000000000000000000000000000000000000000000000001", ); - assert.isUndefined(tx); + assert.equal(tx, undefined); }); it("Should return undefined if the transaction was replaced by a different one", async function () { @@ -1260,7 +1260,7 @@ describe("JSON-RPC client", function () { const tx = await client.getTransaction(firstTxHash); - assert.isUndefined(tx); + assert.equal(tx, undefined); }); it("Should return undefined if the transaction was dropped", async function () { @@ -1296,7 +1296,7 @@ describe("JSON-RPC client", function () { const tx = await client.getTransaction(txHash); - assert.isUndefined(tx); + assert.equal(tx, undefined); }); }); }); @@ -1329,11 +1329,11 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(hash); - assert.isDefined(receipt); + assert.notEqual(receipt, undefined); assert.equal(receipt!.blockHash, block.hash); assert.equal(receipt!.blockNumber, block.number); assert.equal(receipt!.status, TransactionReceiptStatus.SUCCESS); - assert.isUndefined(receipt!.contractAddress); + assert.equal(receipt!.contractAddress, undefined); assert.deepEqual(receipt!.logs, []); }); @@ -1362,11 +1362,11 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(hash); - assert.isDefined(receipt); + assert.notEqual(receipt, undefined); assert.equal(receipt!.blockHash, block.hash); assert.equal(receipt!.blockNumber, block.number); assert.equal(receipt!.status, TransactionReceiptStatus.SUCCESS); - assert.isDefined(receipt!.contractAddress); + assert.notEqual(receipt!.contractAddress, undefined); assert.deepEqual(receipt!.logs, []); }); @@ -1394,11 +1394,11 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(hash); - assert.isDefined(receipt); + assert.notEqual(receipt, undefined); assert.equal(receipt!.blockHash, block.hash); assert.equal(receipt!.blockNumber, block.number); assert.equal(receipt!.status, TransactionReceiptStatus.FAILURE); - assert.isUndefined(receipt!.contractAddress); + assert.equal(receipt!.contractAddress, undefined); assert.deepEqual(receipt!.logs, []); }); @@ -1432,11 +1432,11 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(hash); - assert.isDefined(receipt); + assert.notEqual(receipt, undefined); assert.equal(receipt!.blockHash, block.hash); assert.equal(receipt!.blockNumber, block.number); assert.equal(receipt!.status, TransactionReceiptStatus.SUCCESS); - assert.isUndefined(receipt!.contractAddress); + assert.equal(receipt!.contractAddress, undefined); assert.isArray(receipt!.logs); assert.lengthOf(receipt!.logs, 2); @@ -1453,10 +1453,10 @@ describe("JSON-RPC client", function () { assert.notEqual(event0.data, "0x"); assert.notEqual(event1.data, "0x"); - assert.isDefined(event0.topics[0]); + assert.notEqual(event0.topics[0], undefined); assert.notEqual(event0.topics[0], "0x"); - assert.isDefined(event1.topics[0]); + assert.notEqual(event1.topics[0], undefined); assert.notEqual(event1.topics[0], "0x"); assert.notEqual(event0.topics[0], event1.topics[0]); @@ -1492,7 +1492,7 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(hash); - assert.isUndefined(receipt); + assert.equal(receipt, undefined); }); it("Should return undefined if the transaction was never sent", async function () { @@ -1502,7 +1502,7 @@ describe("JSON-RPC client", function () { "0x0000000000000000000000000000000000000000000000000000000000000001", ); - assert.isUndefined(receipt); + assert.equal(receipt, undefined); }); it("Should return undefined if the transaction was replaced by a different one", async function () { @@ -1545,7 +1545,7 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(firstTxHash); - assert.isUndefined(receipt); + assert.equal(receipt, undefined); }); it("Should return undefined if the transaction was dropped", async function () { @@ -1581,7 +1581,7 @@ describe("JSON-RPC client", function () { const receipt = await client.getTransactionReceipt(txHash); - assert.isUndefined(receipt); + assert.equal(receipt, undefined); }); }); }); diff --git a/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts b/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts index d347bdad7ce..faa4e4d6fe5 100644 --- a/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts +++ b/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts @@ -58,9 +58,14 @@ describe("execution-result-fixture tests", function () { }); const receipt = await client.getTransactionReceipt(tx); - assert.isDefined(receipt, `No receipt for deployment of ${name}`); - assert.isDefined( + assert.notEqual( + receipt, + undefined, + `No receipt for deployment of ${name}`, + ); + assert.notEqual( receipt!.contractAddress, + undefined, `No receipt address from deployment of ${name}`, ); diff --git a/packages/ignition-core/test/batcher.ts b/packages/ignition-core/test/batcher.ts index f8822a12246..b65fd3d5081 100644 --- a/packages/ignition-core/test/batcher.ts +++ b/packages/ignition-core/test/batcher.ts @@ -192,7 +192,7 @@ function assertBatching( }, expectedBatches: string[][], ) { - assert.isDefined(ignitionModule); + assert.notEqual(ignitionModule, undefined); const actualBatches = Batcher.batch(ignitionModule, deploymentState); diff --git a/packages/ignition-core/test/call.ts b/packages/ignition-core/test/call.ts index badedf9fa8a..905b84c2310 100644 --- a/packages/ignition-core/test/call.ts +++ b/packages/ignition-core/test/call.ts @@ -31,7 +31,7 @@ describe("call", () => { return { contract1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithASingleContract.id, "Module1"); @@ -65,7 +65,7 @@ describe("call", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -103,7 +103,7 @@ describe("call", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -136,7 +136,7 @@ describe("call", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const callFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example.test", @@ -158,7 +158,7 @@ describe("call", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const callFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example.test", @@ -183,7 +183,7 @@ describe("call", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const callFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example.test", @@ -205,7 +205,7 @@ describe("call", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const callFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example.test", @@ -404,8 +404,8 @@ describe("call", () => { ({ id }) => id === "Module1#second", ); - assert.isDefined(callFuture); - assert.isDefined(callFuture2); + assert.notEqual(callFuture, undefined); + assert.notEqual(callFuture2, undefined); }); it("should throw if the same function is called twice without differentiating ids", () => { diff --git a/packages/ignition-core/test/contract.ts b/packages/ignition-core/test/contract.ts index 2340a9396ec..367e25f76aa 100644 --- a/packages/ignition-core/test/contract.ts +++ b/packages/ignition-core/test/contract.ts @@ -31,7 +31,7 @@ describe("contract", () => { return { contract1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithASingleContract.id, "Module1"); @@ -59,7 +59,7 @@ describe("contract", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -94,7 +94,7 @@ describe("contract", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -125,7 +125,7 @@ describe("contract", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -153,7 +153,7 @@ describe("contract", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -177,7 +177,7 @@ describe("contract", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -207,7 +207,7 @@ describe("contract", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -234,7 +234,7 @@ describe("contract", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -259,7 +259,7 @@ describe("contract", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -281,7 +281,7 @@ describe("contract", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", diff --git a/packages/ignition-core/test/contractAt.ts b/packages/ignition-core/test/contractAt.ts index 77fe0b1ea29..88112080a03 100644 --- a/packages/ignition-core/test/contractAt.ts +++ b/packages/ignition-core/test/contractAt.ts @@ -26,7 +26,7 @@ describe("contractAt", () => { return { contract1 }; }); - assert.isDefined(moduleWithContractFromArtifact); + assert.notEqual(moduleWithContractFromArtifact, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithContractFromArtifact.id, "Module1"); diff --git a/packages/ignition-core/test/contractAtFromArtifact.ts b/packages/ignition-core/test/contractAtFromArtifact.ts index 71e89713e88..9bd8f65ff49 100644 --- a/packages/ignition-core/test/contractAtFromArtifact.ts +++ b/packages/ignition-core/test/contractAtFromArtifact.ts @@ -27,7 +27,7 @@ describe("contractAtFromArtifact", () => { return { contract1 }; }); - assert.isDefined(moduleWithContractFromArtifact); + assert.notEqual(moduleWithContractFromArtifact, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithContractFromArtifact.id, "Module1"); diff --git a/packages/ignition-core/test/contractFromArtifact.ts b/packages/ignition-core/test/contractFromArtifact.ts index f742018a5a7..d211dc02f08 100644 --- a/packages/ignition-core/test/contractFromArtifact.ts +++ b/packages/ignition-core/test/contractFromArtifact.ts @@ -32,7 +32,7 @@ describe("contractFromArtifact", () => { return { contract1 }; }); - assert.isDefined(moduleWithContractFromArtifact); + assert.notEqual(moduleWithContractFromArtifact, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithContractFromArtifact.id, "Module1"); @@ -106,7 +106,7 @@ describe("contractFromArtifact", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -136,7 +136,7 @@ describe("contractFromArtifact", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -160,7 +160,7 @@ describe("contractFromArtifact", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -187,7 +187,7 @@ describe("contractFromArtifact", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -211,7 +211,7 @@ describe("contractFromArtifact", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", diff --git a/packages/ignition-core/test/encodeFunctionCall.ts b/packages/ignition-core/test/encodeFunctionCall.ts index b3d0706c40a..92aedfcca05 100644 --- a/packages/ignition-core/test/encodeFunctionCall.ts +++ b/packages/ignition-core/test/encodeFunctionCall.ts @@ -31,7 +31,7 @@ describe("encodeFunctionCall", () => { return { contract1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithASingleContract.id, "Module1"); @@ -65,7 +65,7 @@ describe("encodeFunctionCall", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -105,7 +105,7 @@ describe("encodeFunctionCall", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -314,8 +314,8 @@ describe("encodeFunctionCall", () => { ({ id }) => id === "Module1#second", ); - assert.isDefined(callFuture); - assert.isDefined(callFuture2); + assert.notEqual(callFuture, undefined); + assert.notEqual(callFuture2, undefined); }); it("should throw if the same function is called twice without differentiating ids", () => { diff --git a/packages/ignition-core/test/execution/abi.ts b/packages/ignition-core/test/execution/abi.ts index 0dc95f1b055..3a3271c800b 100644 --- a/packages/ignition-core/test/execution/abi.ts +++ b/packages/ignition-core/test/execution/abi.ts @@ -232,16 +232,19 @@ describe("abi", () => { describe("decodeArtifactFunctionCallResult", () => { function decodeResult(contractName: string, functionName: string) { - assert.isDefined( + assert.notEqual( staticCallResultFixturesArtifacts[contractName], + undefined, `No artifact for ${contractName}`, ); - assert.isDefined( + assert.notEqual( staticCallResultFixtures[contractName], + undefined, `No fixtures for ${contractName}`, ); - assert.isDefined( + assert.notEqual( staticCallResultFixtures[contractName][functionName], + undefined, `No fixtures for ${contractName}.${functionName}`, ); @@ -556,7 +559,7 @@ describe("abi", () => { staticCallResultFixtures.C.revertWithUnknownCustomError.returnData, ); - assert.isUndefined(decoded); + assert.equal(decoded, undefined); }); }); diff --git a/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts b/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts index 4d7a8e845f5..e677942d5d6 100644 --- a/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts +++ b/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts @@ -199,8 +199,8 @@ describe("Network interactions", () => { assert.equal(callParams.to, staticCall.to); assert.equal(callParams.data, staticCall.data); assert.equal(callParams.value, staticCall.value); - assert.isUndefined(callParams.fees); - assert.isUndefined(callParams.nonce); + assert.equal(callParams.fees, undefined); + assert.equal(callParams.nonce, undefined); assert.equal(blockTag, "latest"); return expectedResult; @@ -293,7 +293,7 @@ describe("Network interactions", () => { return assert.fail("No message returned from monitoring"); } - assert.isDefined(message); + assert.notEqual(message, undefined); assert.equal(message.type, JournalMessageType.TRANSACTION_CONFIRM); assert.equal(message.futureId, deploymentExecutionState.id); }); diff --git a/packages/ignition-core/test/execution/reducers/running-a-call.ts b/packages/ignition-core/test/execution/reducers/running-a-call.ts index e721d37ac8a..3f75b4986a4 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-call.ts @@ -229,7 +229,7 @@ describe("DeploymentStateReducer", () => { assert.isArray(transactions); assert.lengthOf(transactions, 0); assert.isFalse(shouldBeResent); - assert.isUndefined(nonce); + assert.equal(nonce, undefined); }); }); diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts index 8e765735f75..bcecdefeaf3 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts @@ -235,7 +235,7 @@ describe("DeploymentStateReducer", () => { assert.isArray(transactions); assert.lengthOf(transactions, 0); assert.isFalse(shouldBeResent); - assert.isUndefined(nonce); + assert.equal(nonce, undefined); }); }); diff --git a/packages/ignition-core/test/execution/reducers/running-send-data.ts b/packages/ignition-core/test/execution/reducers/running-send-data.ts index 0cb077bef3d..0e7bb1d7b60 100644 --- a/packages/ignition-core/test/execution/reducers/running-send-data.ts +++ b/packages/ignition-core/test/execution/reducers/running-send-data.ts @@ -217,7 +217,7 @@ describe("DeploymentStateReducer", () => { assert.isArray(transactions); assert.lengthOf(transactions, 0); assert.isFalse(shouldBeResent); - assert.isUndefined(nonce); + assert.equal(nonce, undefined); }); }); diff --git a/packages/ignition-core/test/library.ts b/packages/ignition-core/test/library.ts index 317a19edfac..36721c52e7f 100644 --- a/packages/ignition-core/test/library.ts +++ b/packages/ignition-core/test/library.ts @@ -26,7 +26,7 @@ describe("library", () => { return { library1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); // Sets ids based on module id and library name assert.equal(moduleWithASingleContract.id, "Module1"); @@ -59,7 +59,7 @@ describe("library", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -90,7 +90,7 @@ describe("library", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -120,7 +120,7 @@ describe("library", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -144,7 +144,7 @@ describe("library", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", diff --git a/packages/ignition-core/test/libraryFromArtifact.ts b/packages/ignition-core/test/libraryFromArtifact.ts index 0ead68a111a..90a0e7b7410 100644 --- a/packages/ignition-core/test/libraryFromArtifact.ts +++ b/packages/ignition-core/test/libraryFromArtifact.ts @@ -26,7 +26,7 @@ describe("libraryFromArtifact", () => { return { library1 }; }); - assert.isDefined(moduleWithContractFromArtifact); + assert.notEqual(moduleWithContractFromArtifact, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithContractFromArtifact.id, "Module1"); @@ -77,7 +77,7 @@ describe("libraryFromArtifact", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -107,7 +107,7 @@ describe("libraryFromArtifact", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", @@ -131,7 +131,7 @@ describe("libraryFromArtifact", () => { return { another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const anotherFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Another", diff --git a/packages/ignition-core/test/send.ts b/packages/ignition-core/test/send.ts index 414d21c1bb2..110bc08c3a4 100644 --- a/packages/ignition-core/test/send.ts +++ b/packages/ignition-core/test/send.ts @@ -31,7 +31,7 @@ describe("send", () => { return {}; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); // 1 contract future & 1 call future assert.equal(moduleWithASingleContract.futures.size, 1); @@ -62,7 +62,7 @@ describe("send", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -95,7 +95,7 @@ describe("send", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -121,7 +121,7 @@ describe("send", () => { return {}; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const sendFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#test_send", @@ -141,7 +141,7 @@ describe("send", () => { return {}; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const sendFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#test_send", @@ -164,7 +164,7 @@ describe("send", () => { return {}; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const sendFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#test_send", @@ -184,7 +184,7 @@ describe("send", () => { return {}; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const sendFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#test_send", @@ -205,7 +205,7 @@ describe("send", () => { return {}; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const sendFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#test_send", @@ -256,7 +256,7 @@ describe("send", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#encodeFunctionCall(Module1#Example.test)", @@ -299,8 +299,8 @@ describe("send", () => { ({ id }) => id === "Module1#second", ); - assert.isDefined(sendFuture); - assert.isDefined(sendFuture2); + assert.notEqual(sendFuture, undefined); + assert.notEqual(sendFuture2, undefined); }); it("should throw if the same function is called twice without differentiating ids", () => { diff --git a/packages/ignition-core/test/staticCall.ts b/packages/ignition-core/test/staticCall.ts index 380e84f1a70..1cb0357b137 100644 --- a/packages/ignition-core/test/staticCall.ts +++ b/packages/ignition-core/test/staticCall.ts @@ -32,7 +32,7 @@ describe("static call", () => { return { contract1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); // Sets ids based on module id and contract name assert.equal(moduleWithASingleContract.id, "Module1"); @@ -66,7 +66,7 @@ describe("static call", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -104,7 +104,7 @@ describe("static call", () => { return { example, another }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const exampleFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example", @@ -139,7 +139,7 @@ describe("static call", () => { return { contract1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); const staticCallFuture = [...moduleWithASingleContract.futures].find( ({ id }) => id === "Module1#Contract1.test", @@ -167,7 +167,7 @@ describe("static call", () => { return { contract1 }; }); - assert.isDefined(moduleWithASingleContract); + assert.notEqual(moduleWithASingleContract, undefined); const staticCallFuture = [...moduleWithASingleContract.futures].find( ({ id }) => id === "Module1#Contract1.test", @@ -198,7 +198,7 @@ describe("static call", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const callFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example.test", @@ -220,7 +220,7 @@ describe("static call", () => { return { example }; }); - assert.isDefined(moduleWithDependentContracts); + assert.notEqual(moduleWithDependentContracts, undefined); const callFuture = [...moduleWithDependentContracts.futures].find( ({ id }) => id === "Module1#Example.test", @@ -419,8 +419,8 @@ describe("static call", () => { ({ id }) => id === "Module1#second", ); - assert.isDefined(callFuture); - assert.isDefined(callFuture2); + assert.notEqual(callFuture, undefined); + assert.notEqual(callFuture2, undefined); }); it("should throw if the same function is statically called twice without differentiating ids", () => { diff --git a/packages/ignition-core/test/types/deployment-loader.ts b/packages/ignition-core/test/types/deployment-loader.ts index dfbab3b46e2..50737fa2e17 100644 --- a/packages/ignition-core/test/types/deployment-loader.ts +++ b/packages/ignition-core/test/types/deployment-loader.ts @@ -17,7 +17,7 @@ describe("DeploymentLoaderImpls", function () { Omit > = new FileDeploymentLoader("./example"); - assert.isDefined(_implementation); + assert.notEqual(_implementation, undefined); }); }); @@ -28,7 +28,7 @@ describe("DeploymentLoaderImpls", function () { EphemeralDeploymentLoader > = new EphemeralDeploymentLoader(setupMockArtifactResolver()); - assert.isDefined(_implementation); + assert.notEqual(_implementation, undefined); }); }); }); diff --git a/packages/ignition-core/test/wipe.ts b/packages/ignition-core/test/wipe.ts index 791fa1aac3e..ba20ebdda45 100644 --- a/packages/ignition-core/test/wipe.ts +++ b/packages/ignition-core/test/wipe.ts @@ -75,13 +75,13 @@ describe("wipe", () => { deploymentLoader, ); - assert.isDefined(deploymentState.executionStates[contract1Id]); + assert.notEqual(deploymentState.executionStates[contract1Id], undefined); const wiper = new Wiper(deploymentLoader); deploymentState = await wiper.wipe(contract1Id); - assert.isUndefined(deploymentState.executionStates[contract1Id]); + assert.equal(deploymentState.executionStates[contract1Id], undefined); }); it("should error if the deployment hasn't been initialized", async () => { @@ -138,8 +138,8 @@ describe("wipe", () => { deploymentLoader, ); - assert.isDefined(deploymentState.executionStates[contract1Id]); - assert.isDefined(deploymentState.executionStates[contract2Id]); + assert.notEqual(deploymentState.executionStates[contract1Id], undefined); + assert.notEqual(deploymentState.executionStates[contract2Id], undefined); const wiper = new Wiper(deploymentLoader); From 8f250954dea19cd9b2f697070d01d6ce16f79e20 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:47:44 +0000 Subject: [PATCH 04/11] Replace chai's isTrue and isFalse in ignition-core tests assert.isTrue(x) becomes assert.equal(x, true) and assert.isFalse(x) becomes assert.equal(x, false). --- .../internal/execution/jsonrpc-client.ts | 46 +++++++++---------- packages/ignition-core/test/execution/abi.ts | 5 +- .../test/execution/reducers/running-a-call.ts | 2 +- .../running-a-named-contract-deploy.ts | 2 +- .../execution/reducers/running-send-data.ts | 2 +- .../test/utils/check-automined-network.ts | 12 +++-- .../test/validations/identifier-validators.ts | 43 +++++++++-------- packages/ignition-core/test/verify.ts | 4 +- 8 files changed, 63 insertions(+), 53 deletions(-) diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index 36d93f4bd4a..9dc7a19b5a1 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -92,7 +92,7 @@ describe("JSON-RPC client", function () { assert.typeOf(fees.maxFeePerGas, "bigint"); assert.typeOf(fees.maxPriorityFeePerGas, "bigint"); - assert.isTrue(fees.maxFeePerGas > fees.maxPriorityFeePerGas); + assert.equal(fees.maxFeePerGas > fees.maxPriorityFeePerGas, true); }); it('Should throw if the "maxFeePerGas" exceeds the configured limit', async function () { @@ -337,9 +337,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isTrue(result.success); + assert.equal(result.success, true); assert.notEqual(result.returnData, "0x"); - assert.isFalse(result.customErrorReported); + assert.equal(result.customErrorReported, false); }); it("Should return the raw result in successful non-deployment calls", async function () { @@ -370,9 +370,9 @@ describe("JSON-RPC client", function () { const abiEncodedHello = "0x0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000568656c6c6f000000000000000000000000000000000000000000000000000000"; - assert.isTrue(result.success); + assert.equal(result.success, true); assert.equal(result.returnData, abiEncodedHello); - assert.isFalse(result.customErrorReported); + assert.equal(result.customErrorReported, false); }); it("Should not throw on execution failures, but return a result", async function () { @@ -393,9 +393,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isFalse(result.success); + assert.equal(result.success, false); assert.equal(result.returnData, "0x"); - assert.isFalse(result.customErrorReported); + assert.equal(result.customErrorReported, false); }); it("Should return the returnData on execution failures", async function () { @@ -430,9 +430,9 @@ describe("JSON-RPC client", function () { const abiEncodedHello = "0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000006726561736f6e0000000000000000000000000000000000000000000000000000"; - assert.isFalse(result.success); + assert.equal(result.success, false); assert.equal(result.returnData, abiEncodedHello); - assert.isFalse(result.customErrorReported); + assert.equal(result.customErrorReported, false); }); it("[Geth specific] Should return an empty returnData even when geth doesn't return it", async function () { @@ -478,9 +478,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isFalse(result1.success); + assert.equal(result1.success, false); assert.equal(result1.returnData, "0x"); - assert.isFalse(result1.customErrorReported); + assert.equal(result1.customErrorReported, false); const result2 = await mockClient.call( { @@ -491,9 +491,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isFalse(result2.success); + assert.equal(result2.success, false); assert.equal(result2.returnData, "0x"); - assert.isFalse(result2.customErrorReported); + assert.equal(result2.customErrorReported, false); }); it("[Other nodes] Should return an empty returnData if the error message indicates a revert", async function () { @@ -528,9 +528,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isFalse(result1.success); + assert.equal(result1.success, false); assert.equal(result1.returnData, "0x"); - assert.isFalse(result1.customErrorReported); + assert.equal(result1.customErrorReported, false); }); it("Should rethrow an HardhatError if the error message indicates an incorrectly configured base gas fee versus the node's block gas limit", async function () { @@ -597,9 +597,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isFalse(result.success); + assert.equal(result.success, false); assert.notEqual(result.returnData, "0x"); - assert.isTrue(result.customErrorReported); + assert.equal(result.customErrorReported, true); }); it("Should return customErrorReported false when the server does not reports a custom error", async function () { @@ -630,9 +630,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isFalse(result.success); + assert.equal(result.success, false); assert.notEqual(result.returnData, "0x"); - assert.isFalse(result.customErrorReported); + assert.equal(result.customErrorReported, false); }); it("Should accept pending as blockTag", async function () { @@ -679,9 +679,9 @@ describe("JSON-RPC client", function () { "latest", ); - assert.isTrue(resultLatest.success); + assert.equal(resultLatest.success, true); assert.equal(resultLatest.returnData, "0x"); - assert.isFalse(resultLatest.customErrorReported); + assert.equal(resultLatest.customErrorReported, false); const resultPending = await client.call( { @@ -697,9 +697,9 @@ describe("JSON-RPC client", function () { "pending", ); - assert.isFalse(resultPending.success); + assert.equal(resultPending.success, false); assert.notEqual(resultPending.returnData, "0x"); - assert.isFalse(resultPending.customErrorReported); + assert.equal(resultPending.customErrorReported, false); }); // TODO: Should we test that eth_call validates the account balance? diff --git a/packages/ignition-core/test/execution/abi.ts b/packages/ignition-core/test/execution/abi.ts index 3a3271c800b..7cdc15be708 100644 --- a/packages/ignition-core/test/execution/abi.ts +++ b/packages/ignition-core/test/execution/abi.ts @@ -449,7 +449,10 @@ describe("abi", () => { const encoded = encodeArtifactDeploymentData(artifact, [], libraries); assert.notEqual(encoded, artifact.bytecode); - assert.isTrue(encoded.startsWith(linkLibraries(artifact, libraries))); + assert.equal( + encoded.startsWith(linkLibraries(artifact, libraries)), + true, + ); }); // TODO: Validate that we throw a nice error in these cases diff --git a/packages/ignition-core/test/execution/reducers/running-a-call.ts b/packages/ignition-core/test/execution/reducers/running-a-call.ts index 3f75b4986a4..92600499e28 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-call.ts @@ -228,7 +228,7 @@ describe("DeploymentStateReducer", () => { ); assert.isArray(transactions); assert.lengthOf(transactions, 0); - assert.isFalse(shouldBeResent); + assert.equal(shouldBeResent, false); assert.equal(nonce, undefined); }); }); diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts index bcecdefeaf3..803d9b9ee57 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts @@ -234,7 +234,7 @@ describe("DeploymentStateReducer", () => { ); assert.isArray(transactions); assert.lengthOf(transactions, 0); - assert.isFalse(shouldBeResent); + assert.equal(shouldBeResent, false); assert.equal(nonce, undefined); }); }); diff --git a/packages/ignition-core/test/execution/reducers/running-send-data.ts b/packages/ignition-core/test/execution/reducers/running-send-data.ts index 0e7bb1d7b60..d2537382eac 100644 --- a/packages/ignition-core/test/execution/reducers/running-send-data.ts +++ b/packages/ignition-core/test/execution/reducers/running-send-data.ts @@ -216,7 +216,7 @@ describe("DeploymentStateReducer", () => { ); assert.isArray(transactions); assert.lengthOf(transactions, 0); - assert.isFalse(shouldBeResent); + assert.equal(shouldBeResent, false); assert.equal(nonce, undefined); }); }); diff --git a/packages/ignition-core/test/utils/check-automined-network.ts b/packages/ignition-core/test/utils/check-automined-network.ts index 6f2bbf14542..861bceb99a9 100644 --- a/packages/ignition-core/test/utils/check-automined-network.ts +++ b/packages/ignition-core/test/utils/check-automined-network.ts @@ -6,26 +6,30 @@ import type { EIP1193Provider } from "../../src/types/provider.js"; describe("check-automin-network", () => { it("should confirm a Hardhat network that has automining enabled", async () => - assert.isTrue( + assert.equal( await checkAutominedNetwork(setupMockProvider("hardhat", true)), + true, "Hardhat network should have automining enabled", )); it("should indicate a Hardhat network that has automining disabled", async () => - assert.isFalse( + assert.equal( await checkAutominedNetwork(setupMockProvider("hardhat", false)), + false, "Hardhat network should _not_ have automining enabled", )); it("should confirm a ganache network", async () => - assert.isTrue( + assert.equal( await checkAutominedNetwork(setupMockProvider("ganache")), + true, "Ganache networks should have automining enabled", )); it("should indicate not an automining network for other networks", async () => - assert.isFalse( + assert.equal( await checkAutominedNetwork(setupMockProvider("other")), + false, "Other network should _not_ have automining enabled", )); }); diff --git a/packages/ignition-core/test/validations/identifier-validators.ts b/packages/ignition-core/test/validations/identifier-validators.ts index 2cb4b265786..a6898a271a0 100644 --- a/packages/ignition-core/test/validations/identifier-validators.ts +++ b/packages/ignition-core/test/validations/identifier-validators.ts @@ -5,28 +5,31 @@ import { isValidFunctionOrEventName } from "../../src/internal/utils/identifier- describe("isValidFunctionOrEventName", () => { it("should return true for valid solidity function names", () => { - assert.isTrue(isValidFunctionOrEventName("a")); - assert.isTrue(isValidFunctionOrEventName("aa")); - assert.isTrue(isValidFunctionOrEventName("a1")); - assert.isTrue(isValidFunctionOrEventName("myFunction")); - assert.isTrue(isValidFunctionOrEventName("myFunction()")); - assert.isTrue(isValidFunctionOrEventName("myFunction123()")); - assert.isTrue(isValidFunctionOrEventName("myFunction(uint256)")); - assert.isTrue(isValidFunctionOrEventName("myFunction(uint256)")); - assert.isTrue(isValidFunctionOrEventName("myFunction(uint256,bool)")); - assert.isTrue(isValidFunctionOrEventName("myFunction(uint256[])")); - assert.isTrue(isValidFunctionOrEventName("myFunction(uint256[],bool)")); + assert.equal(isValidFunctionOrEventName("a"), true); + assert.equal(isValidFunctionOrEventName("aa"), true); + assert.equal(isValidFunctionOrEventName("a1"), true); + assert.equal(isValidFunctionOrEventName("myFunction"), true); + assert.equal(isValidFunctionOrEventName("myFunction()"), true); + assert.equal(isValidFunctionOrEventName("myFunction123()"), true); + assert.equal(isValidFunctionOrEventName("myFunction(uint256)"), true); + assert.equal(isValidFunctionOrEventName("myFunction(uint256)"), true); + assert.equal(isValidFunctionOrEventName("myFunction(uint256,bool)"), true); + assert.equal(isValidFunctionOrEventName("myFunction(uint256[])"), true); + assert.equal( + isValidFunctionOrEventName("myFunction(uint256[],bool)"), + true, + ); }); it("should return false for invalid solidity function names", () => { - assert.isFalse(isValidFunctionOrEventName("1")); - assert.isFalse(isValidFunctionOrEventName("11")); - assert.isFalse(isValidFunctionOrEventName("123myFunction")); - assert.isFalse(isValidFunctionOrEventName("myFunction(")); - assert.isFalse(isValidFunctionOrEventName("myFunction(uint)256")); - assert.isFalse(isValidFunctionOrEventName("myFunction(uint256")); - assert.isFalse(isValidFunctionOrEventName("myFunctionuint256)")); - assert.isFalse(isValidFunctionOrEventName("(uint256)")); - assert.isFalse(isValidFunctionOrEventName("123(uint256)")); + assert.equal(isValidFunctionOrEventName("1"), false); + assert.equal(isValidFunctionOrEventName("11"), false); + assert.equal(isValidFunctionOrEventName("123myFunction"), false); + assert.equal(isValidFunctionOrEventName("myFunction("), false); + assert.equal(isValidFunctionOrEventName("myFunction(uint)256"), false); + assert.equal(isValidFunctionOrEventName("myFunction(uint256"), false); + assert.equal(isValidFunctionOrEventName("myFunctionuint256)"), false); + assert.equal(isValidFunctionOrEventName("(uint256)"), false); + assert.equal(isValidFunctionOrEventName("123(uint256)"), false); }); }); diff --git a/packages/ignition-core/test/verify.ts b/packages/ignition-core/test/verify.ts index 9fa2b91810a..c23f4ef7ce8 100644 --- a/packages/ignition-core/test/verify.ts +++ b/packages/ignition-core/test/verify.ts @@ -109,7 +109,7 @@ describe("verify", () => { sawLibrary = true; } } - assert.isTrue(sawLibrary, "Expected to find the UUUUU library entry"); + assert.equal(sawLibrary, true, "Expected to find the UUUUU library entry"); }); it("should yield a verify result for contract with libraries", async () => { @@ -130,6 +130,6 @@ describe("verify", () => { } } - assert.isTrue(success); + assert.equal(success, true); }); }); From 2de6046409ad196f3a587af554d3bc698a8833a4 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:48:00 +0000 Subject: [PATCH 05/11] Replace chai's type assertions in ignition-core tests isString and typeOf become a typeof comparison, isArray becomes assert.ok(Array.isArray(x)), lengthOf compares .length, and instanceOf becomes assert.ok(x instanceof C). --- .../internal/execution/jsonrpc-client.ts | 22 +++++++++---------- .../test/execution/reducers/running-a-call.ts | 4 ++-- .../running-a-named-contract-deploy.ts | 4 ++-- .../execution/reducers/running-send-data.ts | 4 ++-- packages/ignition-core/test/helpers.ts | 2 +- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index 9dc7a19b5a1..2b269004b0a 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -66,8 +66,8 @@ describe("JSON-RPC client", function () { const block = await client.getLatestBlock(); assert.equal(block.number, 0); - assert.isString(block.hash); - assert.typeOf(block.baseFeePerGas, "bigint"); + assert.equal(typeof block.hash, "string"); + assert.equal(typeof block.baseFeePerGas, "bigint"); }); it("Should return the second block in the correct format", async function () { @@ -76,8 +76,8 @@ describe("JSON-RPC client", function () { const block = await client.getLatestBlock(); assert.equal(block.number, 1); - assert.isString(block.hash); - assert.typeOf(block.baseFeePerGas, "bigint"); + assert.equal(typeof block.hash, "string"); + assert.equal(typeof block.baseFeePerGas, "bigint"); }); }); @@ -90,8 +90,8 @@ describe("JSON-RPC client", function () { assert("maxFeePerGas" in fees); assert("maxPriorityFeePerGas" in fees); - assert.typeOf(fees.maxFeePerGas, "bigint"); - assert.typeOf(fees.maxPriorityFeePerGas, "bigint"); + assert.equal(typeof fees.maxFeePerGas, "bigint"); + assert.equal(typeof fees.maxPriorityFeePerGas, "bigint"); assert.equal(fees.maxFeePerGas > fees.maxPriorityFeePerGas, true); }); @@ -727,7 +727,7 @@ describe("JSON-RPC client", function () { fees, }); - assert.isString(result); + assert.equal(typeof result, "string"); }); it("Should return the tx hash in a network without automining", async function () { @@ -755,7 +755,7 @@ describe("JSON-RPC client", function () { fees, }); - assert.isString(result); + assert.equal(typeof result, "string"); }); }); @@ -1438,8 +1438,8 @@ describe("JSON-RPC client", function () { assert.equal(receipt!.status, TransactionReceiptStatus.SUCCESS); assert.equal(receipt!.contractAddress, undefined); - assert.isArray(receipt!.logs); - assert.lengthOf(receipt!.logs, 2); + assert.ok(Array.isArray(receipt!.logs)); + assert.equal(receipt!.logs.length, 2); const event0 = receipt!.logs[0]; const event1 = receipt!.logs[1]; @@ -1613,7 +1613,7 @@ describe("JSON-RPC client", function () { }, }); - assert.isString(result); + assert.equal(typeof result, "string"); }); }); }); diff --git a/packages/ignition-core/test/execution/reducers/running-a-call.ts b/packages/ignition-core/test/execution/reducers/running-a-call.ts index 92600499e28..798aaeb6790 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-call.ts @@ -226,8 +226,8 @@ describe("DeploymentStateReducer", () => { rest, requestNetworkInteractionMessage.networkInteraction, ); - assert.isArray(transactions); - assert.lengthOf(transactions, 0); + assert.ok(Array.isArray(transactions)); + assert.equal(transactions.length, 0); assert.equal(shouldBeResent, false); assert.equal(nonce, undefined); }); diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts index 803d9b9ee57..b0e58690319 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts @@ -232,8 +232,8 @@ describe("DeploymentStateReducer", () => { rest, requestNetworkInteractionMessage.networkInteraction, ); - assert.isArray(transactions); - assert.lengthOf(transactions, 0); + assert.ok(Array.isArray(transactions)); + assert.equal(transactions.length, 0); assert.equal(shouldBeResent, false); assert.equal(nonce, undefined); }); diff --git a/packages/ignition-core/test/execution/reducers/running-send-data.ts b/packages/ignition-core/test/execution/reducers/running-send-data.ts index d2537382eac..6171cd9c804 100644 --- a/packages/ignition-core/test/execution/reducers/running-send-data.ts +++ b/packages/ignition-core/test/execution/reducers/running-send-data.ts @@ -214,8 +214,8 @@ describe("DeploymentStateReducer", () => { rest, requestNetworkInteractionMessage.networkInteraction, ); - assert.isArray(transactions); - assert.lengthOf(transactions, 0); + assert.ok(Array.isArray(transactions)); + assert.equal(transactions.length, 0); assert.equal(shouldBeResent, false); assert.equal(nonce, undefined); }); diff --git a/packages/ignition-core/test/helpers.ts b/packages/ignition-core/test/helpers.ts index b891b3d5596..4476814eb80 100644 --- a/packages/ignition-core/test/helpers.ts +++ b/packages/ignition-core/test/helpers.ts @@ -26,7 +26,7 @@ export function assertInstanceOf( obj: unknown, klass: new (...args: any[]) => ObjectT, ): asserts obj is ObjectT { - assert.instanceOf(obj, klass, `Not a valid instance of ${klass.name}`); + assert.ok(obj instanceof klass, `Not a valid instance of ${klass.name}`); } export const fakeArtifact: Artifact = { From 6583ee4624651169713943733fe2333255d43bbe Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:48:24 +0000 Subject: [PATCH 06/11] Replace chai's include assertions in ignition-core tests include and notInclude become assert.ok over .includes(), and the one includeMembers, with a single member, becomes the same. --- .../ignition-core/test/execution/libraries.ts | 16 ++++++++-------- packages/ignition-core/test/helpers.ts | 5 +---- packages/ignition-core/test/readEventArgument.ts | 8 ++++---- packages/ignition-core/test/verify.ts | 5 ++--- 4 files changed, 15 insertions(+), 19 deletions(-) diff --git a/packages/ignition-core/test/execution/libraries.ts b/packages/ignition-core/test/execution/libraries.ts index 80d67eb2f23..3f5cfa07652 100644 --- a/packages/ignition-core/test/execution/libraries.ts +++ b/packages/ignition-core/test/execution/libraries.ts @@ -37,9 +37,9 @@ describe("Libraries handling", () => { ).map((e) => e.message); assert(error !== undefined); - assert.include(error, `The name "Lib" is ambiguous`); - assert.include(error, `contracts/C.sol:Lib`); - assert.include(error, `contracts/Libs.sol:Lib`); + assert.ok(error.includes(`The name "Lib" is ambiguous`)); + assert.ok(error.includes(`contracts/C.sol:Lib`)); + assert.ok(error.includes(`contracts/Libs.sol:Lib`)); }); it("Should throw if a library is missing", () => { @@ -49,8 +49,8 @@ describe("Libraries handling", () => { ).map((e) => e.message); assert(error !== undefined); - assert.include(error, `The following libraries are missing:`); - assert.include(error, `contracts/C.sol:Lib`); + assert.ok(error.includes(`The following libraries are missing:`)); + assert.ok(error.includes(`contracts/C.sol:Lib`)); }); it("Should throw if a name is used twice, as FQN and bare name", () => { @@ -105,8 +105,8 @@ describe("Libraries handling", () => { ); // We don't really validate if they were linked correctly here - assert.include(linkedBytecode, mockAddress.slice(2)); - assert.include(linkedBytecode, mockAddress2.slice(2)); + assert.ok(linkedBytecode.includes(mockAddress.slice(2))); + assert.ok(linkedBytecode.includes(mockAddress2.slice(2))); }); it("Should link by bare name", () => { @@ -117,7 +117,7 @@ describe("Libraries handling", () => { }, ); - assert.include(linkedBytecode, mockAddress.slice(2)); + assert.ok(linkedBytecode.includes(mockAddress.slice(2))); const firstRef = deploymentFixturesArtifacts.WithLibrary.linkReferences[ diff --git a/packages/ignition-core/test/helpers.ts b/packages/ignition-core/test/helpers.ts index 4476814eb80..b71aecb4a15 100644 --- a/packages/ignition-core/test/helpers.ts +++ b/packages/ignition-core/test/helpers.ts @@ -16,10 +16,7 @@ export function assertValidationError( errors: string[], expectedError: string, ): void { - assert.includeMembers( - errors.map((e) => e.split(/^\w+\d+: /)[1]), - [expectedError], - ); + assert.ok(errors.map((e) => e.split(/^\w+\d+: /)[1]).includes(expectedError)); } export function assertInstanceOf( diff --git a/packages/ignition-core/test/readEventArgument.ts b/packages/ignition-core/test/readEventArgument.ts index 0adff3bedb8..0b59bbd6976 100644 --- a/packages/ignition-core/test/readEventArgument.ts +++ b/packages/ignition-core/test/readEventArgument.ts @@ -167,8 +167,8 @@ describe("Read event argument", () => { assert.equal(mod.id, "Module1"); const futuresIds = Array.from(mod.futures).map((f) => f.id); - assert.include(futuresIds, "Module1#Main.EventName.arg1.0"); - assert.include(futuresIds, "Module1#Emitter.EventName2.arg2.1"); + assert.ok(futuresIds.includes("Module1#Main.EventName.arg1.0")); + assert.ok(futuresIds.includes("Module1#Emitter.EventName2.arg2.1")); }); it("should be able to read the same argument twice by passing a explicit id", () => { @@ -191,8 +191,8 @@ describe("Read event argument", () => { moduleWithSameReadEventArgumentTwice.futures, ).map((f) => f.id); - assert.include(futuresIds, "Module1#Example.EventName.arg1.0"); - assert.include(futuresIds, "Module1#second"); + assert.ok(futuresIds.includes("Module1#Example.EventName.arg1.0")); + assert.ok(futuresIds.includes("Module1#second")); }); it("should throw if the same read event argument is done twice without differentiating ids", () => { diff --git a/packages/ignition-core/test/verify.ts b/packages/ignition-core/test/verify.ts index c23f4ef7ce8..f276cf91d27 100644 --- a/packages/ignition-core/test/verify.ts +++ b/packages/ignition-core/test/verify.ts @@ -99,9 +99,8 @@ describe("verify", () => { for await (const info of getVerificationInformation(deploymentDir)) { // Note: the library in this test is called UUUUU assert(typeof info !== "string", "Expected a VerifyInfo, got a string"); - assert.notInclude( - info.contract, - "contracts/Lib.sol:contracts/Lib.sol:", + assert.ok( + !info.contract.includes("contracts/Lib.sol:contracts/Lib.sol:"), "Source name should not be duplicated in the contract FQN", ); if (info.contract.endsWith(":UUUUU")) { From 05f933172dbd2985f934472ec1736e1a9cd66227 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:49:06 +0000 Subject: [PATCH 07/11] Replace chai-as-promised and chai's throws in ignition-core tests isFulfilled(p) becomes a plain await of p. isRejected and throws become hardhat-test-utils' assertRejects and assertThrows, checking the error message against the same regex or substring. --- .../internal/execution/jsonrpc-client.ts | 17 ++++--- packages/ignition-core/test/build-module.ts | 9 ++-- packages/ignition-core/test/call.ts | 36 +++++++-------- packages/ignition-core/test/contract.ts | 36 +++++++-------- .../test/contractFromArtifact.ts | 36 +++++++-------- .../ignition-core/test/encodeFunctionCall.ts | 24 +++++----- packages/ignition-core/test/execution/abi.ts | 17 +++++-- packages/ignition-core/test/staticCall.ts | 44 ++++++++++--------- packages/ignition-core/test/useModule.ts | 20 ++++----- 9 files changed, 118 insertions(+), 121 deletions(-) diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index 2b269004b0a..d0b77fc6149 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -1,5 +1,6 @@ import type { HardhatRuntimeEnvironment } from "hardhat/types/hre"; +import { assertRejects } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; @@ -100,9 +101,10 @@ describe("JSON-RPC client", function () { maxFeePerGasLimit: 1n, }); - await assert.isRejected( - failClient.getNetworkFees(), - /HHE10406: The calculated max fee per gas exceeds the configured limit./, + await assertRejects(failClient.getNetworkFees(), (e) => + /HHE10406: The calculated max fee per gas exceeds the configured limit./.test( + e.message, + ), ); }); @@ -556,7 +558,7 @@ describe("JSON-RPC client", function () { params: [], }); - await assert.isRejected( + await assertRejects( mockClient.call( { data: "0x", @@ -565,7 +567,10 @@ describe("JSON-RPC client", function () { }, "latest", ), - /HHE10405\: The configured base fee exceeds the block gas limit\. Please reduce the configured base fee or increase the block gas limit\./, + (e) => + /HHE10405\: The configured base fee exceeds the block gas limit\. Please reduce the configured base fee or increase the block gas limit\./.test( + e.message, + ), ); }); @@ -938,7 +943,7 @@ describe("JSON-RPC client", function () { accounts, }); - await assert.isRejected( + await assertRejects( client.estimateGas({ to: address, from: accounts[0], diff --git a/packages/ignition-core/test/build-module.ts b/packages/ignition-core/test/build-module.ts index 4c164884b10..f84094f57a8 100644 --- a/packages/ignition-core/test/build-module.ts +++ b/packages/ignition-core/test/build-module.ts @@ -1,5 +1,8 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; -import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; +import { + assertThrows, + assertThrowsHardhatError, +} from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; @@ -18,12 +21,12 @@ describe("buildModule", () => { }); it("should error on module throwing an exception", async function () { - assert.throws( + assertThrows( () => buildModule("AsyncModule", () => { throw new Error("User thrown error"); }), - /User thrown error/, + (e) => /User thrown error/.test(e.message), ); }); }); diff --git a/packages/ignition-core/test/call.ts b/packages/ignition-core/test/call.ts index 905b84c2310..26f8a3d0277 100644 --- a/packages/ignition-core/test/call.ts +++ b/packages/ignition-core/test/call.ts @@ -747,13 +747,11 @@ m.call(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.CONTRACT_CALL, ); - await assert.isFulfilled( - validateNamedContractCall( - future as any, - setupMockArtifactResolver({ Another: fakeArtifact }), - {}, - [], - ), + await validateNamedContractCall( + future as any, + setupMockArtifactResolver({ Another: fakeArtifact }), + {}, + [], ); }); @@ -909,13 +907,11 @@ m.call(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.CONTRACT_CALL, ); - await assert.isFulfilled( - validateNamedContractCall( - future as any, - setupMockArtifactResolver({ Another: fakeArtifact }), - {}, - [], - ), + await validateNamedContractCall( + future as any, + setupMockArtifactResolver({ Another: fakeArtifact }), + {}, + [], ); }); @@ -952,13 +948,11 @@ m.call(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.CONTRACT_CALL, ); - await assert.isFulfilled( - validateNamedContractCall( - future as any, - setupMockArtifactResolver({ Another: fakeArtifact }), - {}, - [], - ), + await validateNamedContractCall( + future as any, + setupMockArtifactResolver({ Another: fakeArtifact }), + {}, + [], ); }); diff --git a/packages/ignition-core/test/contract.ts b/packages/ignition-core/test/contract.ts index 367e25f76aa..12a2796a4f8 100644 --- a/packages/ignition-core/test/contract.ts +++ b/packages/ignition-core/test/contract.ts @@ -679,13 +679,11 @@ m.contract(..., { id: "MyUniqueId"})`, const [future] = getFuturesFromModule(module); - await assert.isFulfilled( - validateNamedContractDeployment( - future as any, - setupMockArtifactResolver({ Test: fakerArtifact }), - {}, - [], - ), + await validateNamedContractDeployment( + future as any, + setupMockArtifactResolver({ Test: fakerArtifact }), + {}, + [], ); }); @@ -834,13 +832,11 @@ m.contract(..., { id: "MyUniqueId"})`, const [future] = getFuturesFromModule(module); - await assert.isFulfilled( - validateNamedContractDeployment( - future as any, - setupMockArtifactResolver({ Test: fakerArtifact }), - {}, - [], - ), + await validateNamedContractDeployment( + future as any, + setupMockArtifactResolver({ Test: fakerArtifact }), + {}, + [], ); }); @@ -871,13 +867,11 @@ m.contract(..., { id: "MyUniqueId"})`, const [future] = getFuturesFromModule(module); - await assert.isFulfilled( - validateNamedContractDeployment( - future as any, - setupMockArtifactResolver({ Test: fakerArtifact }), - {}, - [], - ), + await validateNamedContractDeployment( + future as any, + setupMockArtifactResolver({ Test: fakerArtifact }), + {}, + [], ); }); diff --git a/packages/ignition-core/test/contractFromArtifact.ts b/packages/ignition-core/test/contractFromArtifact.ts index d211dc02f08..05eeaaab2bc 100644 --- a/packages/ignition-core/test/contractFromArtifact.ts +++ b/packages/ignition-core/test/contractFromArtifact.ts @@ -695,13 +695,11 @@ m.contract(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.CONTRACT_DEPLOYMENT, ); - await assert.isFulfilled( - validateArtifactContractDeployment( - future as any, - setupMockArtifactResolver({ Test: fakerArtifact }), - {}, - [], - ), + await validateArtifactContractDeployment( + future as any, + setupMockArtifactResolver({ Test: fakerArtifact }), + {}, + [], ); }); @@ -761,13 +759,11 @@ m.contract(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.CONTRACT_DEPLOYMENT, ); - await assert.isFulfilled( - validateArtifactContractDeployment( - future as any, - setupMockArtifactResolver({ Test: fakerArtifact }), - {}, - [], - ), + await validateArtifactContractDeployment( + future as any, + setupMockArtifactResolver({ Test: fakerArtifact }), + {}, + [], ); }); @@ -800,13 +796,11 @@ m.contract(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.CONTRACT_DEPLOYMENT, ); - await assert.isFulfilled( - validateArtifactContractDeployment( - future as any, - setupMockArtifactResolver({ Test: fakerArtifact }), - {}, - [], - ), + await validateArtifactContractDeployment( + future as any, + setupMockArtifactResolver({ Test: fakerArtifact }), + {}, + [], ); }); diff --git a/packages/ignition-core/test/encodeFunctionCall.ts b/packages/ignition-core/test/encodeFunctionCall.ts index 92aedfcca05..123093b1c64 100644 --- a/packages/ignition-core/test/encodeFunctionCall.ts +++ b/packages/ignition-core/test/encodeFunctionCall.ts @@ -724,13 +724,11 @@ m.encodeFunctionCall(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.ENCODE_FUNCTION_CALL, ); - await assert.isFulfilled( - validateNamedEncodeFunctionCall( - future as any, - setupMockArtifactResolver({ Another: fakeArtifact }), - {}, - [], - ), + await validateNamedEncodeFunctionCall( + future as any, + setupMockArtifactResolver({ Another: fakeArtifact }), + {}, + [], ); }); @@ -767,13 +765,11 @@ m.encodeFunctionCall(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.ENCODE_FUNCTION_CALL, ); - await assert.isFulfilled( - validateNamedEncodeFunctionCall( - future as any, - setupMockArtifactResolver({ Another: fakeArtifact }), - {}, - [], - ), + await validateNamedEncodeFunctionCall( + future as any, + setupMockArtifactResolver({ Another: fakeArtifact }), + {}, + [], ); }); diff --git a/packages/ignition-core/test/execution/abi.ts b/packages/ignition-core/test/execution/abi.ts index 7cdc15be708..f1645b4a966 100644 --- a/packages/ignition-core/test/execution/abi.ts +++ b/packages/ignition-core/test/execution/abi.ts @@ -1,5 +1,8 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; -import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; +import { + assertThrows, + assertThrowsHardhatError, +} from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; import { ethers } from "ethers"; @@ -466,9 +469,15 @@ describe("abi", () => { describe("encodeArtifactFunctionCall", () => { it("Should validate function names", () => { const artifact = callEncodingFixtures.WithComplexArguments; - assert.throws(() => { - encodeArtifactFunctionCall(artifact, "nonExistent", []); - }, "Function 'nonExistent' not found in contract WithComplexArguments"); + assertThrows( + () => { + encodeArtifactFunctionCall(artifact, "nonExistent", []); + }, + (e) => + e.message.includes( + "Function 'nonExistent' not found in contract WithComplexArguments", + ), + ); }); it("Should encode the arguments and return them", () => { diff --git a/packages/ignition-core/test/staticCall.ts b/packages/ignition-core/test/staticCall.ts index 1cb0357b137..17f90bc7896 100644 --- a/packages/ignition-core/test/staticCall.ts +++ b/packages/ignition-core/test/staticCall.ts @@ -1,5 +1,8 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; -import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; +import { + assertThrows, + assertThrowsHardhatError, +} from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; @@ -424,7 +427,7 @@ describe("static call", () => { }); it("should throw if the same function is statically called twice without differentiating ids", () => { - assert.throws( + assertThrows( () => buildModule("Module1", (m) => { const sameContract1 = m.contract("SameContract"); @@ -433,14 +436,16 @@ describe("static call", () => { return { sameContract1 }; }), - `The autogenerated future id ("Module1#SameContract.test") is already used. Please provide a unique id, as shown below: + (e) => + e.message + .includes(`The autogenerated future id ("Module1#SameContract.test") is already used. Please provide a unique id, as shown below: -m.staticCall(..., { id: "MyUniqueId"})`, +m.staticCall(..., { id: "MyUniqueId"})`), ); }); it("should throw if a static call tries to pass the same id twice", () => { - assert.throws( + assertThrows( () => buildModule("Module1", (m) => { const sameContract1 = m.contract("SameContract"); @@ -448,7 +453,10 @@ m.staticCall(..., { id: "MyUniqueId"})`, m.staticCall(sameContract1, "test", [], 0, { id: "first" }); return { sameContract1 }; }), - 'The future id "first" is already used, please provide a different one.', + (e) => + e.message.includes( + 'The future id "first" is already used, please provide a different one.', + ), ); }); }); @@ -987,13 +995,11 @@ m.staticCall(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.STATIC_CALL, ); - await assert.isFulfilled( - validateNamedStaticCall( - future as any, - setupMockArtifactResolver({ Another: fakerArtifact }), - {}, - [], - ), + await validateNamedStaticCall( + future as any, + setupMockArtifactResolver({ Another: fakerArtifact }), + {}, + [], ); }); @@ -1030,13 +1036,11 @@ m.staticCall(..., { id: "MyUniqueId"})`, (v) => v.type === FutureType.STATIC_CALL, ); - await assert.isFulfilled( - validateNamedStaticCall( - future as any, - setupMockArtifactResolver({ Another: fakeArtifact }), - {}, - [], - ), + await validateNamedStaticCall( + future as any, + setupMockArtifactResolver({ Another: fakeArtifact }), + {}, + [], ); }); diff --git a/packages/ignition-core/test/useModule.ts b/packages/ignition-core/test/useModule.ts index 70fb25f971a..9605ff71dda 100644 --- a/packages/ignition-core/test/useModule.ts +++ b/packages/ignition-core/test/useModule.ts @@ -127,17 +127,15 @@ describe("useModule", () => { }, }; - await assert.isFulfilled( - validate( - moduleWithSubmodule, - setupMockArtifactResolver({ - Contract1: fakerArtifact, - Contract2: fakerArtifact, - Contract3: fakerArtifact, - }), - moduleParams, - [], - ), + await validate( + moduleWithSubmodule, + setupMockArtifactResolver({ + Contract1: fakerArtifact, + Contract2: fakerArtifact, + Contract3: fakerArtifact, + }), + moduleParams, + [], ); }); From 0e476834425ec4ade1e3b61ec1650089d9ab7548 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 15:19:22 +0000 Subject: [PATCH 08/11] Check HardhatErrors by descriptor in ignition-core tests Three of the rewritten error assertions are HardhatErrors: compare them with assertThrowsHardhatError and assertRejectsWithHardhatError, by descriptor and message arguments, instead of by message text. --- .../internal/execution/jsonrpc-client.ts | 23 +++++++++++-------- packages/ignition-core/test/execution/abi.ts | 17 +++++++------- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index d0b77fc6149..b0b448b1a0c 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -1,6 +1,10 @@ import type { HardhatRuntimeEnvironment } from "hardhat/types/hre"; -import { assertRejects } from "@nomicfoundation/hardhat-test-utils"; +import { HardhatError } from "@nomicfoundation/hardhat-errors"; +import { + assertRejects, + assertRejectsWithHardhatError, +} from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; @@ -101,10 +105,11 @@ describe("JSON-RPC client", function () { maxFeePerGasLimit: 1n, }); - await assertRejects(failClient.getNetworkFees(), (e) => - /HHE10406: The calculated max fee per gas exceeds the configured limit./.test( - e.message, - ), + await assertRejectsWithHardhatError( + failClient.getNetworkFees(), + HardhatError.ERRORS.IGNITION.EXECUTION + .MAX_FEE_PER_GAS_EXCEEDS_GAS_LIMIT, + {}, ); }); @@ -558,7 +563,7 @@ describe("JSON-RPC client", function () { params: [], }); - await assertRejects( + await assertRejectsWithHardhatError( mockClient.call( { data: "0x", @@ -567,10 +572,8 @@ describe("JSON-RPC client", function () { }, "latest", ), - (e) => - /HHE10405\: The configured base fee exceeds the block gas limit\. Please reduce the configured base fee or increase the block gas limit\./.test( - e.message, - ), + HardhatError.ERRORS.IGNITION.EXECUTION.BASE_FEE_EXCEEDS_GAS_LIMIT, + {}, ); }); diff --git a/packages/ignition-core/test/execution/abi.ts b/packages/ignition-core/test/execution/abi.ts index f1645b4a966..f2b871a9169 100644 --- a/packages/ignition-core/test/execution/abi.ts +++ b/packages/ignition-core/test/execution/abi.ts @@ -1,8 +1,5 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; -import { - assertThrows, - assertThrowsHardhatError, -} from "@nomicfoundation/hardhat-test-utils"; +import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; import { ethers } from "ethers"; @@ -469,14 +466,16 @@ describe("abi", () => { describe("encodeArtifactFunctionCall", () => { it("Should validate function names", () => { const artifact = callEncodingFixtures.WithComplexArguments; - assertThrows( + assertThrowsHardhatError( () => { encodeArtifactFunctionCall(artifact, "nonExistent", []); }, - (e) => - e.message.includes( - "Function 'nonExistent' not found in contract WithComplexArguments", - ), + HardhatError.ERRORS.IGNITION.VALIDATION.OVERLOAD_NOT_FOUND, + { + name: "nonExistent", + eventOrFunction: "Function", + contractName: "WithComplexArguments", + }, ); }); From 0146b5d1c203875f044f777bf370154e1966bd32 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 16:20:04 +0000 Subject: [PATCH 09/11] Check staticCall's duplicate-id errors by descriptor The two duplicate future id tests in staticCall.ts throw an INVALID_MODULE HardhatError, as the equivalent tests in call.ts do. Compare them with assertThrowsHardhatError, as call.ts does, instead of by message text. --- packages/ignition-core/test/staticCall.ts | 25 +++++++++++------------ 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/packages/ignition-core/test/staticCall.ts b/packages/ignition-core/test/staticCall.ts index 17f90bc7896..9d966753ffe 100644 --- a/packages/ignition-core/test/staticCall.ts +++ b/packages/ignition-core/test/staticCall.ts @@ -1,8 +1,5 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; -import { - assertThrows, - assertThrowsHardhatError, -} from "@nomicfoundation/hardhat-test-utils"; +import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; import { assert } from "chai"; import { describe, it } from "node:test"; @@ -427,7 +424,7 @@ describe("static call", () => { }); it("should throw if the same function is statically called twice without differentiating ids", () => { - assertThrows( + assertThrowsHardhatError( () => buildModule("Module1", (m) => { const sameContract1 = m.contract("SameContract"); @@ -436,16 +433,17 @@ describe("static call", () => { return { sameContract1 }; }), - (e) => - e.message - .includes(`The autogenerated future id ("Module1#SameContract.test") is already used. Please provide a unique id, as shown below: + HardhatError.ERRORS.IGNITION.VALIDATION.INVALID_MODULE, + { + message: `The autogenerated future id ("Module1#SameContract.test") is already used. Please provide a unique id, as shown below: -m.staticCall(..., { id: "MyUniqueId"})`), +m.staticCall(..., { id: "MyUniqueId"})`, + }, ); }); it("should throw if a static call tries to pass the same id twice", () => { - assertThrows( + assertThrowsHardhatError( () => buildModule("Module1", (m) => { const sameContract1 = m.contract("SameContract"); @@ -453,10 +451,11 @@ m.staticCall(..., { id: "MyUniqueId"})`), m.staticCall(sameContract1, "test", [], 0, { id: "first" }); return { sameContract1 }; }), - (e) => - e.message.includes( + HardhatError.ERRORS.IGNITION.VALIDATION.INVALID_MODULE, + { + message: 'The future id "first" is already used, please provide a different one.', - ), + }, ); }); }); From 904b0c57671996bc3fd9365d95e4a95c532a5cf4 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:49:42 +0000 Subject: [PATCH 10/11] Use node:assert/strict in ignition-core tests Swap chai's assert for node:assert/strict. The assertions left after the previous commits are the same calls in both. node:assert/strict compares strictly, where chai's equal is loose and its deepEqual ignores prototypes. One test compared an account runtime value with a plain object; it now compares with an instance. --- .../internal/execution/jsonrpc-client.ts | 2 +- .../test-execution-result-fixtures.ts | 2 +- packages/ignition-core/test/batcher.ts | 2 +- packages/ignition-core/test/build-module.ts | 2 +- packages/ignition-core/test/call.ts | 2 +- packages/ignition-core/test/contract.ts | 2 +- packages/ignition-core/test/contractAt.ts | 2 +- .../ignition-core/test/contractAtFromArtifact.ts | 2 +- .../ignition-core/test/contractFromArtifact.ts | 2 +- packages/ignition-core/test/encodeFunctionCall.ts | 2 +- packages/ignition-core/test/execution/abi.ts | 2 +- .../test/execution/execution-engine.ts | 2 +- .../helpers/build-initialize-message-for.ts | 2 +- .../helpers/network-interaction-execution.ts | 2 +- .../future-processor/named-contract-at-deploy.ts | 2 +- .../future-processor/named-contract-deploy.ts | 2 +- .../ignition-core/test/execution/libraries.ts | 2 +- .../nonce-management/get-nonce-sync-messages.ts | 2 +- .../nonce-management/json-rpc-nonce-manager.ts | 2 +- .../test/execution/reducers/running-a-call.ts | 2 +- .../reducers/running-a-named-contract-deploy.ts | 2 +- .../reducers/running-a-named-library-deploy.ts | 2 +- .../reducers/running-a-read-event-arg.ts | 2 +- .../execution/reducers/running-a-static-call.ts | 2 +- .../execution/reducers/running-contract-at.ts | 2 +- .../test/execution/reducers/running-send-data.ts | 2 +- .../test/execution/reducers/start-a-new-run.ts | 2 +- .../utils/convert-evm-tuple-to-solidity-param.ts | 2 +- .../views/find-result-for-future-by-id.ts | 2 +- packages/ignition-core/test/getAccount.ts | 2 +- packages/ignition-core/test/getParameter.ts | 15 +++++++++------ packages/ignition-core/test/helpers.ts | 2 +- .../test/ignition-module-serializer.ts | 2 +- packages/ignition-core/test/library.ts | 2 +- .../ignition-core/test/libraryFromArtifact.ts | 2 +- packages/ignition-core/test/list-transactions.ts | 2 +- packages/ignition-core/test/listDeployments.ts | 2 +- packages/ignition-core/test/readEventArgument.ts | 2 +- .../futures/reconcileArtifactContractAt.ts | 2 +- .../reconcileArtifactContractDeployment.ts | 2 +- .../futures/reconcileArtifactLibraryDeployment.ts | 2 +- .../futures/reconcileNamedContractAt.ts | 2 +- .../futures/reconcileNamedContractCall.ts | 2 +- .../futures/reconcileNamedContractDeployment.ts | 2 +- .../futures/reconcileNamedEncodeFunctionCall.ts | 2 +- .../futures/reconcileNamedLibraryDeployment.ts | 2 +- .../futures/reconcileNamedStaticCall.ts | 2 +- .../futures/reconcileReadEventArgument.ts | 2 +- .../reconciliation/futures/reconcileSendData.ts | 2 +- .../ignition-core/test/reconciliation/helpers.ts | 2 +- .../test/reconciliation/reconciler.ts | 2 +- packages/ignition-core/test/send.ts | 2 +- packages/ignition-core/test/staticCall.ts | 2 +- packages/ignition-core/test/status.ts | 2 +- packages/ignition-core/test/track-transaction.ts | 2 +- .../ignition-core/test/types/deployment-loader.ts | 2 +- packages/ignition-core/test/useModule.ts | 2 +- .../ignition-core/test/utils/adjacency-list.ts | 2 +- .../test/utils/check-automined-network.ts | 2 +- .../test/utils/future-id-builders.ts | 2 +- .../test/utils/replace-within-arg.ts | 2 +- .../ignition-core/test/validations/id-rules.ts | 2 +- .../test/validations/identifier-validators.ts | 2 +- packages/ignition-core/test/verify.ts | 2 +- packages/ignition-core/test/wipe.ts | 2 +- 65 files changed, 73 insertions(+), 70 deletions(-) diff --git a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts index b0b448b1a0c..c78746acefe 100644 --- a/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts +++ b/packages/ignition-core/test-integrations/internal/execution/jsonrpc-client.ts @@ -5,7 +5,7 @@ import { assertRejects, assertRejectsWithHardhatError, } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { Artifact } from "../../../src/index.js"; diff --git a/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts b/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts index faa4e4d6fe5..992881a50c5 100644 --- a/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts +++ b/packages/ignition-core/test-integrations/test-execution-result-fixtures.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { diff --git a/packages/ignition-core/test/batcher.ts b/packages/ignition-core/test/batcher.ts index b65fd3d5081..da1be7e58e6 100644 --- a/packages/ignition-core/test/batcher.ts +++ b/packages/ignition-core/test/batcher.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/build-module.ts b/packages/ignition-core/test/build-module.ts index f84094f57a8..635ceda6823 100644 --- a/packages/ignition-core/test/build-module.ts +++ b/packages/ignition-core/test/build-module.ts @@ -3,7 +3,7 @@ import { assertThrows, assertThrowsHardhatError, } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/call.ts b/packages/ignition-core/test/call.ts index 26f8a3d0277..7d553870903 100644 --- a/packages/ignition-core/test/call.ts +++ b/packages/ignition-core/test/call.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; diff --git a/packages/ignition-core/test/contract.ts b/packages/ignition-core/test/contract.ts index 12a2796a4f8..01777f9bc50 100644 --- a/packages/ignition-core/test/contract.ts +++ b/packages/ignition-core/test/contract.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; diff --git a/packages/ignition-core/test/contractAt.ts b/packages/ignition-core/test/contractAt.ts index 88112080a03..88f54493ab2 100644 --- a/packages/ignition-core/test/contractAt.ts +++ b/packages/ignition-core/test/contractAt.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { FutureType } from "../src/index.js"; diff --git a/packages/ignition-core/test/contractAtFromArtifact.ts b/packages/ignition-core/test/contractAtFromArtifact.ts index 9bd8f65ff49..9911c53d785 100644 --- a/packages/ignition-core/test/contractAtFromArtifact.ts +++ b/packages/ignition-core/test/contractAtFromArtifact.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { FutureType } from "../src/index.js"; diff --git a/packages/ignition-core/test/contractFromArtifact.ts b/packages/ignition-core/test/contractFromArtifact.ts index 05eeaaab2bc..97d58a7beda 100644 --- a/packages/ignition-core/test/contractFromArtifact.ts +++ b/packages/ignition-core/test/contractFromArtifact.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { type Artifact, FutureType } from "../src/index.js"; diff --git a/packages/ignition-core/test/encodeFunctionCall.ts b/packages/ignition-core/test/encodeFunctionCall.ts index 123093b1c64..f00654eef9b 100644 --- a/packages/ignition-core/test/encodeFunctionCall.ts +++ b/packages/ignition-core/test/encodeFunctionCall.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; diff --git a/packages/ignition-core/test/execution/abi.ts b/packages/ignition-core/test/execution/abi.ts index f2b871a9169..0fe932dc9fd 100644 --- a/packages/ignition-core/test/execution/abi.ts +++ b/packages/ignition-core/test/execution/abi.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { ethers } from "ethers"; import type { Artifact } from "../../src/types/artifact.js"; diff --git a/packages/ignition-core/test/execution/execution-engine.ts b/packages/ignition-core/test/execution/execution-engine.ts index 7ac62067165..fd60b536f4a 100644 --- a/packages/ignition-core/test/execution/execution-engine.ts +++ b/packages/ignition-core/test/execution/execution-engine.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import path from "path"; diff --git a/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts b/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts index eb6182a1941..a09e3309e13 100644 --- a/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts +++ b/packages/ignition-core/test/execution/future-processor/helpers/build-initialize-message-for.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentLoader } from "../../../../src/internal/deployment-loader/types.js"; diff --git a/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts b/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts index e677942d5d6..7b2194ada94 100644 --- a/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts +++ b/packages/ignition-core/test/execution/future-processor/helpers/network-interaction-execution.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import { monitorOnchainInteraction } from "../../../../src/internal/execution/future-processor/handlers/monitor-onchain-interaction.js"; diff --git a/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts b/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts index aa0082a436f..a7ed3e828d4 100644 --- a/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts +++ b/packages/ignition-core/test/execution/future-processor/named-contract-at-deploy.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { NamedArtifactContractAtFuture } from "../../../src/index.js"; diff --git a/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts b/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts index a14b817676f..ea37273a81c 100644 --- a/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/future-processor/named-contract-deploy.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { NamedArtifactContractDeploymentFuture } from "../../../src/index.js"; diff --git a/packages/ignition-core/test/execution/libraries.ts b/packages/ignition-core/test/execution/libraries.ts index 3f5cfa07652..214bc13a06c 100644 --- a/packages/ignition-core/test/execution/libraries.ts +++ b/packages/ignition-core/test/execution/libraries.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { diff --git a/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts b/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts index 5f0925e8630..b09c8f92fb0 100644 --- a/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts +++ b/packages/ignition-core/test/execution/nonce-management/get-nonce-sync-messages.ts @@ -3,7 +3,7 @@ import { HardhatError, } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import { diff --git a/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts b/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts index 4ef71b1316d..c19c2a8713d 100644 --- a/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts +++ b/packages/ignition-core/test/execution/nonce-management/json-rpc-nonce-manager.ts @@ -2,7 +2,7 @@ import type { JsonRpcClient } from "../../../src/internal/execution/jsonrpc-clie import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { JsonRpcNonceManager } from "../../../src/internal/execution/nonce-management/json-rpc-nonce-manager.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-call.ts b/packages/ignition-core/test/execution/reducers/running-a-call.ts index 798aaeb6790..2209b8bfd00 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-call.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts index b0e58690319..a4e074e5986 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-contract-deploy.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts b/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts index 03d44678a91..d685e3d7532 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-named-library-deploy.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts b/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts index 5ce8f68bdd8..8f6aaddf121 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-read-event-arg.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-a-static-call.ts b/packages/ignition-core/test/execution/reducers/running-a-static-call.ts index be8c6de3595..e65688d8800 100644 --- a/packages/ignition-core/test/execution/reducers/running-a-static-call.ts +++ b/packages/ignition-core/test/execution/reducers/running-a-static-call.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-contract-at.ts b/packages/ignition-core/test/execution/reducers/running-contract-at.ts index cc0494ac25a..4a02ef119f0 100644 --- a/packages/ignition-core/test/execution/reducers/running-contract-at.ts +++ b/packages/ignition-core/test/execution/reducers/running-contract-at.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/running-send-data.ts b/packages/ignition-core/test/execution/reducers/running-send-data.ts index 6171cd9c804..c10c578c94f 100644 --- a/packages/ignition-core/test/execution/reducers/running-send-data.ts +++ b/packages/ignition-core/test/execution/reducers/running-send-data.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import type { DeploymentState } from "../../../src/internal/execution/types/deployment-state.js"; diff --git a/packages/ignition-core/test/execution/reducers/start-a-new-run.ts b/packages/ignition-core/test/execution/reducers/start-a-new-run.ts index 5f9c637edd0..64c6e9d919d 100644 --- a/packages/ignition-core/test/execution/reducers/start-a-new-run.ts +++ b/packages/ignition-core/test/execution/reducers/start-a-new-run.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import { deploymentStateReducer } from "../../../src/internal/execution/reducers/deployment-state-reducer.js"; diff --git a/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts b/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts index 65d05abb0d9..161e07fcaab 100644 --- a/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts +++ b/packages/ignition-core/test/execution/utils/convert-evm-tuple-to-solidity-param.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { EvmTuple } from "../../../src/internal/execution/types/evm-execution.js"; diff --git a/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts b/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts index 5ad39af651c..b6c0ed31fae 100644 --- a/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts +++ b/packages/ignition-core/test/execution/views/find-result-for-future-by-id.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { ExecutionResultType } from "../../../src/internal/execution/types/execution-result.js"; diff --git a/packages/ignition-core/test/getAccount.ts b/packages/ignition-core/test/getAccount.ts index aed161d96b7..2de51f45cc0 100644 --- a/packages/ignition-core/test/getAccount.ts +++ b/packages/ignition-core/test/getAccount.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/getParameter.ts b/packages/ignition-core/test/getParameter.ts index d4ceeafb4e8..a71c5f8e6c9 100644 --- a/packages/ignition-core/test/getParameter.ts +++ b/packages/ignition-core/test/getParameter.ts @@ -1,8 +1,11 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; -import { ModuleParameterRuntimeValueImplementation } from "../src/internal/module.js"; +import { + AccountRuntimeValueImplementation, + ModuleParameterRuntimeValueImplementation, +} from "../src/internal/module.js"; import type { SolidityParameterType } from "../src/types/module.js"; import { assertInstanceOf } from "./helpers.js"; @@ -122,10 +125,10 @@ describe("getParameter", () => { const param = mod.results.contract.constructorArgs[0]; assertInstanceOf(param, ModuleParameterRuntimeValueImplementation); assert.equal(param.name, "p"); - assert.deepEqual(param.defaultValue, { - accountIndex: 1, - type: "ACCOUNT", - }); + assert.deepEqual( + param.defaultValue, + new AccountRuntimeValueImplementation(1), + ); }); }); }); diff --git a/packages/ignition-core/test/helpers.ts b/packages/ignition-core/test/helpers.ts index b71aecb4a15..134712d337d 100644 --- a/packages/ignition-core/test/helpers.ts +++ b/packages/ignition-core/test/helpers.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import type { Artifact, ArtifactResolver } from "../src/index.js"; import { DeploymentLoader } from "../src/internal/deployment-loader/types.js"; diff --git a/packages/ignition-core/test/ignition-module-serializer.ts b/packages/ignition-core/test/ignition-module-serializer.ts index 5e719f4d887..2d5a7b7ea5e 100644 --- a/packages/ignition-core/test/ignition-module-serializer.ts +++ b/packages/ignition-core/test/ignition-module-serializer.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/library.ts b/packages/ignition-core/test/library.ts index 36721c52e7f..fb422818495 100644 --- a/packages/ignition-core/test/library.ts +++ b/packages/ignition-core/test/library.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/libraryFromArtifact.ts b/packages/ignition-core/test/libraryFromArtifact.ts index 90a0e7b7410..d894d872021 100644 --- a/packages/ignition-core/test/libraryFromArtifact.ts +++ b/packages/ignition-core/test/libraryFromArtifact.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/list-transactions.ts b/packages/ignition-core/test/list-transactions.ts index 2b3d81b6d4c..cf3128462d1 100644 --- a/packages/ignition-core/test/list-transactions.ts +++ b/packages/ignition-core/test/list-transactions.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import path from "path"; diff --git a/packages/ignition-core/test/listDeployments.ts b/packages/ignition-core/test/listDeployments.ts index 85ac0e51a9c..1ef493c575b 100644 --- a/packages/ignition-core/test/listDeployments.ts +++ b/packages/ignition-core/test/listDeployments.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import path from "node:path"; diff --git a/packages/ignition-core/test/readEventArgument.ts b/packages/ignition-core/test/readEventArgument.ts index 0b59bbd6976..d7a255c5f03 100644 --- a/packages/ignition-core/test/readEventArgument.ts +++ b/packages/ignition-core/test/readEventArgument.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts index e5b086cc649..7994f80a73c 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractAt.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts index 3a6feb2f714..552c6a01cf1 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactContractDeployment.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts index 1dadf860b49..758ff367b88 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileArtifactLibraryDeployment.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts index 12b856ee72c..2c6eb8a497b 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractAt.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts index 1c3860ff359..1ba85b5e044 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractCall.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts index 9098ef04c10..8717c50aee1 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedContractDeployment.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts index 2a44482f956..fbb3e243c4d 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts index 5c8a8a7897c..f3a73cbf711 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedLibraryDeployment.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts b/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts index f308d5f388e..503b321fafc 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileNamedStaticCall.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts b/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts index 857d312764d..6438b850c6c 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileReadEventArgument.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts b/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts index 738d6b777ec..8f3be4feb33 100644 --- a/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts +++ b/packages/ignition-core/test/reconciliation/futures/reconcileSendData.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../../src/build-module.js"; diff --git a/packages/ignition-core/test/reconciliation/helpers.ts b/packages/ignition-core/test/reconciliation/helpers.ts index 39649dd657b..8a96be89781 100644 --- a/packages/ignition-core/test/reconciliation/helpers.ts +++ b/packages/ignition-core/test/reconciliation/helpers.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import type { Artifact, diff --git a/packages/ignition-core/test/reconciliation/reconciler.ts b/packages/ignition-core/test/reconciliation/reconciler.ts index c75eeb44439..9be86001824 100644 --- a/packages/ignition-core/test/reconciliation/reconciler.ts +++ b/packages/ignition-core/test/reconciliation/reconciler.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../src/build-module.js"; diff --git a/packages/ignition-core/test/send.ts b/packages/ignition-core/test/send.ts index 110bc08c3a4..3dfc7d253dd 100644 --- a/packages/ignition-core/test/send.ts +++ b/packages/ignition-core/test/send.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../src/build-module.js"; diff --git a/packages/ignition-core/test/staticCall.ts b/packages/ignition-core/test/staticCall.ts index 9d966753ffe..a9e65586677 100644 --- a/packages/ignition-core/test/staticCall.ts +++ b/packages/ignition-core/test/staticCall.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { Artifact } from "../src/index.js"; diff --git a/packages/ignition-core/test/status.ts b/packages/ignition-core/test/status.ts index 762c31310e5..1acbb80c6af 100644 --- a/packages/ignition-core/test/status.ts +++ b/packages/ignition-core/test/status.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import path from "path"; diff --git a/packages/ignition-core/test/track-transaction.ts b/packages/ignition-core/test/track-transaction.ts index a2dee8dce62..e680d3d3d0c 100644 --- a/packages/ignition-core/test/track-transaction.ts +++ b/packages/ignition-core/test/track-transaction.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import path from "path"; diff --git a/packages/ignition-core/test/types/deployment-loader.ts b/packages/ignition-core/test/types/deployment-loader.ts index 50737fa2e17..060c7b9611a 100644 --- a/packages/ignition-core/test/types/deployment-loader.ts +++ b/packages/ignition-core/test/types/deployment-loader.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { EphemeralDeploymentLoader } from "../../src/internal/deployment-loader/ephemeral-deployment-loader.js"; diff --git a/packages/ignition-core/test/useModule.ts b/packages/ignition-core/test/useModule.ts index 9605ff71dda..81198bf50fc 100644 --- a/packages/ignition-core/test/useModule.ts +++ b/packages/ignition-core/test/useModule.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { type Artifact, DeploymentResultType } from "../src/index.js"; diff --git a/packages/ignition-core/test/utils/adjacency-list.ts b/packages/ignition-core/test/utils/adjacency-list.ts index d964ed552f4..418e4662dee 100644 --- a/packages/ignition-core/test/utils/adjacency-list.ts +++ b/packages/ignition-core/test/utils/adjacency-list.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { AdjacencyList } from "../../src/internal/utils/adjacency-list.js"; diff --git a/packages/ignition-core/test/utils/check-automined-network.ts b/packages/ignition-core/test/utils/check-automined-network.ts index 861bceb99a9..9c9fc6dc869 100644 --- a/packages/ignition-core/test/utils/check-automined-network.ts +++ b/packages/ignition-core/test/utils/check-automined-network.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { checkAutominedNetwork } from "../../src/internal/utils/check-automined-network.js"; diff --git a/packages/ignition-core/test/utils/future-id-builders.ts b/packages/ignition-core/test/utils/future-id-builders.ts index ae7a86bc4d3..0b0329ce30b 100644 --- a/packages/ignition-core/test/utils/future-id-builders.ts +++ b/packages/ignition-core/test/utils/future-id-builders.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { diff --git a/packages/ignition-core/test/utils/replace-within-arg.ts b/packages/ignition-core/test/utils/replace-within-arg.ts index c7c0abf7564..ca8d282eaa7 100644 --- a/packages/ignition-core/test/utils/replace-within-arg.ts +++ b/packages/ignition-core/test/utils/replace-within-arg.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it, beforeEach } from "node:test"; import { diff --git a/packages/ignition-core/test/validations/id-rules.ts b/packages/ignition-core/test/validations/id-rules.ts index 669ba883c1f..fdfda4dd9b8 100644 --- a/packages/ignition-core/test/validations/id-rules.ts +++ b/packages/ignition-core/test/validations/id-rules.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertThrowsHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { buildModule } from "../../src/build-module.js"; diff --git a/packages/ignition-core/test/validations/identifier-validators.ts b/packages/ignition-core/test/validations/identifier-validators.ts index a6898a271a0..8d21f340601 100644 --- a/packages/ignition-core/test/validations/identifier-validators.ts +++ b/packages/ignition-core/test/validations/identifier-validators.ts @@ -1,4 +1,4 @@ -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { isValidFunctionOrEventName } from "../../src/internal/utils/identifier-validators.js"; diff --git a/packages/ignition-core/test/verify.ts b/packages/ignition-core/test/verify.ts index f276cf91d27..93edc8d2ae9 100644 --- a/packages/ignition-core/test/verify.ts +++ b/packages/ignition-core/test/verify.ts @@ -3,7 +3,7 @@ import { fileURLToPath } from "node:url"; import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import { type VerifyResult, getVerificationInformation } from "../src/index.js"; diff --git a/packages/ignition-core/test/wipe.ts b/packages/ignition-core/test/wipe.ts index ba20ebdda45..452de06d81e 100644 --- a/packages/ignition-core/test/wipe.ts +++ b/packages/ignition-core/test/wipe.ts @@ -1,6 +1,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors"; import { assertRejectsWithHardhatError } from "@nomicfoundation/hardhat-test-utils"; -import { assert } from "chai"; +import assert from "node:assert/strict"; import { describe, it } from "node:test"; import type { ArtifactResolver } from "../src/index.js"; From ccc01000469f3a111858773a61ae4b2212acaf80 Mon Sep 17 00:00:00 2001 From: John Kane Date: Fri, 20 Nov 2026 12:50:24 +0000 Subject: [PATCH 11/11] Remove Mocha, chai and nyc from ignition-core Both suites now run on node:test with node:assert, so delete .mocharc.json, .nycrc and test/setup.ts, drop the Mocha, chai, chai-as-promised and nyc dependencies, and measure coverage with c8 over both suites. ignition-core now runs under test:file. --- packages/ignition-core/.mocharc.json | 11 ----------- packages/ignition-core/.nycrc | 12 ------------ packages/ignition-core/package.json | 15 ++++----------- packages/ignition-core/test/setup.ts | 4 ---- packages/ignition-core/tsconfig.json | 2 +- pnpm-lock.yaml | 27 +++------------------------ scripts/test-file.ts | 1 - 7 files changed, 8 insertions(+), 64 deletions(-) delete mode 100644 packages/ignition-core/.mocharc.json delete mode 100644 packages/ignition-core/.nycrc delete mode 100644 packages/ignition-core/test/setup.ts diff --git a/packages/ignition-core/.mocharc.json b/packages/ignition-core/.mocharc.json deleted file mode 100644 index 0b46dad4e9c..00000000000 --- a/packages/ignition-core/.mocharc.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "extension": ["ts"], - "node-option": ["import=tsx/esm"], - "file": "./test/setup.ts", - "timeout": 25000, - "exclude": [ - "./test/helpers/**/*", - "./test-integrations/fixture-projects/**/*", - "./test-integrations/helpers/**/*" - ] -} diff --git a/packages/ignition-core/.nycrc b/packages/ignition-core/.nycrc deleted file mode 100644 index 4f553664208..00000000000 --- a/packages/ignition-core/.nycrc +++ /dev/null @@ -1,12 +0,0 @@ -{ - "extends": "@istanbuljs/nyc-config-typescript", - "check-coverage": true, - "statements": 75, - "branches": 65, - "functions": 70, - "lines": 75, - "all": true, - "include": ["src/**/*.ts"], - "reporter": ["html", "lcov", "text", "text-summary"], - "report-dir": "coverage" -} diff --git a/packages/ignition-core/package.json b/packages/ignition-core/package.json index a1eb5a5edd1..616319d5df3 100644 --- a/packages/ignition-core/package.json +++ b/packages/ignition-core/package.json @@ -46,9 +46,9 @@ "api-extractor": "api-extractor run --local --verbose", "test": "pnpm test:unit && pnpm test:integrations", "test:debug": "DEBUG='ignition:*' pnpm test", - "test:coverage": "nyc mocha --recursive \"test/**/*.ts\" \"test-integrations/**/*.ts\"", - "test:unit": "node --import tsx/esm --import ./test/setup.ts --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test/*.ts\" \"test/!(fixture-projects|helpers)/**/*.ts\"", - "test:integrations": "node --import tsx/esm --import ./test/setup.ts --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test-integrations/*.ts\" \"test-integrations/!(fixture-projects|helpers)/**/*.ts\"", + "test:coverage": "c8 --reporter html --reporter text --all --exclude test --exclude test-integrations --exclude \"src/**/{types,type-extensions}.ts\" --src src node --import tsx/esm --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test/*.ts\" \"test/!(fixture-projects|helpers)/**/*.ts\" \"test-integrations/*.ts\" \"test-integrations/!(fixture-projects|helpers)/**/*.ts\"", + "test:unit": "node --import tsx/esm --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test/*.ts\" \"test/!(fixture-projects|helpers)/**/*.ts\"", + "test:integrations": "node --import tsx/esm --test --test-reporter=@nomicfoundation/hardhat-node-test-reporter \"test-integrations/*.ts\" \"test-integrations/!(fixture-projects|helpers)/**/*.ts\"", "clean": "rimraf dist", "prepack": "pnpm build" }, @@ -59,23 +59,16 @@ "README.md" ], "devDependencies": { - "@istanbuljs/nyc-config-typescript": "1.0.2", "@microsoft/api-extractor": "7.60.1", "@nomicfoundation/hardhat-node-test-reporter": "workspace:^3.1.0", "@nomicfoundation/hardhat-test-utils": "workspace:^", - "@types/chai": "^5.2.3", - "@types/chai-as-promised": "^8.0.1", "@types/lodash-es": "^4.17.12", - "@types/mocha": ">=10.0.10", "@types/ndjson": "2.0.4", "@types/node": "^22.0.0", - "chai": "^6.2.2", - "chai-as-promised": "^8.0.0", + "c8": "^12.0.0", "cross-env": "10.1.0", "eslint": "9.39.5", "hardhat": "workspace:^3.20.0", - "mocha": "^12.0.0", - "nyc": "18.0.0", "prettier": "3.9.10", "rimraf": "^6.1.3", "tsx": "^4.23.1", diff --git a/packages/ignition-core/test/setup.ts b/packages/ignition-core/test/setup.ts deleted file mode 100644 index 7b2c94ba8ca..00000000000 --- a/packages/ignition-core/test/setup.ts +++ /dev/null @@ -1,4 +0,0 @@ -import { use } from "chai"; -import chaiAsPromised from "chai-as-promised"; - -use(chaiAsPromised); diff --git a/packages/ignition-core/tsconfig.json b/packages/ignition-core/tsconfig.json index 90648acf218..bf6eaa7aa37 100644 --- a/packages/ignition-core/tsconfig.json +++ b/packages/ignition-core/tsconfig.json @@ -1,7 +1,7 @@ { "extends": "../config/tsconfig.base.json", "compilerOptions": { - "types": ["node", "mocha"] + "types": ["node"] }, "references": [ { "path": "../hardhat" }, diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 4178f081244..614369c0345 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1923,9 +1923,6 @@ importers: specifier: 2.0.0 version: 2.0.0 devDependencies: - '@istanbuljs/nyc-config-typescript': - specifier: 1.0.2 - version: 1.0.2(nyc@18.0.0(supports-color@8.1.1)) '@microsoft/api-extractor': specifier: 7.60.1 version: 7.60.1(@types/node@22.20.5) @@ -1935,30 +1932,18 @@ importers: '@nomicfoundation/hardhat-test-utils': specifier: workspace:^ version: link:../hardhat-test-utils - '@types/chai': - specifier: ^5.2.3 - version: 5.2.3 - '@types/chai-as-promised': - specifier: ^8.0.1 - version: 8.0.2 '@types/lodash-es': specifier: ^4.17.12 version: 4.17.12 - '@types/mocha': - specifier: '>=10.0.10' - version: 10.0.10 '@types/ndjson': specifier: 2.0.4 version: 2.0.4 '@types/node': specifier: ^22.0.0 version: 22.20.5 - chai: - specifier: ^6.2.2 - version: 6.3.0 - chai-as-promised: - specifier: ^8.0.0 - version: 8.0.2(chai@6.3.0) + c8: + specifier: ^12.0.0 + version: 12.0.0 cross-env: specifier: 10.1.0 version: 10.1.0 @@ -1968,12 +1953,6 @@ importers: hardhat: specifier: workspace:^3.20.0 version: link:../hardhat - mocha: - specifier: ^12.0.0 - version: 12.0.3 - nyc: - specifier: 18.0.0 - version: 18.0.0(supports-color@8.1.1) prettier: specifier: 3.9.10 version: 3.9.10 diff --git a/scripts/test-file.ts b/scripts/test-file.ts index 9209df9b46a..16cd37e1aa8 100644 --- a/scripts/test-file.ts +++ b/scripts/test-file.ts @@ -35,7 +35,6 @@ EXAMPLES // Remove entries here once a package migrates to node --test. const UNSUPPORTED_TEST_RUNNERS = new Set([ "@nomicfoundation/hardhat-ignition", - "@nomicfoundation/ignition-core", "@nomicfoundation/example-project", ]);