MargaySetup.ino (the hardware test/setup sketch in Project-Margay) currently includes <DS3231.h> (Andy's library), while Margay_Library itself uses DS3231_Logger (Bobby's implementation).
This means anyone using MargaySetup.ino needs to install DS3231 as an extra dependency that isn't otherwise required by the Margay ecosystem.
Questions to resolve:
- Did
DS3231_Logger exist when MargaySetup.ino was written, or was DS3231 used because it was the only option at the time?
- Is there a reason to prefer
DS3231 over DS3231_Logger for the hardware test sketch specifically?
If not, MargaySetup.ino should be updated to use DS3231_Logger to remove the unnecessary dependency and keep the library footprint consistent.
Note: DS3231_Logger may be renamed with an NW_ prefix in the future (per NorthernWidget naming conventions to avoid clashes). This issue should track that rename as well if/when it happens.
MargaySetup.ino(the hardware test/setup sketch in Project-Margay) currently includes<DS3231.h>(Andy's library), whileMargay_Libraryitself usesDS3231_Logger(Bobby's implementation).This means anyone using
MargaySetup.inoneeds to installDS3231as an extra dependency that isn't otherwise required by the Margay ecosystem.Questions to resolve:
DS3231_Loggerexist whenMargaySetup.inowas written, or wasDS3231used because it was the only option at the time?DS3231overDS3231_Loggerfor the hardware test sketch specifically?If not,
MargaySetup.inoshould be updated to useDS3231_Loggerto remove the unnecessary dependency and keep the library footprint consistent.Note:
DS3231_Loggermay be renamed with anNW_prefix in the future (per NorthernWidget naming conventions to avoid clashes). This issue should track that rename as well if/when it happens.