Turn FELIX86_ENVIRONMENT into an std::vector<std::string>

[OFFTKP]

Guest environment variables in config.toml and profiles are split using a semicolon. Since environment variables may have semicolons, this is bad design. Toml allows for arrays, so convert to vector. Should make sure environment is properly inherited by child processes.

[ljsteff]

Hello! I am a newer developer and I would love to take this on as my first issue. Is there any documentation or guidance you would recommend for working on this? Thank you!

[OFFTKP]

Our config file is a toml file. It is parsed in config.cpp (see loadFromToml). It currently handles types like std::string. I want FELIX86_ENVIRONMENT variable to be an std::vector<std::string>. In the toml file it would look like this:

environment = ["MY_ENV_VAR1=1", "MY_ENV_VAR2=1"]

while currently it looks like this

environment = "MY_ENV_VAR1=1;MY_ENV_VAR2=1"

So it needs changes in config.cpp to parse and stringify these correctly. config.inc type should change to std::vector<std::string>. Once done, main.cpp needs to also use these elements instead of doing split_string.

You also need to make sure the respective environment variable FELIX86_ENVIRONMENT works with an array passed, such as export FELIX86_ENVIRONMENT="['MY_ENV_VAR1=1', 'MY_ENV_VAR2=1']". The loadFromEnv function in config.cpp needs to be changed to match loadFromToml.

The toml11 library that we use should be able to handle this parsing/stringification.