1. Consistent data types for IDs. Ex: team_id bigint generated by default as identity VS. player_id text not null.
2. Could possibly implement some sort of authentication, so the API isn't abused and users have some sort of privacy.
3. Add NOT NULL to draft_name etc. basically other data which shouldn't be null when a team is created.
4. For more optimization, use VARCHAR instead of TEXT when the known length of the text is normally shorter.
5. Use of SERIAL types instead of bigint generated by default as identity, and add that change throughout the code for convention and good practice.
6. Could INDEX certain things like player_name so you can search up players easier, also good convention / practice.
7. Implement constraints for certain data like roster_size.
8. You have a draft player but not a remove player, this could be implemented.
9. Possibly add draft history to see previous drafts.
10. You can see teams and update the names, possibly add security to this so not anyone can update a teams name, also if you can update your team name, implement a delete team name.
11. If any of the delete endpoints are implemented, make sure security to uniqueness of the creator is implemented as well as and update to the rooms allowing another team to join as well as an update to a possible history implementation to remove the team from that draft history.
12. Could implement indexing of draft rooms as well to enable faster lookup of the draft room by name like a search endpoint for it.
1. Consistent data types for IDs. Ex: team_id bigint generated by default as identity VS. player_id text not null.
2. Could possibly implement some sort of authentication, so the API isn't abused and users have some sort of privacy.
3. Add NOT NULL to draft_name etc. basically other data which shouldn't be null when a team is created.
4. For more optimization, use VARCHAR instead of TEXT when the known length of the text is normally shorter.
5. Use of SERIAL types instead of bigint generated by default as identity, and add that change throughout the code for convention and good practice.
6. Could INDEX certain things like player_name so you can search up players easier, also good convention / practice.
7. Implement constraints for certain data like roster_size.
8. You have a draft player but not a remove player, this could be implemented.
9. Possibly add draft history to see previous drafts.
10. You can see teams and update the names, possibly add security to this so not anyone can update a teams name, also if you can update your team name, implement a delete team name.
11. If any of the delete endpoints are implemented, make sure security to uniqueness of the creator is implemented as well as and update to the rooms allowing another team to join as well as an update to a possible history implementation to remove the team from that draft history.
12. Could implement indexing of draft rooms as well to enable faster lookup of the draft room by name like a search endpoint for it.