Skip to content

Commit 59543af

Browse files
OVVO-Financialgithub-actions[bot]
authored andcommitted
Parity review reports for R NNS 0a17efca92b59e275c0499118d8c05684aa9880c
1 parent 3c2b753 commit 59543af

3 files changed

Lines changed: 43 additions & 17 deletions

File tree

sync/last_live_r_parity_report.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
- Skip install: `False`
77
- Live R recompute: `True`
88

9-
## Result: live R parity diverged
9+
## Result: manual review required
1010

11-
Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit.
11+
The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run:
1212

13-
Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py`
14-
Exit status: `1`
13+
- `R/Multivariate_Regression.R`
14+
- `R/Partition_Map.R`

sync/last_r_api_inspection.md

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,39 @@
22

33
## Changed files
44

5-
- `R/ARMA.R`
5+
- `R/Boost.R`
6+
- `R/Multivariate_Regression.R`
7+
- `R/Partition_Map.R`
8+
- `R/Regression.R`
9+
- `R/Stack.R`
610

711
## Affected Python modules
812

9-
- `src/nns/arma.py`
13+
- `src/nns/boost.py`
14+
- `src/nns/multivariate_regression.py`
15+
- `src/nns/regression.py`
16+
- `src/nns/stack.py`
1017

1118
## Parity tests to run
1219

20+
- `tests/docs/test_vignette_examples.py`
1321
- `tests/parity/test_practical_examples.py`
1422
- `tests/parity/test_r13_smoke.py`
1523

1624
## Cache scope
1725

18-
- `NNS.ARMA`
19-
- `NNS.ARMA.optim`
20-
- `NNS.VAR`
26+
- `NNS.M.reg`
27+
- `NNS.boost`
28+
- `NNS.reg`
29+
- `NNS.stack`
2130

2231
## Required actions
2332

2433
- Fresh cache required: `False`
2534
- Export review required: `False`
26-
- Unmapped R files present: `False`
35+
- Unmapped R files present: `True`
36+
37+
## Unmapped R files
38+
39+
- `R/Multivariate_Regression.R`
40+
- `R/Partition_Map.R`

sync/last_r_api_plan.json

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,34 @@
11
{
22
"changed_files": [
3-
"R/ARMA.R"
3+
"R/Boost.R",
4+
"R/Multivariate_Regression.R",
5+
"R/Partition_Map.R",
6+
"R/Regression.R",
7+
"R/Stack.R"
48
],
59
"affected_python_modules": [
6-
"src/nns/arma.py"
10+
"src/nns/boost.py",
11+
"src/nns/multivariate_regression.py",
12+
"src/nns/regression.py",
13+
"src/nns/stack.py"
714
],
815
"parity_tests": [
16+
"tests/docs/test_vignette_examples.py",
917
"tests/parity/test_practical_examples.py",
1018
"tests/parity/test_r13_smoke.py"
1119
],
1220
"cache_scope": [
13-
"NNS.ARMA",
14-
"NNS.ARMA.optim",
15-
"NNS.VAR"
21+
"NNS.M.reg",
22+
"NNS.boost",
23+
"NNS.reg",
24+
"NNS.stack"
1625
],
1726
"requires_fresh_cache": false,
1827
"requires_export_review": false,
19-
"has_unmapped_r_files": false,
20-
"unmapped_r_files": [],
28+
"has_unmapped_r_files": true,
29+
"unmapped_r_files": [
30+
"R/Multivariate_Regression.R",
31+
"R/Partition_Map.R"
32+
],
2133
"warnings": []
2234
}

0 commit comments

Comments
 (0)