Skip to content

Commit afd1640

Browse files
OVVO-Financialgithub-actions[bot]
authored andcommitted
Inspect R API update 8ba69a5421f52d0ddc6dee121caa59ad716edcb1
1 parent 3c2b753 commit afd1640

3 files changed

Lines changed: 28 additions & 29 deletions

File tree

sync/last_live_r_parity_report.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
- Plan: `sync/last_r_api_plan.json`
44
- R checkout: `upstream/NNS`
55
- Fresh cache requested: `False`
6-
- Skip install: `False`
7-
- Live R recompute: `True`
6+
- Skip install: `True`
7+
- Live R recompute: `False`
88

9-
## Result: live R parity diverged
9+
## Result: manual review required
1010

11-
Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit.
11+
The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run:
1212

13-
Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py`
14-
Exit status: `1`
13+
- `R/Multivariate_Regression.R`
14+
15+
## Workflow step outcome
16+
17+
- `run_live_r_parity_for_changed_api.py` step outcome: `failure`
18+
- Fresh cache requested: `false`
19+
- DESCRIPTION changed: `false`

sync/last_r_api_inspection.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,26 @@
22

33
## Changed files
44

5-
- `R/ARMA.R`
5+
- `R/Multivariate_Regression.R`
66

77
## Affected Python modules
88

9-
- `src/nns/arma.py`
9+
- None mapped
1010

1111
## Parity tests to run
1212

13-
- `tests/parity/test_practical_examples.py`
14-
- `tests/parity/test_r13_smoke.py`
13+
- None mapped
1514

1615
## Cache scope
1716

18-
- `NNS.ARMA`
19-
- `NNS.ARMA.optim`
20-
- `NNS.VAR`
17+
- None mapped
2118

2219
## Required actions
2320

2421
- Fresh cache required: `False`
2522
- Export review required: `False`
26-
- Unmapped R files present: `False`
23+
- Unmapped R files present: `True`
24+
25+
## Unmapped R files
26+
27+
- `R/Multivariate_Regression.R`

sync/last_r_api_plan.json

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,15 @@
11
{
22
"changed_files": [
3-
"R/ARMA.R"
4-
],
5-
"affected_python_modules": [
6-
"src/nns/arma.py"
7-
],
8-
"parity_tests": [
9-
"tests/parity/test_practical_examples.py",
10-
"tests/parity/test_r13_smoke.py"
11-
],
12-
"cache_scope": [
13-
"NNS.ARMA",
14-
"NNS.ARMA.optim",
15-
"NNS.VAR"
3+
"R/Multivariate_Regression.R"
164
],
5+
"affected_python_modules": [],
6+
"parity_tests": [],
7+
"cache_scope": [],
178
"requires_fresh_cache": false,
189
"requires_export_review": false,
19-
"has_unmapped_r_files": false,
20-
"unmapped_r_files": [],
10+
"has_unmapped_r_files": true,
11+
"unmapped_r_files": [
12+
"R/Multivariate_Regression.R"
13+
],
2114
"warnings": []
2215
}

0 commit comments

Comments
 (0)