Skip to content

Commit f5f6320

Browse files
OVVO-Financialgithub-actions[bot]
authored andcommitted
Parity review reports for R NNS 840f5fe9471439704fda1dd9e3b97f391b38b2f7
1 parent cb6d2d2 commit f5f6320

5 files changed

Lines changed: 71 additions & 14 deletions

File tree

changed_files.json

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
11
[
2-
"R/ARMA.R"
2+
"DESCRIPTION",
3+
"NNS_13.1.tar.gz",
4+
"NNS_13.1.zip",
5+
"R/ARMA.R",
6+
"R/ARMA_optim.R",
7+
"R/Multivariate_Regression.R",
8+
"R/NNS_VAR.R",
9+
"R/Regression.R",
10+
"R/Stack.R"
311
]

sync/last_live_r_parity_report.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
- Skip install: `False`
77
- Live R recompute: `True`
88

9-
## Result: live R parity diverged
9+
## Result: manual review required
1010

11-
Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit.
11+
The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run:
1212

13-
Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py`
14-
Exit status: `1`
13+
- `R/ARMA_optim.R`
14+
- `R/Multivariate_Regression.R`
15+
- `R/NNS_VAR.R`

sync/last_r_api_inspection.md

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,50 @@
22

33
## Changed files
44

5+
- `DESCRIPTION`
6+
- `NNS_13.1.tar.gz`
7+
- `NNS_13.1.zip`
58
- `R/ARMA.R`
9+
- `R/ARMA_optim.R`
10+
- `R/Multivariate_Regression.R`
11+
- `R/NNS_VAR.R`
12+
- `R/Regression.R`
13+
- `R/Stack.R`
614

715
## Affected Python modules
816

17+
- `pyproject.toml`
918
- `src/nns/arma.py`
19+
- `src/nns/multivariate_regression.py`
20+
- `src/nns/regression.py`
21+
- `src/nns/stack.py`
22+
- `tests/_r_cache.json`
23+
- `tools/NNS`
1024

1125
## Parity tests to run
1226

27+
- `tests/docs/test_vignette_examples.py`
28+
- `tests/parity`
1329
- `tests/parity/test_practical_examples.py`
1430
- `tests/parity/test_r13_smoke.py`
1531

1632
## Cache scope
1733

1834
- `NNS.ARMA`
1935
- `NNS.ARMA.optim`
36+
- `NNS.M.reg`
2037
- `NNS.VAR`
38+
- `NNS.reg`
39+
- `NNS.stack`
2140

2241
## Required actions
2342

24-
- Fresh cache required: `False`
43+
- Fresh cache required: `True`
2544
- Export review required: `False`
26-
- Unmapped R files present: `False`
45+
- Unmapped R files present: `True`
46+
47+
## Unmapped R files
48+
49+
- `R/ARMA_optim.R`
50+
- `R/Multivariate_Regression.R`
51+
- `R/NNS_VAR.R`

sync/last_r_api_plan.json

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,45 @@
11
{
22
"changed_files": [
3-
"R/ARMA.R"
3+
"DESCRIPTION",
4+
"NNS_13.1.tar.gz",
5+
"NNS_13.1.zip",
6+
"R/ARMA.R",
7+
"R/ARMA_optim.R",
8+
"R/Multivariate_Regression.R",
9+
"R/NNS_VAR.R",
10+
"R/Regression.R",
11+
"R/Stack.R"
412
],
513
"affected_python_modules": [
6-
"src/nns/arma.py"
14+
"pyproject.toml",
15+
"src/nns/arma.py",
16+
"src/nns/multivariate_regression.py",
17+
"src/nns/regression.py",
18+
"src/nns/stack.py",
19+
"tests/_r_cache.json",
20+
"tools/NNS"
721
],
822
"parity_tests": [
23+
"tests/docs/test_vignette_examples.py",
24+
"tests/parity",
925
"tests/parity/test_practical_examples.py",
1026
"tests/parity/test_r13_smoke.py"
1127
],
1228
"cache_scope": [
1329
"NNS.ARMA",
1430
"NNS.ARMA.optim",
15-
"NNS.VAR"
31+
"NNS.M.reg",
32+
"NNS.VAR",
33+
"NNS.reg",
34+
"NNS.stack"
1635
],
17-
"requires_fresh_cache": false,
36+
"requires_fresh_cache": true,
1837
"requires_export_review": false,
19-
"has_unmapped_r_files": false,
20-
"unmapped_r_files": [],
38+
"has_unmapped_r_files": true,
39+
"unmapped_r_files": [
40+
"R/ARMA_optim.R",
41+
"R/Multivariate_Regression.R",
42+
"R/NNS_VAR.R"
43+
],
2144
"warnings": []
2245
}

upstream/NNS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Subproject commit 7250bb627d12f6cdb1dbe60a8b8e50385e2a7c41
1+
Subproject commit 840f5fe9471439704fda1dd9e3b97f391b38b2f7

0 commit comments

Comments
 (0)