From 56b9fe051f42ae1e75115c174b9a67b911f491f7 Mon Sep 17 00:00:00 2001 From: OVVO-Financial <18292393+OVVO-Financial@users.noreply.github.com> Date: Sun, 14 Jun 2026 16:55:43 +0000 Subject: [PATCH] Parity review reports for R NNS 7250bb627d12f6cdb1dbe60a8b8e50385e2a7c41 --- changed_files.json | 6 +----- sync/last_live_r_parity_report.md | 13 +++++-------- sync/last_r_api_inspection.md | 4 ---- sync/last_r_api_plan.json | 6 +----- upstream/NNS | 2 +- 5 files changed, 8 insertions(+), 23 deletions(-) diff --git a/changed_files.json b/changed_files.json index 31fad1f7..2baefa4e 100644 --- a/changed_files.json +++ b/changed_files.json @@ -1,7 +1,3 @@ [ - "NNS_13.0.tar.gz", - "NNS_13.0.zip", - "R/ARMA.R", - "src/NNS.dll", - "tests/testthat/Rplots.pdf" + "R/ARMA.R" ] diff --git a/sync/last_live_r_parity_report.md b/sync/last_live_r_parity_report.md index c20a76e2..09eb22d7 100644 --- a/sync/last_live_r_parity_report.md +++ b/sync/last_live_r_parity_report.md @@ -4,14 +4,11 @@ - R checkout: `upstream/NNS` - Fresh cache requested: `False` - Skip install: `False` +- Live R recompute: `True` -## Result: R install failed +## Result: live R parity diverged -`scripts/install_local_r_nns.py` exited nonzero; live R parity could not be run. -Exit status: `1` - -## Workflow step outcome +Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit. -- `run_live_r_parity_for_changed_api.py` step outcome: `failure` -- Fresh cache requested: `false` -- DESCRIPTION changed: `false` +Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py` +Exit status: `1` diff --git a/sync/last_r_api_inspection.md b/sync/last_r_api_inspection.md index 1d5062ba..79defb7a 100644 --- a/sync/last_r_api_inspection.md +++ b/sync/last_r_api_inspection.md @@ -2,11 +2,7 @@ ## Changed files -- `NNS_13.0.tar.gz` -- `NNS_13.0.zip` - `R/ARMA.R` -- `src/NNS.dll` -- `tests/testthat/Rplots.pdf` ## Affected Python modules diff --git a/sync/last_r_api_plan.json b/sync/last_r_api_plan.json index 551e9741..6fef8d57 100644 --- a/sync/last_r_api_plan.json +++ b/sync/last_r_api_plan.json @@ -1,10 +1,6 @@ { "changed_files": [ - "NNS_13.0.tar.gz", - "NNS_13.0.zip", - "R/ARMA.R", - "src/NNS.dll", - "tests/testthat/Rplots.pdf" + "R/ARMA.R" ], "affected_python_modules": [ "src/nns/arma.py" diff --git a/upstream/NNS b/upstream/NNS index 3250bc98..7250bb62 160000 --- a/upstream/NNS +++ b/upstream/NNS @@ -1 +1 @@ -Subproject commit 3250bc985883e21eeb8fa4bf97656d8469de2836 +Subproject commit 7250bb627d12f6cdb1dbe60a8b8e50385e2a7c41